You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/17 21:56:28 UTC
[GitHub] [airflow] dstandish opened a new pull request #21653: Deprecate helper utility `days_ago`
dstandish opened a new pull request #21653:
URL: https://github.com/apache/airflow/pull/21653
This helper function is not all that helpful, introduces confusion (e.g. which timezone? how to handle DST?), and results in a "moving" start date for dags.
Vote thread: https://lists.apache.org/thread/qfqjb8m3v834yc8mxo1oqtjddhp9sggk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21653: Deprecate helper utility `days_ago`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21653:
URL: https://github.com/apache/airflow/pull/21653#issuecomment-1043675678
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish merged pull request #21653: Deprecate helper utility `days_ago`
Posted by GitBox <gi...@apache.org>.
dstandish merged pull request #21653:
URL: https://github.com/apache/airflow/pull/21653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21653: Deprecate helper utility `days_ago`
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21653:
URL: https://github.com/apache/airflow/pull/21653#issuecomment-1050118422
And here is why this was a GREAT move to deprecate days_ago: https://github.com/apache/airflow/issues/10824#issuecomment-1049762274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org