You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Antonio Sanso (JIRA)" <ji...@apache.org> on 2013/04/03 11:29:15 UTC

[jira] [Commented] (OAK-736) Enhancement to the PermissionProviderImpl constructor

    [ https://issues.apache.org/jira/browse/OAK-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620770#comment-13620770 ] 

Antonio Sanso commented on OAK-736:
-----------------------------------

Attaching simple patch


#P oak-core
Index: src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/PermissionProviderImpl.java
===================================================================
--- src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/PermissionProviderImpl.java	(revision 1463888)
+++ src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/PermissionProviderImpl.java	(working copy)
@@ -68,10 +68,10 @@
     private final CompiledPermissions compiledPermissions;
 
     public PermissionProviderImpl(@Nonnull Root root, @Nonnull Set<Principal> principals,
-                                  @Nonnull SecurityProvider securityProvider) {
+                                  @Nonnull AccessControlConfiguration acConfig) {
         this.root = root;
         this.workspaceName = checkNotNull(ImmutableRoot.getWorkspaceName(root));
-        acConfig = securityProvider.getAccessControlConfiguration();
+        this.acConfig = acConfig;
         if (principals.contains(SystemPrincipal.INSTANCE) || isAdmin(principals)) {
             compiledPermissions = AllPermissions.getInstance();
         } else {
@@ -84,6 +84,12 @@
         }
     }
 
+    public PermissionProviderImpl(@Nonnull Root root, @Nonnull Set<Principal> principals,
+    		@Nonnull SecurityProvider securityProvider) {
+    	this(root,principals,securityProvider.getAccessControlConfiguration());
+    }
+    
+    
     @Override
     public void refresh() {
         if (compiledPermissions instanceof CompiledPermissionImpl) {

                
> Enhancement to the PermissionProviderImpl constructor
> -----------------------------------------------------
>
>                 Key: OAK-736
>                 URL: https://issues.apache.org/jira/browse/OAK-736
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Antonio Sanso
>            Priority: Minor
>
> It would be nice if the PermissionProviderImpl would provide also a constructor that accept directly an AccessControlConfiguration rather than only a SecurityProvider.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira