You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/25 02:57:41 UTC

[jira] [Commented] (DRILL-5297) Print the plan text when plan pattern check fails in unit tests

    [ https://issues.apache.org/jira/browse/DRILL-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941540#comment-15941540 ] 

ASF GitHub Bot commented on DRILL-5297:
---------------------------------------

GitHub user chunhui-shi opened a pull request:

    https://github.com/apache/drill/pull/798

    DRILL-5297: when the generated plan mismatches, PlanTest print the ge…

    …nerated plan along with expected pattern

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chunhui-shi/drill DRILL-5297-pull

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/798.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #798
    
----
commit 5b92e13881c4c09e90f74073c436d374e7fd2254
Author: chunhui-shi <cs...@maprtech.com>
Date:   2017-03-25T01:40:15Z

    DRILL-5297: when the generated plan mismatches, PlanTest print the generated plan along with expected pattern

----


> Print the plan text when plan pattern check fails in unit tests 
> ----------------------------------------------------------------
>
>                 Key: DRILL-5297
>                 URL: https://issues.apache.org/jira/browse/DRILL-5297
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Chunhui Shi
>            Assignee: Chunhui Shi
>
> If we have a unit test did not generate expected plan, we will print only the expected pattern like this:
> Did not find expected pattern in plan: Scan.*FindLimit0Visitor"
> We should also print the plan here for debugging purpose.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)