[GitHub] gianm closed pull request #6760: Update two Javadocs to cite druid.generic.useDefaultValueForNull

[GitBox <gi...@apache.org>]

gianm closed pull request #6760: Update two Javadocs to cite druid.generic.useDefaultValueForNull
URL: https://github.com/apache/incubator-druid/pull/6760
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core/src/main/java/org/apache/druid/data/input/Row.java b/core/src/main/java/org/apache/druid/data/input/Row.java
index c45dac27163..2716a5b7d95 100644
--- a/core/src/main/java/org/apache/druid/data/input/Row.java
+++ b/core/src/main/java/org/apache/druid/data/input/Row.java
@@ -78,7 +78,8 @@
   /**
    * Returns the metric column value for the given column name. This method is different from {@link #getRaw} in two
    * aspects:
-   *  1. If the column is absent in the row, numeric zero is returned, rather than null.
+   *  1. If the column is absent in the row, either numeric zero or null will be returned, depending on
+   *     the value of druid.generic.useDefaultValueForNull.
    *  2. If the column has string value, an attempt is made to parse this value as a number.
    */
   @Nullable
diff --git a/core/src/main/java/org/apache/druid/data/input/Rows.java b/core/src/main/java/org/apache/druid/data/input/Rows.java
index 55e060edc0c..617905ca626 100644
--- a/core/src/main/java/org/apache/druid/data/input/Rows.java
+++ b/core/src/main/java/org/apache/druid/data/input/Rows.java
@@ -73,7 +73,8 @@
   }
 
   /**
-   * Convert an object to a number. Nulls are treated as zeroes.
+   * Convert an object to a number. Nulls are treated as zeroes unless
+   * druid.generic.useDefaultValueForNull is set to false.
    *
    * @param name       field name of the object being converted (may be used for exception messages)
    * @param inputValue the actual object being converted


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org