You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/20 21:50:30 UTC
[GitHub] [superset] ad-m opened a new pull request #18121: refactor: Migrate QueryAndSaveBtns to TS and stories
ad-m opened a new pull request #18121:
URL: https://github.com/apache/superset/pull/18121
### SUMMARY
Migrated QueryAndSaveBtns to TypeScript to apply direction outlined in #18100 .
In addition, added a new story to visualize that component.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Storybook can be used to verify that changes.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: see #18100
- [x] Required feature flags: no
- [x] Changes UI: no
- [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)): no
- [x] Migration is atomic, supports rollback & is backwards-compatible: N/A
- [x] Confirm DB migration upgrade and downgrade tested: N/A
- [x] Runtime estimates and downtime expectations provided: N/A
- [x] Introduces new feature or API: no
- [x] Removes existing feature or API: no
@kgabryje , @asadUllah58 You might be interested in this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #18121:
URL: https://github.com/apache/superset/pull/18121#issuecomment-1017984645
# [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18121](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f27e529) into [master](https://codecov.io/gh/apache/superset/commit/959b15eeca0a1e2e93c1a8688f8629d0f6ee5776?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (959b15e) will **decrease** coverage by `0.00%`.
> The diff coverage is `80.00%`.
> :exclamation: Current head f27e529 differs from pull request most recent head d597980. Consider uploading reports for the commit d597980 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18121 +/- ##
==========================================
- Coverage 65.97% 65.97% -0.01%
==========================================
Files 1584 1584
Lines 62003 62003
Branches 6243 6243
==========================================
- Hits 40905 40904 -1
- Misses 19497 19498 +1
Partials 1601 1601
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.90% <80.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `78.94% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLnRzeA==) | `42.85% <80.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [959b15e...d597980](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #18121:
URL: https://github.com/apache/superset/pull/18121#issuecomment-1017984645
# [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18121](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4eab4f8) into [master](https://codecov.io/gh/apache/superset/commit/959b15eeca0a1e2e93c1a8688f8629d0f6ee5776?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (959b15e) will **decrease** coverage by `0.00%`.
> The diff coverage is `80.00%`.
> :exclamation: Current head 4eab4f8 differs from pull request most recent head d597980. Consider uploading reports for the commit d597980 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18121 +/- ##
==========================================
- Coverage 65.97% 65.97% -0.01%
==========================================
Files 1584 1584
Lines 62003 62003
Branches 6243 6243
==========================================
- Hits 40905 40904 -1
- Misses 19497 19498 +1
Partials 1601 1601
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.90% <80.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLnRzeA==) | `42.85% <80.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [959b15e...d597980](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m commented on pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
ad-m commented on pull request #18121:
URL: https://github.com/apache/superset/pull/18121#issuecomment-1021691666
@kgabryje , CI finally fixed. Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #18121:
URL: https://github.com/apache/superset/pull/18121#issuecomment-1036379835
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #18121:
URL: https://github.com/apache/superset/pull/18121#issuecomment-1017984645
# [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18121](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (42ddb76) into [master](https://codecov.io/gh/apache/superset/commit/959b15eeca0a1e2e93c1a8688f8629d0f6ee5776?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (959b15e) will **decrease** coverage by `0.00%`.
> The diff coverage is `57.14%`.
> :exclamation: Current head 42ddb76 differs from pull request most recent head d597980. Consider uploading reports for the commit d597980 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18121 +/- ##
==========================================
- Coverage 65.97% 65.97% -0.01%
==========================================
Files 1584 1584
Lines 62003 62003
Branches 6243 6243
==========================================
- Hits 40905 40904 -1
- Misses 19497 19498 +1
Partials 1601 1601
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.90% <57.14%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLnRzeA==) | `42.85% <57.14%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [959b15e...d597980](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #18121:
URL: https://github.com/apache/superset/pull/18121#issuecomment-1017984645
# [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18121](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f27e529) into [master](https://codecov.io/gh/apache/superset/commit/959b15eeca0a1e2e93c1a8688f8629d0f6ee5776?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (959b15e) will **decrease** coverage by `0.00%`.
> The diff coverage is `80.00%`.
> :exclamation: Current head f27e529 differs from pull request most recent head d597980. Consider uploading reports for the commit d597980 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18121 +/- ##
==========================================
- Coverage 65.97% 65.97% -0.01%
==========================================
Files 1584 1584
Lines 62003 62003
Branches 6243 6243
==========================================
- Hits 40905 40904 -1
- Misses 19497 19498 +1
Partials 1601 1601
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.90% <80.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `78.94% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLnRzeA==) | `42.85% <80.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [959b15e...d597980](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18121:
URL: https://github.com/apache/superset/pull/18121#issuecomment-1036381484
@geido Ephemeral environment spinning up at http://54.212.112.30:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18121:
URL: https://github.com/apache/superset/pull/18121#issuecomment-1040379777
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18121:
URL: https://github.com/apache/superset/pull/18121#issuecomment-1040379777
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #18121:
URL: https://github.com/apache/superset/pull/18121#issuecomment-1017984645
# [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18121](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4eab4f8) into [master](https://codecov.io/gh/apache/superset/commit/959b15eeca0a1e2e93c1a8688f8629d0f6ee5776?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (959b15e) will **decrease** coverage by `0.00%`.
> The diff coverage is `80.00%`.
> :exclamation: Current head 4eab4f8 differs from pull request most recent head d597980. Consider uploading reports for the commit d597980 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18121 +/- ##
==========================================
- Coverage 65.97% 65.97% -0.01%
==========================================
Files 1584 1584
Lines 62003 62003
Branches 6243 6243
==========================================
- Hits 40905 40904 -1
- Misses 19497 19498 +1
Partials 1601 1601
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.90% <80.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLnRzeA==) | `42.85% <80.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [959b15e...d597980](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
geido merged pull request #18121:
URL: https://github.com/apache/superset/pull/18121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #18121:
URL: https://github.com/apache/superset/pull/18121#discussion_r789617124
##########
File path: superset-frontend/src/explore/components/QueryAndSaveBtns.tsx
##########
@@ -17,42 +17,37 @@
* under the License.
*/
import React from 'react';
-import PropTypes from 'prop-types';
import ButtonGroup from 'src/components/ButtonGroup';
import { t, useTheme } from '@superset-ui/core';
import { Tooltip } from 'src/components/Tooltip';
-import Button from 'src/components/Button';
+import Button, { ButtonStyle, OnClickHandler } from 'src/components/Button';
-const propTypes = {
- canAdd: PropTypes.bool.isRequired,
- onQuery: PropTypes.func.isRequired,
- onSave: PropTypes.func,
- onStop: PropTypes.func,
- loading: PropTypes.bool,
- chartIsStale: PropTypes.bool,
- errorMessage: PropTypes.node,
+export type QueryAndSaveBtnsProps = {
+ canAdd: boolean;
+ onQuery: OnClickHandler;
+ onSave: OnClickHandler;
+ onStop: OnClickHandler;
+ loading?: boolean;
+ chartIsStale?: boolean;
+ errorMessage: React.ReactElement | undefined;
};
-const defaultProps = {
- onStop: () => {},
- onSave: () => {},
-};
-
-export default function QueryAndSaveBtns({
- canAdd,
- onQuery,
- onSave,
- onStop,
- loading,
- chartIsStale,
- errorMessage,
-}) {
- let qryButtonStyle = 'tertiary';
+export default function QueryAndSaveBtns(props: QueryAndSaveBtnsProps) {
+ const {
+ canAdd,
+ onQuery = () => {},
+ onSave = () => {},
+ onStop = () => {},
+ loading,
+ chartIsStale,
+ errorMessage,
+ } = props;
+ let qryButtonStyle = 'tertiary' as ButtonStyle;
Review comment:
That will allow to remove the `as ButtonStyle` statements from lines 48 and 50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #18121:
URL: https://github.com/apache/superset/pull/18121#issuecomment-1017984645
# [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18121](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4eab4f8) into [master](https://codecov.io/gh/apache/superset/commit/959b15eeca0a1e2e93c1a8688f8629d0f6ee5776?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (959b15e) will **decrease** coverage by `0.00%`.
> The diff coverage is `80.00%`.
> :exclamation: Current head 4eab4f8 differs from pull request most recent head d597980. Consider uploading reports for the commit d597980 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18121 +/- ##
==========================================
- Coverage 65.97% 65.97% -0.01%
==========================================
Files 1584 1584
Lines 62003 62003
Branches 6243 6243
==========================================
- Hits 40905 40904 -1
- Misses 19497 19498 +1
Partials 1601 1601
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.90% <80.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLnRzeA==) | `42.85% <80.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [959b15e...d597980](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m closed pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
ad-m closed pull request #18121:
URL: https://github.com/apache/superset/pull/18121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
geido merged pull request #18121:
URL: https://github.com/apache/superset/pull/18121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #18121: refactor: Migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #18121:
URL: https://github.com/apache/superset/pull/18121#issuecomment-1017984645
# [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18121](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (42ddb76) into [master](https://codecov.io/gh/apache/superset/commit/959b15eeca0a1e2e93c1a8688f8629d0f6ee5776?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (959b15e) will **decrease** coverage by `0.00%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18121 +/- ##
==========================================
- Coverage 65.97% 65.97% -0.01%
==========================================
Files 1584 1584
Lines 62003 62003
Branches 6243 6243
==========================================
- Hits 40905 40904 -1
- Misses 19497 19498 +1
Partials 1601 1601
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.90% <57.14%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLnRzeA==) | `42.85% <57.14%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [959b15e...42ddb76](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #18121:
URL: https://github.com/apache/superset/pull/18121#issuecomment-1017984645
# [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18121](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f27e529) into [master](https://codecov.io/gh/apache/superset/commit/959b15eeca0a1e2e93c1a8688f8629d0f6ee5776?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (959b15e) will **decrease** coverage by `0.00%`.
> The diff coverage is `80.00%`.
> :exclamation: Current head f27e529 differs from pull request most recent head d597980. Consider uploading reports for the commit d597980 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18121 +/- ##
==========================================
- Coverage 65.97% 65.97% -0.01%
==========================================
Files 1584 1584
Lines 62003 62003
Branches 6243 6243
==========================================
- Hits 40905 40904 -1
- Misses 19497 19498 +1
Partials 1601 1601
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.90% <80.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `78.94% <ø> (ø)` | |
| [...ontend/src/explore/components/QueryAndSaveBtns.tsx](https://codecov.io/gh/apache/superset/pull/18121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLnRzeA==) | `42.85% <80.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [959b15e...d597980](https://codecov.io/gh/apache/superset/pull/18121?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m closed pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
ad-m closed pull request #18121:
URL: https://github.com/apache/superset/pull/18121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #18121:
URL: https://github.com/apache/superset/pull/18121#discussion_r789616863
##########
File path: superset-frontend/src/explore/components/QueryAndSaveBtns.tsx
##########
@@ -17,42 +17,37 @@
* under the License.
*/
import React from 'react';
-import PropTypes from 'prop-types';
import ButtonGroup from 'src/components/ButtonGroup';
import { t, useTheme } from '@superset-ui/core';
import { Tooltip } from 'src/components/Tooltip';
-import Button from 'src/components/Button';
+import Button, { ButtonStyle, OnClickHandler } from 'src/components/Button';
-const propTypes = {
- canAdd: PropTypes.bool.isRequired,
- onQuery: PropTypes.func.isRequired,
- onSave: PropTypes.func,
- onStop: PropTypes.func,
- loading: PropTypes.bool,
- chartIsStale: PropTypes.bool,
- errorMessage: PropTypes.node,
+export type QueryAndSaveBtnsProps = {
+ canAdd: boolean;
+ onQuery: OnClickHandler;
+ onSave: OnClickHandler;
+ onStop: OnClickHandler;
+ loading?: boolean;
+ chartIsStale?: boolean;
+ errorMessage: React.ReactElement | undefined;
};
-const defaultProps = {
- onStop: () => {},
- onSave: () => {},
-};
-
-export default function QueryAndSaveBtns({
- canAdd,
- onQuery,
- onSave,
- onStop,
- loading,
- chartIsStale,
- errorMessage,
-}) {
- let qryButtonStyle = 'tertiary';
+export default function QueryAndSaveBtns(props: QueryAndSaveBtnsProps) {
+ const {
+ canAdd,
+ onQuery = () => {},
+ onSave = () => {},
+ onStop = () => {},
+ loading,
+ chartIsStale,
+ errorMessage,
+ } = props;
+ let qryButtonStyle = 'tertiary' as ButtonStyle;
Review comment:
```suggestion
let qryButtonStyle: ButtonStyle = 'tertiary';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m commented on a change in pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
ad-m commented on a change in pull request #18121:
URL: https://github.com/apache/superset/pull/18121#discussion_r789640253
##########
File path: superset-frontend/src/explore/components/QueryAndSaveBtns.tsx
##########
@@ -17,42 +17,37 @@
* under the License.
*/
import React from 'react';
-import PropTypes from 'prop-types';
import ButtonGroup from 'src/components/ButtonGroup';
import { t, useTheme } from '@superset-ui/core';
import { Tooltip } from 'src/components/Tooltip';
-import Button from 'src/components/Button';
+import Button, { ButtonStyle, OnClickHandler } from 'src/components/Button';
-const propTypes = {
- canAdd: PropTypes.bool.isRequired,
- onQuery: PropTypes.func.isRequired,
- onSave: PropTypes.func,
- onStop: PropTypes.func,
- loading: PropTypes.bool,
- chartIsStale: PropTypes.bool,
- errorMessage: PropTypes.node,
+export type QueryAndSaveBtnsProps = {
+ canAdd: boolean;
+ onQuery: OnClickHandler;
+ onSave: OnClickHandler;
+ onStop: OnClickHandler;
+ loading?: boolean;
+ chartIsStale?: boolean;
+ errorMessage: React.ReactElement | undefined;
};
-const defaultProps = {
- onStop: () => {},
- onSave: () => {},
-};
-
-export default function QueryAndSaveBtns({
- canAdd,
- onQuery,
- onSave,
- onStop,
- loading,
- chartIsStale,
- errorMessage,
-}) {
- let qryButtonStyle = 'tertiary';
+export default function QueryAndSaveBtns(props: QueryAndSaveBtnsProps) {
+ const {
+ canAdd,
+ onQuery = () => {},
+ onSave = () => {},
+ onStop = () => {},
+ loading,
+ chartIsStale,
+ errorMessage,
+ } = props;
+ let qryButtonStyle = 'tertiary' as ButtonStyle;
Review comment:
Great idea. That notation in that situation is better. I applied that as a separate commit (Is squash necessary from me?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m closed pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
ad-m closed pull request #18121:
URL: https://github.com/apache/superset/pull/18121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m closed pull request #18121: refactor: migrate QueryAndSaveBtns to TypeScript and add stories
Posted by GitBox <gi...@apache.org>.
ad-m closed pull request #18121:
URL: https://github.com/apache/superset/pull/18121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org