You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/01/11 11:53:03 UTC
Review Request 55419: Changed mesos test helper createCommandInfo()
using optional value.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55419/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Avinash sridharan, Artem Harutyunyan, Jie Yu, and Vinod Kone.
Repository: mesos
Description
-------
The `value` in protobuf `CommandInfo` is an option. We should allow
`value` to be empty in mesos test helper createCommandInfo(). The
use case is the empty value with arguments in runtime isolator
scenario.
Diffs
-----
src/tests/mesos.hpp fa965150ae3e31b4d74dac57148a197402fd551e
Diff: https://reviews.apache.org/r/55419/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 55419: Changed mesos test helper
createCommandInfo() using optional value.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55419/#review161267
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 11, 2017, 11:53 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55419/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 11:53 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Avinash sridharan, Artem Harutyunyan, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `value` in protobuf `CommandInfo` is an option. We should allow
> `value` to be empty in mesos test helper createCommandInfo(). The
> use case is the empty value with arguments in runtime isolator
> scenario.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp fa965150ae3e31b4d74dac57148a197402fd551e
>
> Diff: https://reviews.apache.org/r/55419/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>