You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2020/01/03 12:48:05 UTC

[camel] branch master updated: Optimize a bit

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
     new 6a12be0  Optimize a bit
6a12be0 is described below

commit 6a12be02f9bf4b568fba860d162bce5cd703b182
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Fri Jan 3 13:47:19 2020 +0100

    Optimize a bit
---
 .../impl/converter/BaseTypeConverterRegistry.java      | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/core/camel-base/src/main/java/org/apache/camel/impl/converter/BaseTypeConverterRegistry.java b/core/camel-base/src/main/java/org/apache/camel/impl/converter/BaseTypeConverterRegistry.java
index f40b9fd..c6f3ea5 100644
--- a/core/camel-base/src/main/java/org/apache/camel/impl/converter/BaseTypeConverterRegistry.java
+++ b/core/camel-base/src/main/java/org/apache/camel/impl/converter/BaseTypeConverterRegistry.java
@@ -17,6 +17,7 @@
 package org.apache.camel.impl.converter;
 
 import java.io.BufferedReader;
+import java.io.File;
 import java.io.IOException;
 import java.io.InputStreamReader;
 import java.net.URL;
@@ -547,15 +548,14 @@ public abstract class BaseTypeConverterRegistry extends ServiceSupport implement
         for (URL url : loaderResources) {
             log.debug("Loading file {} to retrieve list of type converters, from url: {}", META_INF_SERVICES_TYPE_CONVERTER_LOADER, url);
             BufferedReader reader = IOHelper.buffered(new InputStreamReader(url.openStream(), StandardCharsets.UTF_8));
-            try {
-                reader.lines()
-                        .map(String::trim)
-                        .filter(l -> !l.isEmpty())
-                        .filter(l -> !l.startsWith("#"))
-                        .forEach(loaders::add);
-            } finally {
-                IOHelper.close(reader, url.toString(), log);
-            }
+            String line;
+            do {
+                line = reader.readLine();
+                if (line != null && !line.startsWith("#")) {
+                    loaders.add(line);
+                }
+            } while (line != null);
+            IOHelper.close(reader);
         }
         return loaders;
     }