You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/08/26 15:50:09 UTC
[GitHub] [openwhisk] tysonnorris opened a new pull request #4949: optionally use debian docker images
tysonnorris opened a new pull request #4949:
URL: https://github.com/apache/openwhisk/pull/4949
Optionally create debian based images.
## Description
Some infrastructure components in our operations have trouble with Alpine images, so we need to be able to use some other base image, e.g. Debian.
This PR allows creation of debian (or other) based images for controller, invoker, etc by
* adding additional Dockerfiles named with a suffix e.g. `Dockerfile-debian`
* using a gradle property to enable use of alternate Dockerfiles by suffix`-PdockerfileSuffix="-debian"`
* use default (`Dockerfile`) if no suffix specified, or not available for that module
There may be a better way to do some of this (e.g. use a different base image, and use build args or a multi stage build), but when some commands (e.g. user management) vary by distribution, it is simpler to just have a different Dockerfile.
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [x] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [x] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] tysonnorris merged pull request #4949: optionally use debian docker images
Posted by GitBox <gi...@apache.org>.
tysonnorris merged pull request #4949:
URL: https://github.com/apache/openwhisk/pull/4949
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] tysonnorris closed pull request #4949: optionally use debian docker images
Posted by GitBox <gi...@apache.org>.
tysonnorris closed pull request #4949:
URL: https://github.com/apache/openwhisk/pull/4949
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org