You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2015/04/10 18:46:03 UTC
Review Request 33087: DISPATCH-133: fix stale references to delete
deliveries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33087/
-----------------------------------------------------------
Review request for qpid, Alan Conway and Ted Ross.
Bugs: DISPATCH-133
https://issues.apache.org/jira/browse/DISPATCH-133
Repository: qpid-dispatch
Description
-------
Keep a list of deliveries in the parent link. Clean up all remaining deliveries when parent link is released.
Diffs
-----
trunk/include/qpid/dispatch/container.h 1672125
trunk/src/container.c 1672125
trunk/src/router_node.c 1672125
trunk/src/router_private.h 1672125
Diff: https://reviews.apache.org/r/33087/diff/
Testing
-------
Unit tests under valgrind.
Thanks,
Kenneth Giusti
Re: Review Request 33087: DISPATCH-133: fix stale references to delete
deliveries
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33087/#review79875
-----------------------------------------------------------
trunk/src/container.c
<https://reviews.apache.org/r/33087/#comment129462>
Link init code is duplicated and getting non-trival. Suggest centralizing in
qd_link_t* qd_link(pn_link_t *pn_link)
trunk/src/container.c
<https://reviews.apache.org/r/33087/#comment129463>
What does it mean to have a qd_delivery with no pn_delivery? Why don't we get rid of both at this point?
trunk/src/container.c
<https://reviews.apache.org/r/33087/#comment129464>
Remove, don't comment out.
- Alan Conway
On April 10, 2015, 6:31 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33087/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 6:31 p.m.)
>
>
> Review request for qpid, Alan Conway and Ted Ross.
>
>
> Bugs: DISPATCH-133
> https://issues.apache.org/jira/browse/DISPATCH-133
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> Keep a list of deliveries in the parent link. Clean up all remaining deliveries when parent link is released.
>
>
> Diffs
> -----
>
> trunk/include/qpid/dispatch/container.h 1672125
> trunk/src/container.c 1672125
> trunk/src/router_node.c 1672125
> trunk/src/router_private.h 1672125
>
> Diff: https://reviews.apache.org/r/33087/diff/
>
>
> Testing
> -------
>
> Unit tests under valgrind.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 33087: DISPATCH-133: fix stale references to delete
deliveries
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33087/
-----------------------------------------------------------
(Updated April 10, 2015, 6:31 p.m.)
Review request for qpid, Alan Conway and Ted Ross.
Bugs: DISPATCH-133
https://issues.apache.org/jira/browse/DISPATCH-133
Repository: qpid-dispatch
Description
-------
Keep a list of deliveries in the parent link. Clean up all remaining deliveries when parent link is released.
Diffs (updated)
-----
trunk/include/qpid/dispatch/container.h 1672125
trunk/src/container.c 1672125
trunk/src/router_node.c 1672125
trunk/src/router_private.h 1672125
Diff: https://reviews.apache.org/r/33087/diff/
Testing
-------
Unit tests under valgrind.
Thanks,
Kenneth Giusti
Re: Review Request 33087: DISPATCH-133: fix stale references to delete
deliveries
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33087/
-----------------------------------------------------------
(Updated April 10, 2015, 5:14 p.m.)
Review request for qpid, Alan Conway and Ted Ross.
Bugs: DISPATCH-133
https://issues.apache.org/jira/browse/DISPATCH-133
Repository: qpid-dispatch
Description
-------
Keep a list of deliveries in the parent link. Clean up all remaining deliveries when parent link is released.
Diffs (updated)
-----
trunk/include/qpid/dispatch/container.h 1672125
trunk/src/container.c 1672125
trunk/src/router_node.c 1672125
trunk/src/router_private.h 1672125
Diff: https://reviews.apache.org/r/33087/diff/
Testing
-------
Unit tests under valgrind.
Thanks,
Kenneth Giusti