You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by du...@apache.org on 2022/05/24 02:07:32 UTC
[rocketmq] branch develop updated: remove redundancy group name check of null (#4363)
This is an automated email from the ASF dual-hosted git repository.
duhengforever pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new de5e6d9e0 remove redundancy group name check of null (#4363)
de5e6d9e0 is described below
commit de5e6d9e06732e88df03b4df5759aa87ea017ac3
Author: lvshuang <un...@gmail.com>
AuthorDate: Tue May 24 10:07:25 2022 +0800
remove redundancy group name check of null (#4363)
---
.../rocketmq/client/impl/producer/DefaultMQProducerImpl.java | 4 ----
.../test/java/org/apache/rocketmq/client/ValidatorsTest.java | 10 ++++++++++
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
index dfc6de0e7..3be55ba49 100644
--- a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
+++ b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
@@ -236,10 +236,6 @@ public class DefaultMQProducerImpl implements MQProducerInner {
private void checkConfig() throws MQClientException {
Validators.checkGroup(this.defaultMQProducer.getProducerGroup());
- if (null == this.defaultMQProducer.getProducerGroup()) {
- throw new MQClientException("producerGroup is null", null);
- }
-
if (this.defaultMQProducer.getProducerGroup().equals(MixAll.DEFAULT_PRODUCER_GROUP)) {
throw new MQClientException("producerGroup can not equal " + MixAll.DEFAULT_PRODUCER_GROUP + ", please specify another one.",
null);
diff --git a/client/src/test/java/org/apache/rocketmq/client/ValidatorsTest.java b/client/src/test/java/org/apache/rocketmq/client/ValidatorsTest.java
index aa448dc07..90897d4af 100644
--- a/client/src/test/java/org/apache/rocketmq/client/ValidatorsTest.java
+++ b/client/src/test/java/org/apache/rocketmq/client/ValidatorsTest.java
@@ -28,6 +28,16 @@ import static org.junit.Assert.fail;
public class ValidatorsTest {
+ @Test
+ public void testGroupNameBlank() {
+ try {
+ Validators.checkGroup(null);
+ fail("excepted MQClientException for group name is blank");
+ } catch (MQClientException e) {
+ assertThat(e.getErrorMessage()).isEqualTo("the specified group is blank");
+ }
+ }
+
@Test
public void testCheckTopic_Success() throws MQClientException {
Validators.checkTopic("Hello");