You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bval.apache.org by mb...@apache.org on 2018/03/31 16:10:18 UTC
[1/2] bval git commit: TCK: handle default group redefinition
sequence resolution ambiguities
Repository: bval
Updated Branches:
refs/heads/bv2 d7210b030 -> d211bf058
TCK: handle default group redefinition sequence resolution ambiguities
Project: http://git-wip-us.apache.org/repos/asf/bval/repo
Commit: http://git-wip-us.apache.org/repos/asf/bval/commit/b62df467
Tree: http://git-wip-us.apache.org/repos/asf/bval/tree/b62df467
Diff: http://git-wip-us.apache.org/repos/asf/bval/diff/b62df467
Branch: refs/heads/bv2
Commit: b62df467555d6d1fdac3b7af7fd1fda8738f1d4e
Parents: d7210b0
Author: Matt Benson <mb...@apache.org>
Authored: Sat Mar 31 11:08:37 2018 -0500
Committer: Matt Benson <mb...@apache.org>
Committed: Sat Mar 31 11:08:37 2018 -0500
----------------------------------------------------------------------
bval-jsr/src/main/java/org/apache/bval/jsr/job/ValidationJob.java | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/bval/blob/b62df467/bval-jsr/src/main/java/org/apache/bval/jsr/job/ValidationJob.java
----------------------------------------------------------------------
diff --git a/bval-jsr/src/main/java/org/apache/bval/jsr/job/ValidationJob.java b/bval-jsr/src/main/java/org/apache/bval/jsr/job/ValidationJob.java
index e161879..f306d30 100644
--- a/bval-jsr/src/main/java/org/apache/bval/jsr/job/ValidationJob.java
+++ b/bval-jsr/src/main/java/org/apache/bval/jsr/job/ValidationJob.java
@@ -242,6 +242,8 @@ public abstract class ValidationJob<T> {
if (Default.class.equals(group)) {
final List<Class<?>> groupSequence = descriptor.getGroupSequence();
if (groupSequence != null) {
+ groups.assertDefaultGroupSequenceIsExpandable(
+ groupSequence.stream().map(Group::new).collect(Collectors.toList()));
return groupSequence.stream();
}
}
[2/2] bval git commit: no call for lazy GroupComputer
Posted by mb...@apache.org.
no call for lazy GroupComputer
Project: http://git-wip-us.apache.org/repos/asf/bval/repo
Commit: http://git-wip-us.apache.org/repos/asf/bval/commit/d211bf05
Tree: http://git-wip-us.apache.org/repos/asf/bval/tree/d211bf05
Diff: http://git-wip-us.apache.org/repos/asf/bval/diff/d211bf05
Branch: refs/heads/bv2
Commit: d211bf05803a9d3b16bde91ade459ed5a997f972
Parents: b62df46
Author: Matt Benson <mb...@apache.org>
Authored: Sat Mar 31 11:10:13 2018 -0500
Committer: Matt Benson <mb...@apache.org>
Committed: Sat Mar 31 11:10:13 2018 -0500
----------------------------------------------------------------------
.../main/java/org/apache/bval/jsr/ApacheValidatorFactory.java | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/bval/blob/d211bf05/bval-jsr/src/main/java/org/apache/bval/jsr/ApacheValidatorFactory.java
----------------------------------------------------------------------
diff --git a/bval-jsr/src/main/java/org/apache/bval/jsr/ApacheValidatorFactory.java b/bval-jsr/src/main/java/org/apache/bval/jsr/ApacheValidatorFactory.java
index de1ce3f..2b67c30 100644
--- a/bval-jsr/src/main/java/org/apache/bval/jsr/ApacheValidatorFactory.java
+++ b/bval-jsr/src/main/java/org/apache/bval/jsr/ApacheValidatorFactory.java
@@ -48,7 +48,6 @@ import org.apache.bval.jsr.util.AnnotationsManager;
import org.apache.bval.jsr.valueextraction.ValueExtractors;
import org.apache.bval.jsr.valueextraction.ValueExtractors.OnDuplicateContainerElementKey;
import org.apache.bval.util.CloseableAble;
-import org.apache.bval.util.Lazy;
import org.apache.bval.util.reflection.Reflection;
import org.apache.commons.weaver.privilizer.Privilizing;
import org.apache.commons.weaver.privilizer.Privilizing.CallTo;
@@ -95,13 +94,13 @@ public class ApacheValidatorFactory implements ValidatorFactory, Cloneable {
return result;
}
- private final Lazy<GroupsComputer> groupsComputer = new Lazy<>(GroupsComputer::new);
private final Map<String, String> properties;
private final AnnotationsManager annotationsManager;
private final DescriptorManager descriptorManager = new DescriptorManager(this);
private final MetadataBuilders metadataBuilders = new MetadataBuilders();
private final ConstraintCached constraintsCache = new ConstraintCached();
private final Collection<Closeable> toClose = new ArrayList<>();
+ private final GroupsComputer groupsComputer = new GroupsComputer();
private final ParticipantFactory participantFactory;
private final ValueExtractors valueExtractors;
@@ -360,7 +359,7 @@ public class ApacheValidatorFactory implements ValidatorFactory, Cloneable {
}
public GroupsComputer getGroupsComputer() {
- return groupsComputer.get();
+ return groupsComputer;
}
private void loadAndVerifyUserCustomizations(ConfigurationState configuration) {