You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/29 02:03:03 UTC

[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #638: add integration tests for rank, dense_rank, fix last_value evaluation with rank

Jimexist commented on a change in pull request #638:
URL: https://github.com/apache/arrow-datafusion/pull/638#discussion_r660227050



##########
File path: datafusion/tests/sql.rs
##########
@@ -952,15 +952,8 @@ async fn csv_query_window_with_order_by() -> Result<()> {
     let actual = execute(&mut ctx, sql).await;
     let expected = vec![

Review comment:
       ```
   -[ RECORD 1 ]-----------------------
   c9          | 28774375
   sum         | 61035129
   avg         | 61035129.000000000000
   count       | 1
   max         | 61035129
   min         | 61035129
   first_value | 61035129
   last_value  | 61035129
   nth_value   | ยค
   -[ RECORD 2 ]-----------------------
   c9          | 63044568
   sum         | -47938237
   avg         | -23969118.500000000000
   count       | 2
   max         | 61035129
   min         | -108973366
   first_value | 61035129
   last_value  | -108973366
   nth_value   | -108973366
   -[ RECORD 3 ]-----------------------
   c9          | 141047417
   sum         | 575165281
   avg         | 191721760.33333333
   count       | 3
   max         | 623103518
   min         | -108973366
   first_value | 61035129
   last_value  | 623103518
   nth_value   | -108973366
   -[ RECORD 4 ]-----------------------
   c9          | 141680161
   sum         | -1352462829
   avg         | -338115707.25000000
   count       | 4
   max         | 623103518
   min         | -1927628110
   first_value | 61035129
   last_value  | -1927628110
   nth_value   | -108973366
   -[ RECORD 5 ]-----------------------
   c9          | 145294611
   sum         | -3251637940
   avg         | -650327588.00000000
   count       | 5
   max         | 623103518
   min         | -1927628110
   first_value | 61035129
   last_value  | -1899175111
   nth_value   | -108973366
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org