You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@omid.apache.org by oh...@apache.org on 2018/12/04 08:27:07 UTC
[31/51] [partial] incubator-omid-site git commit: [wagon-git] commit
to branch asf-site 12/4/18 10:26 AM
http://git-wip-us.apache.org/repos/asf/incubator-omid-site/blob/9ccae1ee/xref-test/org/apache/omid/transaction/TestShadowCells.html
----------------------------------------------------------------------
diff --git a/xref-test/org/apache/omid/transaction/TestShadowCells.html b/xref-test/org/apache/omid/transaction/TestShadowCells.html
index 7a88640..f554e86 100644
--- a/xref-test/org/apache/omid/transaction/TestShadowCells.html
+++ b/xref-test/org/apache/omid/transaction/TestShadowCells.html
@@ -27,495 +27,503 @@
<a class="jxr_linenumber" name="17" href="#17">17</a> <em class="jxr_comment"> */</em>
<a class="jxr_linenumber" name="18" href="#18">18</a> <strong class="jxr_keyword">package</strong> org.apache.omid.transaction;
<a class="jxr_linenumber" name="19" href="#19">19</a>
-<a class="jxr_linenumber" name="20" href="#20">20</a> <strong class="jxr_keyword">import</strong> com.google.common.base.Charsets;
-<a class="jxr_linenumber" name="21" href="#21">21</a> <strong class="jxr_keyword">import</strong> com.google.common.base.Optional;
-<a class="jxr_linenumber" name="22" href="#22">22</a> <strong class="jxr_keyword">import</strong> com.google.common.util.concurrent.ListenableFuture;
-<a class="jxr_linenumber" name="23" href="#23">23</a> <strong class="jxr_keyword">import</strong> org.apache.omid.committable.CommitTable;
-<a class="jxr_linenumber" name="24" href="#24">24</a>
-<a class="jxr_linenumber" name="25" href="#25">25</a> <strong class="jxr_keyword">import</strong> org.apache.omid.metrics.NullMetricsProvider;
-<a class="jxr_linenumber" name="26" href="#26">26</a>
-<a class="jxr_linenumber" name="27" href="#27">27</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.Cell;
-<a class="jxr_linenumber" name="28" href="#28">28</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.CellUtil;
-<a class="jxr_linenumber" name="29" href="#29">29</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.KeyValue;
-<a class="jxr_linenumber" name="30" href="#30">30</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.Delete;
-<a class="jxr_linenumber" name="31" href="#31">31</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.Get;
-<a class="jxr_linenumber" name="32" href="#32">32</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.HBaseAdmin;
-<a class="jxr_linenumber" name="33" href="#33">33</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.HTableInterface;
-<a class="jxr_linenumber" name="34" href="#34">34</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.Put;
-<a class="jxr_linenumber" name="35" href="#35">35</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.Result;
-<a class="jxr_linenumber" name="36" href="#36">36</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.ResultScanner;
-<a class="jxr_linenumber" name="37" href="#37">37</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.Scan;
-<a class="jxr_linenumber" name="38" href="#38">38</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.util.Bytes;
-<a class="jxr_linenumber" name="39" href="#39">39</a> <strong class="jxr_keyword">import</strong> org.mockito.Matchers;
-<a class="jxr_linenumber" name="40" href="#40">40</a> <strong class="jxr_keyword">import</strong> org.mockito.invocation.InvocationOnMock;
-<a class="jxr_linenumber" name="41" href="#41">41</a> <strong class="jxr_keyword">import</strong> org.mockito.stubbing.Answer;
-<a class="jxr_linenumber" name="42" href="#42">42</a> <strong class="jxr_keyword">import</strong> org.slf4j.Logger;
-<a class="jxr_linenumber" name="43" href="#43">43</a> <strong class="jxr_keyword">import</strong> org.slf4j.LoggerFactory;
-<a class="jxr_linenumber" name="44" href="#44">44</a> <strong class="jxr_keyword">import</strong> org.testng.ITestContext;
-<a class="jxr_linenumber" name="45" href="#45">45</a> <strong class="jxr_keyword">import</strong> org.testng.annotations.Test;
-<a class="jxr_linenumber" name="46" href="#46">46</a>
-<a class="jxr_linenumber" name="47" href="#47">47</a> <strong class="jxr_keyword">import</strong> java.util.Arrays;
-<a class="jxr_linenumber" name="48" href="#48">48</a> <strong class="jxr_keyword">import</strong> java.util.List;
-<a class="jxr_linenumber" name="49" href="#49">49</a> <strong class="jxr_keyword">import</strong> java.util.concurrent.CountDownLatch;
-<a class="jxr_linenumber" name="50" href="#50">50</a> <strong class="jxr_keyword">import</strong> java.util.concurrent.atomic.AtomicBoolean;
-<a class="jxr_linenumber" name="51" href="#51">51</a>
-<a class="jxr_linenumber" name="52" href="#52">52</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.apache.omid.transaction.CellUtils.hasCell;
-<a class="jxr_linenumber" name="53" href="#53">53</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.apache.omid.transaction.CellUtils.hasShadowCell;
-<a class="jxr_linenumber" name="54" href="#54">54</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Matchers.any;
-<a class="jxr_linenumber" name="55" href="#55">55</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Matchers.anyInt;
-<a class="jxr_linenumber" name="56" href="#56">56</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Matchers.anyLong;
-<a class="jxr_linenumber" name="57" href="#57">57</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Mockito.doAnswer;
-<a class="jxr_linenumber" name="58" href="#58">58</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Mockito.doThrow;
-<a class="jxr_linenumber" name="59" href="#59">59</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Mockito.never;
-<a class="jxr_linenumber" name="60" href="#60">60</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Mockito.spy;
-<a class="jxr_linenumber" name="61" href="#61">61</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Mockito.times;
-<a class="jxr_linenumber" name="62" href="#62">62</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Mockito.verify;
-<a class="jxr_linenumber" name="63" href="#63">63</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.testng.Assert.assertFalse;
-<a class="jxr_linenumber" name="64" href="#64">64</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.testng.Assert.assertNull;
-<a class="jxr_linenumber" name="65" href="#65">65</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.testng.Assert.assertTrue;
-<a class="jxr_linenumber" name="66" href="#66">66</a>
-<a class="jxr_linenumber" name="67" href="#67">67</a> @Test(groups = <span class="jxr_string">"sharedHBase"</span>)
-<a class="jxr_linenumber" name="68" href="#68">68</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">class</strong> <a href="../../../../org/apache/omid/transaction/TestShadowCells.html">TestShadowCells</a> <strong class="jxr_keyword">extends</strong> <a href="../../../../org/apache/omid/transaction/OmidTestBase.html">OmidTestBase</a> {
-<a class="jxr_linenumber" name="69" href="#69">69</a>
-<a class="jxr_linenumber" name="70" href="#70">70</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> Logger LOG = LoggerFactory.getLogger(TestShadowCells.<strong class="jxr_keyword">class</strong>);
-<a class="jxr_linenumber" name="71" href="#71">71</a>
-<a class="jxr_linenumber" name="72" href="#72">72</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> String TSO_SERVER_HOST = <span class="jxr_string">"localhost"</span>;
-<a class="jxr_linenumber" name="73" href="#73">73</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> <strong class="jxr_keyword">int</strong> TSO_SERVER_PORT = 1234;
-<a class="jxr_linenumber" name="74" href="#74">74</a>
-<a class="jxr_linenumber" name="75" href="#75">75</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> String TEST_TABLE = <span class="jxr_string">"test"</span>;
-<a class="jxr_linenumber" name="76" href="#76">76</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> String TEST_FAMILY = <span class="jxr_string">"data"</span>;
-<a class="jxr_linenumber" name="77" href="#77">77</a>
-<a class="jxr_linenumber" name="78" href="#78">78</a> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] row = Bytes.toBytes(<span class="jxr_string">"test-sc"</span>);
-<a class="jxr_linenumber" name="79" href="#79">79</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] row1 = Bytes.toBytes(<span class="jxr_string">"test-sc1"</span>);
-<a class="jxr_linenumber" name="80" href="#80">80</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] row2 = Bytes.toBytes(<span class="jxr_string">"test-sc2"</span>);
-<a class="jxr_linenumber" name="81" href="#81">81</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] row3 = Bytes.toBytes(<span class="jxr_string">"test-sc3"</span>);
-<a class="jxr_linenumber" name="82" href="#82">82</a> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] family = Bytes.toBytes(TEST_FAMILY);
-<a class="jxr_linenumber" name="83" href="#83">83</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] qualifier = Bytes.toBytes(<span class="jxr_string">"testdata"</span>);
-<a class="jxr_linenumber" name="84" href="#84">84</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] data1 = Bytes.toBytes(<span class="jxr_string">"testWrite-1"</span>);
-<a class="jxr_linenumber" name="85" href="#85">85</a>
+<a class="jxr_linenumber" name="20" href="#20">20</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.apache.omid.transaction.CellUtils.hasCell;
+<a class="jxr_linenumber" name="21" href="#21">21</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.apache.omid.transaction.CellUtils.hasShadowCell;
+<a class="jxr_linenumber" name="22" href="#22">22</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Matchers.any;
+<a class="jxr_linenumber" name="23" href="#23">23</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Matchers.anyInt;
+<a class="jxr_linenumber" name="24" href="#24">24</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Matchers.anyLong;
+<a class="jxr_linenumber" name="25" href="#25">25</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Mockito.doAnswer;
+<a class="jxr_linenumber" name="26" href="#26">26</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Mockito.doThrow;
+<a class="jxr_linenumber" name="27" href="#27">27</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Mockito.never;
+<a class="jxr_linenumber" name="28" href="#28">28</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Mockito.spy;
+<a class="jxr_linenumber" name="29" href="#29">29</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Mockito.times;
+<a class="jxr_linenumber" name="30" href="#30">30</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.mockito.Mockito.verify;
+<a class="jxr_linenumber" name="31" href="#31">31</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.testng.Assert.assertFalse;
+<a class="jxr_linenumber" name="32" href="#32">32</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.testng.Assert.assertNull;
+<a class="jxr_linenumber" name="33" href="#33">33</a> <strong class="jxr_keyword">import</strong> <strong class="jxr_keyword">static</strong> org.testng.Assert.assertTrue;
+<a class="jxr_linenumber" name="34" href="#34">34</a>
+<a class="jxr_linenumber" name="35" href="#35">35</a> <strong class="jxr_keyword">import</strong> java.util.Arrays;
+<a class="jxr_linenumber" name="36" href="#36">36</a> <strong class="jxr_keyword">import</strong> java.util.List;
+<a class="jxr_linenumber" name="37" href="#37">37</a> <strong class="jxr_keyword">import</strong> java.util.Map;
+<a class="jxr_linenumber" name="38" href="#38">38</a> <strong class="jxr_keyword">import</strong> java.util.concurrent.CountDownLatch;
+<a class="jxr_linenumber" name="39" href="#39">39</a> <strong class="jxr_keyword">import</strong> java.util.concurrent.atomic.AtomicBoolean;
+<a class="jxr_linenumber" name="40" href="#40">40</a>
+<a class="jxr_linenumber" name="41" href="#41">41</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.Cell;
+<a class="jxr_linenumber" name="42" href="#42">42</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.CellUtil;
+<a class="jxr_linenumber" name="43" href="#43">43</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.KeyValue;
+<a class="jxr_linenumber" name="44" href="#44">44</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.TableName;
+<a class="jxr_linenumber" name="45" href="#45">45</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.Delete;
+<a class="jxr_linenumber" name="46" href="#46">46</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.Get;
+<a class="jxr_linenumber" name="47" href="#47">47</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.HBaseAdmin;
+<a class="jxr_linenumber" name="48" href="#48">48</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.Put;
+<a class="jxr_linenumber" name="49" href="#49">49</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.Result;
+<a class="jxr_linenumber" name="50" href="#50">50</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.ResultScanner;
+<a class="jxr_linenumber" name="51" href="#51">51</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.Scan;
+<a class="jxr_linenumber" name="52" href="#52">52</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.client.Table;
+<a class="jxr_linenumber" name="53" href="#53">53</a> <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.util.Bytes;
+<a class="jxr_linenumber" name="54" href="#54">54</a> <strong class="jxr_keyword">import</strong> org.apache.omid.committable.CommitTable;
+<a class="jxr_linenumber" name="55" href="#55">55</a> <strong class="jxr_keyword">import</strong> org.apache.omid.metrics.NullMetricsProvider;
+<a class="jxr_linenumber" name="56" href="#56">56</a> <strong class="jxr_keyword">import</strong> org.mockito.Matchers;
+<a class="jxr_linenumber" name="57" href="#57">57</a> <strong class="jxr_keyword">import</strong> org.mockito.invocation.InvocationOnMock;
+<a class="jxr_linenumber" name="58" href="#58">58</a> <strong class="jxr_keyword">import</strong> org.mockito.stubbing.Answer;
+<a class="jxr_linenumber" name="59" href="#59">59</a> <strong class="jxr_keyword">import</strong> org.slf4j.Logger;
+<a class="jxr_linenumber" name="60" href="#60">60</a> <strong class="jxr_keyword">import</strong> org.slf4j.LoggerFactory;
+<a class="jxr_linenumber" name="61" href="#61">61</a> <strong class="jxr_keyword">import</strong> org.testng.ITestContext;
+<a class="jxr_linenumber" name="62" href="#62">62</a> <strong class="jxr_keyword">import</strong> org.testng.annotations.Test;
+<a class="jxr_linenumber" name="63" href="#63">63</a>
+<a class="jxr_linenumber" name="64" href="#64">64</a> <strong class="jxr_keyword">import</strong> com.google.common.base.Charsets;
+<a class="jxr_linenumber" name="65" href="#65">65</a> <strong class="jxr_keyword">import</strong> com.google.common.base.Optional;
+<a class="jxr_linenumber" name="66" href="#66">66</a> <strong class="jxr_keyword">import</strong> com.google.common.util.concurrent.ListenableFuture;
+<a class="jxr_linenumber" name="67" href="#67">67</a>
+<a class="jxr_linenumber" name="68" href="#68">68</a> @Test(groups = <span class="jxr_string">"sharedHBase"</span>)
+<a class="jxr_linenumber" name="69" href="#69">69</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">class</strong> <a href="../../../../org/apache/omid/transaction/TestShadowCells.html">TestShadowCells</a> <strong class="jxr_keyword">extends</strong> <a href="../../../../org/apache/omid/transaction/OmidTestBase.html">OmidTestBase</a> {
+<a class="jxr_linenumber" name="70" href="#70">70</a>
+<a class="jxr_linenumber" name="71" href="#71">71</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> Logger LOG = LoggerFactory.getLogger(TestShadowCells.<strong class="jxr_keyword">class</strong>);
+<a class="jxr_linenumber" name="72" href="#72">72</a>
+<a class="jxr_linenumber" name="73" href="#73">73</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> String TSO_SERVER_HOST = <span class="jxr_string">"localhost"</span>;
+<a class="jxr_linenumber" name="74" href="#74">74</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> <strong class="jxr_keyword">int</strong> TSO_SERVER_PORT = 1234;
+<a class="jxr_linenumber" name="75" href="#75">75</a>
+<a class="jxr_linenumber" name="76" href="#76">76</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> String TEST_TABLE = <span class="jxr_string">"test"</span>;
+<a class="jxr_linenumber" name="77" href="#77">77</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> String TEST_FAMILY = <span class="jxr_string">"data"</span>;
+<a class="jxr_linenumber" name="78" href="#78">78</a>
+<a class="jxr_linenumber" name="79" href="#79">79</a> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] row = Bytes.toBytes(<span class="jxr_string">"test-sc"</span>);
+<a class="jxr_linenumber" name="80" href="#80">80</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] row1 = Bytes.toBytes(<span class="jxr_string">"test-sc1"</span>);
+<a class="jxr_linenumber" name="81" href="#81">81</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] row2 = Bytes.toBytes(<span class="jxr_string">"test-sc2"</span>);
+<a class="jxr_linenumber" name="82" href="#82">82</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] row3 = Bytes.toBytes(<span class="jxr_string">"test-sc3"</span>);
+<a class="jxr_linenumber" name="83" href="#83">83</a> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] family = Bytes.toBytes(TEST_FAMILY);
+<a class="jxr_linenumber" name="84" href="#84">84</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] qualifier = Bytes.toBytes(<span class="jxr_string">"testdata"</span>);
+<a class="jxr_linenumber" name="85" href="#85">85</a> <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] data1 = Bytes.toBytes(<span class="jxr_string">"testWrite-1"</span>);
<a class="jxr_linenumber" name="86" href="#86">86</a>
-<a class="jxr_linenumber" name="87" href="#87">87</a> @Test(timeOut = 60_000)
-<a class="jxr_linenumber" name="88" href="#88">88</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testShadowCellsBasics(ITestContext context) <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="89" href="#89">89</a>
-<a class="jxr_linenumber" name="90" href="#90">90</a> TransactionManager tm = newTransactionManager(context);
-<a class="jxr_linenumber" name="91" href="#91">91</a>
-<a class="jxr_linenumber" name="92" href="#92">92</a> TTable table = <strong class="jxr_keyword">new</strong> TTable(hbaseConf, TEST_TABLE);
-<a class="jxr_linenumber" name="93" href="#93">93</a>
-<a class="jxr_linenumber" name="94" href="#94">94</a> HBaseTransaction t1 = (HBaseTransaction) tm.begin();
-<a class="jxr_linenumber" name="95" href="#95">95</a>
-<a class="jxr_linenumber" name="96" href="#96">96</a> <em class="jxr_comment">// Test shadow cells are created properly</em>
-<a class="jxr_linenumber" name="97" href="#97">97</a> Put put = <strong class="jxr_keyword">new</strong> Put(row);
-<a class="jxr_linenumber" name="98" href="#98">98</a> put.add(family, qualifier, data1);
-<a class="jxr_linenumber" name="99" href="#99">99</a> table.put(t1, put);
-<a class="jxr_linenumber" name="100" href="#100">100</a>
-<a class="jxr_linenumber" name="101" href="#101">101</a> <em class="jxr_comment">// Before commit test that only the cell is there</em>
-<a class="jxr_linenumber" name="102" href="#102">102</a> assertTrue(hasCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
-<a class="jxr_linenumber" name="103" href="#103">103</a> <span class="jxr_string">"Cell should be there"</span>);
-<a class="jxr_linenumber" name="104" href="#104">104</a> assertFalse(hasShadowCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
-<a class="jxr_linenumber" name="105" href="#105">105</a> <span class="jxr_string">"Shadow cell shouldn't be there"</span>);
-<a class="jxr_linenumber" name="106" href="#106">106</a>
-<a class="jxr_linenumber" name="107" href="#107">107</a> tm.commit(t1);
-<a class="jxr_linenumber" name="108" href="#108">108</a>
-<a class="jxr_linenumber" name="109" href="#109">109</a> <em class="jxr_comment">// After commit test that both cell and shadow cell are there</em>
-<a class="jxr_linenumber" name="110" href="#110">110</a> assertTrue(hasCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
-<a class="jxr_linenumber" name="111" href="#111">111</a> <span class="jxr_string">"Cell should be there"</span>);
-<a class="jxr_linenumber" name="112" href="#112">112</a> assertTrue(hasShadowCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
-<a class="jxr_linenumber" name="113" href="#113">113</a> <span class="jxr_string">"Shadow cell should be there"</span>);
-<a class="jxr_linenumber" name="114" href="#114">114</a>
-<a class="jxr_linenumber" name="115" href="#115">115</a> <em class="jxr_comment">// Test that we can make a valid read after adding a shadow cell without hitting the commit table</em>
-<a class="jxr_linenumber" name="116" href="#116">116</a> CommitTable.Client commitTableClient = spy(getCommitTable(context).getClient());
-<a class="jxr_linenumber" name="117" href="#117">117</a>
-<a class="jxr_linenumber" name="118" href="#118">118</a> HBaseOmidClientConfiguration hbaseOmidClientConf = <strong class="jxr_keyword">new</strong> HBaseOmidClientConfiguration();
-<a class="jxr_linenumber" name="119" href="#119">119</a> hbaseOmidClientConf.setConnectionString(TSO_SERVER_HOST + <span class="jxr_string">":"</span> + TSO_SERVER_PORT);
-<a class="jxr_linenumber" name="120" href="#120">120</a> hbaseOmidClientConf.setHBaseConfiguration(hbaseConf);
-<a class="jxr_linenumber" name="121" href="#121">121</a> TransactionManager tm2 = HBaseTransactionManager.builder(hbaseOmidClientConf)
-<a class="jxr_linenumber" name="122" href="#122">122</a> .commitTableClient(commitTableClient)
-<a class="jxr_linenumber" name="123" href="#123">123</a> .build();
-<a class="jxr_linenumber" name="124" href="#124">124</a>
-<a class="jxr_linenumber" name="125" href="#125">125</a> Transaction t2 = tm2.begin();
-<a class="jxr_linenumber" name="126" href="#126">126</a> Get get = <strong class="jxr_keyword">new</strong> Get(row);
-<a class="jxr_linenumber" name="127" href="#127">127</a> get.addColumn(family, qualifier);
-<a class="jxr_linenumber" name="128" href="#128">128</a>
-<a class="jxr_linenumber" name="129" href="#129">129</a> Result getResult = table.get(t2, get);
-<a class="jxr_linenumber" name="130" href="#130">130</a> assertTrue(Arrays.equals(data1, getResult.getValue(family, qualifier)), <span class="jxr_string">"Values should be the same"</span>);
-<a class="jxr_linenumber" name="131" href="#131">131</a> verify(commitTableClient, never()).getCommitTimestamp(anyLong());
-<a class="jxr_linenumber" name="132" href="#132">132</a> }
-<a class="jxr_linenumber" name="133" href="#133">133</a>
-<a class="jxr_linenumber" name="134" href="#134">134</a> @Test(timeOut = 60_000)
-<a class="jxr_linenumber" name="135" href="#135">135</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testCrashingAfterCommitDoesNotWriteShadowCells(ITestContext context) <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="136" href="#136">136</a>
-<a class="jxr_linenumber" name="137" href="#137">137</a> CommitTable.Client commitTableClient = spy(getCommitTable(context).getClient());
-<a class="jxr_linenumber" name="138" href="#138">138</a>
-<a class="jxr_linenumber" name="139" href="#139">139</a> HBaseOmidClientConfiguration hbaseOmidClientConf = <strong class="jxr_keyword">new</strong> HBaseOmidClientConfiguration();
-<a class="jxr_linenumber" name="140" href="#140">140</a> hbaseOmidClientConf.setConnectionString(TSO_SERVER_HOST + <span class="jxr_string">":"</span> + TSO_SERVER_PORT);
-<a class="jxr_linenumber" name="141" href="#141">141</a> hbaseOmidClientConf.setHBaseConfiguration(hbaseConf);
-<a class="jxr_linenumber" name="142" href="#142">142</a> PostCommitActions syncPostCommitter = spy(
-<a class="jxr_linenumber" name="143" href="#143">143</a> <strong class="jxr_keyword">new</strong> HBaseSyncPostCommitter(<strong class="jxr_keyword">new</strong> NullMetricsProvider(), commitTableClient));
-<a class="jxr_linenumber" name="144" href="#144">144</a> AbstractTransactionManager tm = spy((AbstractTransactionManager) HBaseTransactionManager.builder(hbaseOmidClientConf)
-<a class="jxr_linenumber" name="145" href="#145">145</a> .postCommitter(syncPostCommitter)
-<a class="jxr_linenumber" name="146" href="#146">146</a> .commitTableClient(commitTableClient)
-<a class="jxr_linenumber" name="147" href="#147">147</a> .build());
-<a class="jxr_linenumber" name="148" href="#148">148</a>
-<a class="jxr_linenumber" name="149" href="#149">149</a> <em class="jxr_comment">// The following line emulates a crash after commit that is observed in (*) below</em>
-<a class="jxr_linenumber" name="150" href="#150">150</a> doThrow(<strong class="jxr_keyword">new</strong> RuntimeException()).when(syncPostCommitter).updateShadowCells(any(HBaseTransaction.<strong class="jxr_keyword">class</strong>));
-<a class="jxr_linenumber" name="151" href="#151">151</a>
-<a class="jxr_linenumber" name="152" href="#152">152</a> TTable table = <strong class="jxr_keyword">new</strong> TTable(hbaseConf, TEST_TABLE);
+<a class="jxr_linenumber" name="87" href="#87">87</a>
+<a class="jxr_linenumber" name="88" href="#88">88</a> @Test(timeOut = 60_000)
+<a class="jxr_linenumber" name="89" href="#89">89</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testShadowCellsBasics(ITestContext context) <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="90" href="#90">90</a>
+<a class="jxr_linenumber" name="91" href="#91">91</a> TransactionManager tm = newTransactionManager(context);
+<a class="jxr_linenumber" name="92" href="#92">92</a>
+<a class="jxr_linenumber" name="93" href="#93">93</a> TTable table = <strong class="jxr_keyword">new</strong> TTable(connection, TEST_TABLE);
+<a class="jxr_linenumber" name="94" href="#94">94</a>
+<a class="jxr_linenumber" name="95" href="#95">95</a> HBaseTransaction t1 = (HBaseTransaction) tm.begin();
+<a class="jxr_linenumber" name="96" href="#96">96</a>
+<a class="jxr_linenumber" name="97" href="#97">97</a> <em class="jxr_comment">// Test shadow cells are created properly</em>
+<a class="jxr_linenumber" name="98" href="#98">98</a> Put put = <strong class="jxr_keyword">new</strong> Put(row);
+<a class="jxr_linenumber" name="99" href="#99">99</a> put.addColumn(family, qualifier, data1);
+<a class="jxr_linenumber" name="100" href="#100">100</a> table.put(t1, put);
+<a class="jxr_linenumber" name="101" href="#101">101</a>
+<a class="jxr_linenumber" name="102" href="#102">102</a> <em class="jxr_comment">// Before commit test that only the cell is there</em>
+<a class="jxr_linenumber" name="103" href="#103">103</a> assertTrue(hasCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
+<a class="jxr_linenumber" name="104" href="#104">104</a> <span class="jxr_string">"Cell should be there"</span>);
+<a class="jxr_linenumber" name="105" href="#105">105</a> assertFalse(hasShadowCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
+<a class="jxr_linenumber" name="106" href="#106">106</a> <span class="jxr_string">"Shadow cell shouldn't be there"</span>);
+<a class="jxr_linenumber" name="107" href="#107">107</a>
+<a class="jxr_linenumber" name="108" href="#108">108</a> tm.commit(t1);
+<a class="jxr_linenumber" name="109" href="#109">109</a>
+<a class="jxr_linenumber" name="110" href="#110">110</a> <em class="jxr_comment">// After commit test that both cell and shadow cell are there</em>
+<a class="jxr_linenumber" name="111" href="#111">111</a> assertTrue(hasCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
+<a class="jxr_linenumber" name="112" href="#112">112</a> <span class="jxr_string">"Cell should be there"</span>);
+<a class="jxr_linenumber" name="113" href="#113">113</a> assertTrue(hasShadowCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
+<a class="jxr_linenumber" name="114" href="#114">114</a> <span class="jxr_string">"Shadow cell should be there"</span>);
+<a class="jxr_linenumber" name="115" href="#115">115</a>
+<a class="jxr_linenumber" name="116" href="#116">116</a> <em class="jxr_comment">// Test that we can make a valid read after adding a shadow cell without hitting the commit table</em>
+<a class="jxr_linenumber" name="117" href="#117">117</a> CommitTable.Client commitTableClient = spy(getCommitTable(context).getClient());
+<a class="jxr_linenumber" name="118" href="#118">118</a>
+<a class="jxr_linenumber" name="119" href="#119">119</a> HBaseOmidClientConfiguration hbaseOmidClientConf = <strong class="jxr_keyword">new</strong> HBaseOmidClientConfiguration();
+<a class="jxr_linenumber" name="120" href="#120">120</a> hbaseOmidClientConf.setConnectionString(TSO_SERVER_HOST + <span class="jxr_string">":"</span> + TSO_SERVER_PORT);
+<a class="jxr_linenumber" name="121" href="#121">121</a> hbaseOmidClientConf.setHBaseConfiguration(hbaseConf);
+<a class="jxr_linenumber" name="122" href="#122">122</a> TransactionManager tm2 = HBaseTransactionManager.builder(hbaseOmidClientConf)
+<a class="jxr_linenumber" name="123" href="#123">123</a> .commitTableClient(commitTableClient)
+<a class="jxr_linenumber" name="124" href="#124">124</a> .build();
+<a class="jxr_linenumber" name="125" href="#125">125</a>
+<a class="jxr_linenumber" name="126" href="#126">126</a> Transaction t2 = tm2.begin();
+<a class="jxr_linenumber" name="127" href="#127">127</a> Get get = <strong class="jxr_keyword">new</strong> Get(row);
+<a class="jxr_linenumber" name="128" href="#128">128</a> get.addColumn(family, qualifier);
+<a class="jxr_linenumber" name="129" href="#129">129</a>
+<a class="jxr_linenumber" name="130" href="#130">130</a> Result getResult = table.get(t2, get);
+<a class="jxr_linenumber" name="131" href="#131">131</a> assertTrue(Arrays.equals(data1, getResult.getValue(family, qualifier)), <span class="jxr_string">"Values should be the same"</span>);
+<a class="jxr_linenumber" name="132" href="#132">132</a> verify(commitTableClient, never()).getCommitTimestamp(anyLong());
+<a class="jxr_linenumber" name="133" href="#133">133</a> }
+<a class="jxr_linenumber" name="134" href="#134">134</a>
+<a class="jxr_linenumber" name="135" href="#135">135</a> @Test(timeOut = 60_000)
+<a class="jxr_linenumber" name="136" href="#136">136</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testCrashingAfterCommitDoesNotWriteShadowCells(ITestContext context) <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="137" href="#137">137</a>
+<a class="jxr_linenumber" name="138" href="#138">138</a> CommitTable.Client commitTableClient = spy(getCommitTable(context).getClient());
+<a class="jxr_linenumber" name="139" href="#139">139</a>
+<a class="jxr_linenumber" name="140" href="#140">140</a> HBaseOmidClientConfiguration hbaseOmidClientConf = <strong class="jxr_keyword">new</strong> HBaseOmidClientConfiguration();
+<a class="jxr_linenumber" name="141" href="#141">141</a> hbaseOmidClientConf.setConnectionString(TSO_SERVER_HOST + <span class="jxr_string">":"</span> + TSO_SERVER_PORT);
+<a class="jxr_linenumber" name="142" href="#142">142</a> hbaseOmidClientConf.setHBaseConfiguration(hbaseConf);
+<a class="jxr_linenumber" name="143" href="#143">143</a> PostCommitActions syncPostCommitter = spy(
+<a class="jxr_linenumber" name="144" href="#144">144</a> <strong class="jxr_keyword">new</strong> HBaseSyncPostCommitter(<strong class="jxr_keyword">new</strong> NullMetricsProvider(), commitTableClient));
+<a class="jxr_linenumber" name="145" href="#145">145</a> AbstractTransactionManager tm = spy((AbstractTransactionManager) HBaseTransactionManager.builder(hbaseOmidClientConf)
+<a class="jxr_linenumber" name="146" href="#146">146</a> .postCommitter(syncPostCommitter)
+<a class="jxr_linenumber" name="147" href="#147">147</a> .commitTableClient(commitTableClient)
+<a class="jxr_linenumber" name="148" href="#148">148</a> .commitTableWriter(getCommitTable(context).getWriter())
+<a class="jxr_linenumber" name="149" href="#149">149</a> .build());
+<a class="jxr_linenumber" name="150" href="#150">150</a>
+<a class="jxr_linenumber" name="151" href="#151">151</a> <em class="jxr_comment">// The following line emulates a crash after commit that is observed in (*) below</em>
+<a class="jxr_linenumber" name="152" href="#152">152</a> doThrow(<strong class="jxr_keyword">new</strong> RuntimeException()).when(syncPostCommitter).updateShadowCells(any(HBaseTransaction.<strong class="jxr_keyword">class</strong>));
<a class="jxr_linenumber" name="153" href="#153">153</a>
-<a class="jxr_linenumber" name="154" href="#154">154</a> HBaseTransaction t1 = (HBaseTransaction) tm.begin();
+<a class="jxr_linenumber" name="154" href="#154">154</a> TTable table = <strong class="jxr_keyword">new</strong> TTable(connection, TEST_TABLE);
<a class="jxr_linenumber" name="155" href="#155">155</a>
-<a class="jxr_linenumber" name="156" href="#156">156</a> <em class="jxr_comment">// Test shadow cell are created properly</em>
-<a class="jxr_linenumber" name="157" href="#157">157</a> Put put = <strong class="jxr_keyword">new</strong> Put(row);
-<a class="jxr_linenumber" name="158" href="#158">158</a> put.add(family, qualifier, data1);
-<a class="jxr_linenumber" name="159" href="#159">159</a> table.put(t1, put);
-<a class="jxr_linenumber" name="160" href="#160">160</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="161" href="#161">161</a> tm.commit(t1);
-<a class="jxr_linenumber" name="162" href="#162">162</a> } <strong class="jxr_keyword">catch</strong> (Exception e) { <em class="jxr_comment">// (*) crash</em>
-<a class="jxr_linenumber" name="163" href="#163">163</a> <em class="jxr_comment">// Do nothing</em>
-<a class="jxr_linenumber" name="164" href="#164">164</a> }
-<a class="jxr_linenumber" name="165" href="#165">165</a>
-<a class="jxr_linenumber" name="166" href="#166">166</a> <em class="jxr_comment">// After commit with the emulated crash, test that only the cell is there</em>
-<a class="jxr_linenumber" name="167" href="#167">167</a> assertTrue(hasCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
-<a class="jxr_linenumber" name="168" href="#168">168</a> <span class="jxr_string">"Cell should be there"</span>);
-<a class="jxr_linenumber" name="169" href="#169">169</a> assertFalse(hasShadowCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
-<a class="jxr_linenumber" name="170" href="#170">170</a> <span class="jxr_string">"Shadow cell should not be there"</span>);
-<a class="jxr_linenumber" name="171" href="#171">171</a>
-<a class="jxr_linenumber" name="172" href="#172">172</a> Transaction t2 = tm.begin();
-<a class="jxr_linenumber" name="173" href="#173">173</a> Get get = <strong class="jxr_keyword">new</strong> Get(row);
-<a class="jxr_linenumber" name="174" href="#174">174</a> get.addColumn(family, qualifier);
-<a class="jxr_linenumber" name="175" href="#175">175</a>
-<a class="jxr_linenumber" name="176" href="#176">176</a> Result getResult = table.get(t2, get);
-<a class="jxr_linenumber" name="177" href="#177">177</a> assertTrue(Arrays.equals(data1, getResult.getValue(family, qualifier)), <span class="jxr_string">"Shadow cell should not be there"</span>);
-<a class="jxr_linenumber" name="178" href="#178">178</a> verify(commitTableClient, times(1)).getCommitTimestamp(anyLong());
-<a class="jxr_linenumber" name="179" href="#179">179</a> }
-<a class="jxr_linenumber" name="180" href="#180">180</a>
-<a class="jxr_linenumber" name="181" href="#181">181</a> @Test(timeOut = 60_000)
-<a class="jxr_linenumber" name="182" href="#182">182</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testShadowCellIsHealedAfterCommitCrash(ITestContext context) <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="183" href="#183">183</a>
-<a class="jxr_linenumber" name="184" href="#184">184</a> CommitTable.Client commitTableClient = spy(getCommitTable(context).getClient());
+<a class="jxr_linenumber" name="156" href="#156">156</a> HBaseTransaction t1 = (HBaseTransaction) tm.begin();
+<a class="jxr_linenumber" name="157" href="#157">157</a>
+<a class="jxr_linenumber" name="158" href="#158">158</a> <em class="jxr_comment">// Test shadow cell are created properly</em>
+<a class="jxr_linenumber" name="159" href="#159">159</a> Put put = <strong class="jxr_keyword">new</strong> Put(row);
+<a class="jxr_linenumber" name="160" href="#160">160</a> put.addColumn(family, qualifier, data1);
+<a class="jxr_linenumber" name="161" href="#161">161</a> table.put(t1, put);
+<a class="jxr_linenumber" name="162" href="#162">162</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="163" href="#163">163</a> tm.commit(t1);
+<a class="jxr_linenumber" name="164" href="#164">164</a> } <strong class="jxr_keyword">catch</strong> (Exception e) { <em class="jxr_comment">// (*) crash</em>
+<a class="jxr_linenumber" name="165" href="#165">165</a> <em class="jxr_comment">// Do nothing</em>
+<a class="jxr_linenumber" name="166" href="#166">166</a> }
+<a class="jxr_linenumber" name="167" href="#167">167</a>
+<a class="jxr_linenumber" name="168" href="#168">168</a> <em class="jxr_comment">// After commit with the emulated crash, test that only the cell is there</em>
+<a class="jxr_linenumber" name="169" href="#169">169</a> assertTrue(hasCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
+<a class="jxr_linenumber" name="170" href="#170">170</a> <span class="jxr_string">"Cell should be there"</span>);
+<a class="jxr_linenumber" name="171" href="#171">171</a> assertFalse(hasShadowCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
+<a class="jxr_linenumber" name="172" href="#172">172</a> <span class="jxr_string">"Shadow cell should not be there"</span>);
+<a class="jxr_linenumber" name="173" href="#173">173</a>
+<a class="jxr_linenumber" name="174" href="#174">174</a> Transaction t2 = tm.begin();
+<a class="jxr_linenumber" name="175" href="#175">175</a> Get get = <strong class="jxr_keyword">new</strong> Get(row);
+<a class="jxr_linenumber" name="176" href="#176">176</a> get.addColumn(family, qualifier);
+<a class="jxr_linenumber" name="177" href="#177">177</a>
+<a class="jxr_linenumber" name="178" href="#178">178</a> Result getResult = table.get(t2, get);
+<a class="jxr_linenumber" name="179" href="#179">179</a> assertTrue(Arrays.equals(data1, getResult.getValue(family, qualifier)), <span class="jxr_string">"Shadow cell should not be there"</span>);
+<a class="jxr_linenumber" name="180" href="#180">180</a> verify(commitTableClient, times(1)).getCommitTimestamp(anyLong());
+<a class="jxr_linenumber" name="181" href="#181">181</a> }
+<a class="jxr_linenumber" name="182" href="#182">182</a>
+<a class="jxr_linenumber" name="183" href="#183">183</a> @Test(timeOut = 60_000)
+<a class="jxr_linenumber" name="184" href="#184">184</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testShadowCellIsHealedAfterCommitCrash(ITestContext context) <strong class="jxr_keyword">throws</strong> Exception {
<a class="jxr_linenumber" name="185" href="#185">185</a>
-<a class="jxr_linenumber" name="186" href="#186">186</a> HBaseOmidClientConfiguration hbaseOmidClientConf = <strong class="jxr_keyword">new</strong> HBaseOmidClientConfiguration();
-<a class="jxr_linenumber" name="187" href="#187">187</a> hbaseOmidClientConf.setConnectionString(TSO_SERVER_HOST + <span class="jxr_string">":"</span> + TSO_SERVER_PORT);
-<a class="jxr_linenumber" name="188" href="#188">188</a> hbaseOmidClientConf.setHBaseConfiguration(hbaseConf);
-<a class="jxr_linenumber" name="189" href="#189">189</a> PostCommitActions syncPostCommitter = spy(
-<a class="jxr_linenumber" name="190" href="#190">190</a> <strong class="jxr_keyword">new</strong> HBaseSyncPostCommitter(<strong class="jxr_keyword">new</strong> NullMetricsProvider(), commitTableClient));
-<a class="jxr_linenumber" name="191" href="#191">191</a> AbstractTransactionManager tm = spy((AbstractTransactionManager) HBaseTransactionManager.builder(hbaseOmidClientConf)
-<a class="jxr_linenumber" name="192" href="#192">192</a> .postCommitter(syncPostCommitter)
-<a class="jxr_linenumber" name="193" href="#193">193</a> .commitTableClient(commitTableClient)
-<a class="jxr_linenumber" name="194" href="#194">194</a> .build());
-<a class="jxr_linenumber" name="195" href="#195">195</a>
-<a class="jxr_linenumber" name="196" href="#196">196</a> <em class="jxr_comment">// The following line emulates a crash after commit that is observed in (*) below</em>
-<a class="jxr_linenumber" name="197" href="#197">197</a> doThrow(<strong class="jxr_keyword">new</strong> RuntimeException()).when(syncPostCommitter).updateShadowCells(any(HBaseTransaction.<strong class="jxr_keyword">class</strong>));
+<a class="jxr_linenumber" name="186" href="#186">186</a> CommitTable.Client commitTableClient = spy(getCommitTable(context).getClient());
+<a class="jxr_linenumber" name="187" href="#187">187</a>
+<a class="jxr_linenumber" name="188" href="#188">188</a> HBaseOmidClientConfiguration hbaseOmidClientConf = <strong class="jxr_keyword">new</strong> HBaseOmidClientConfiguration();
+<a class="jxr_linenumber" name="189" href="#189">189</a> hbaseOmidClientConf.setConnectionString(TSO_SERVER_HOST + <span class="jxr_string">":"</span> + TSO_SERVER_PORT);
+<a class="jxr_linenumber" name="190" href="#190">190</a> hbaseOmidClientConf.setHBaseConfiguration(hbaseConf);
+<a class="jxr_linenumber" name="191" href="#191">191</a> PostCommitActions syncPostCommitter = spy(
+<a class="jxr_linenumber" name="192" href="#192">192</a> <strong class="jxr_keyword">new</strong> HBaseSyncPostCommitter(<strong class="jxr_keyword">new</strong> NullMetricsProvider(), commitTableClient));
+<a class="jxr_linenumber" name="193" href="#193">193</a> AbstractTransactionManager tm = spy((AbstractTransactionManager) HBaseTransactionManager.builder(hbaseOmidClientConf)
+<a class="jxr_linenumber" name="194" href="#194">194</a> .postCommitter(syncPostCommitter)
+<a class="jxr_linenumber" name="195" href="#195">195</a> .commitTableWriter(getCommitTable(context).getWriter())
+<a class="jxr_linenumber" name="196" href="#196">196</a> .commitTableClient(commitTableClient)
+<a class="jxr_linenumber" name="197" href="#197">197</a> .build());
<a class="jxr_linenumber" name="198" href="#198">198</a>
-<a class="jxr_linenumber" name="199" href="#199">199</a> TTable table = <strong class="jxr_keyword">new</strong> TTable(hbaseConf, TEST_TABLE);
-<a class="jxr_linenumber" name="200" href="#200">200</a>
-<a class="jxr_linenumber" name="201" href="#201">201</a> HBaseTransaction t1 = (HBaseTransaction) tm.begin();
-<a class="jxr_linenumber" name="202" href="#202">202</a>
-<a class="jxr_linenumber" name="203" href="#203">203</a> <em class="jxr_comment">// Test shadow cell are created properly</em>
-<a class="jxr_linenumber" name="204" href="#204">204</a> Put put = <strong class="jxr_keyword">new</strong> Put(row);
-<a class="jxr_linenumber" name="205" href="#205">205</a> put.add(family, qualifier, data1);
-<a class="jxr_linenumber" name="206" href="#206">206</a> table.put(t1, put);
-<a class="jxr_linenumber" name="207" href="#207">207</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="208" href="#208">208</a> tm.commit(t1);
-<a class="jxr_linenumber" name="209" href="#209">209</a> } <strong class="jxr_keyword">catch</strong> (Exception e) { <em class="jxr_comment">// (*) Crash</em>
-<a class="jxr_linenumber" name="210" href="#210">210</a> <em class="jxr_comment">// Do nothing</em>
-<a class="jxr_linenumber" name="211" href="#211">211</a> }
-<a class="jxr_linenumber" name="212" href="#212">212</a>
-<a class="jxr_linenumber" name="213" href="#213">213</a> assertTrue(hasCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
-<a class="jxr_linenumber" name="214" href="#214">214</a> <span class="jxr_string">"Cell should be there"</span>);
-<a class="jxr_linenumber" name="215" href="#215">215</a> assertFalse(hasShadowCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
-<a class="jxr_linenumber" name="216" href="#216">216</a> <span class="jxr_string">"Shadow cell should not be there"</span>);
-<a class="jxr_linenumber" name="217" href="#217">217</a>
-<a class="jxr_linenumber" name="218" href="#218">218</a> Transaction t2 = tm.begin();
-<a class="jxr_linenumber" name="219" href="#219">219</a> Get get = <strong class="jxr_keyword">new</strong> Get(row);
-<a class="jxr_linenumber" name="220" href="#220">220</a> get.addColumn(family, qualifier);
-<a class="jxr_linenumber" name="221" href="#221">221</a>
-<a class="jxr_linenumber" name="222" href="#222">222</a> <em class="jxr_comment">// This get should heal the shadow cell</em>
-<a class="jxr_linenumber" name="223" href="#223">223</a> Result getResult = table.get(t2, get);
-<a class="jxr_linenumber" name="224" href="#224">224</a> assertTrue(Arrays.equals(data1, getResult.getValue(family, qualifier)), <span class="jxr_string">"Values should be the same"</span>);
-<a class="jxr_linenumber" name="225" href="#225">225</a> verify(commitTableClient, times(1)).getCommitTimestamp(anyLong());
-<a class="jxr_linenumber" name="226" href="#226">226</a>
-<a class="jxr_linenumber" name="227" href="#227">227</a> assertTrue(hasCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
-<a class="jxr_linenumber" name="228" href="#228">228</a> <span class="jxr_string">"Cell should be there"</span>);
-<a class="jxr_linenumber" name="229" href="#229">229</a> assertTrue(hasShadowCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
-<a class="jxr_linenumber" name="230" href="#230">230</a> <span class="jxr_string">"Shadow cell should be there after being healed"</span>);
-<a class="jxr_linenumber" name="231" href="#231">231</a>
-<a class="jxr_linenumber" name="232" href="#232">232</a> <em class="jxr_comment">// As the shadow cell is healed, this get shouldn't have to hit the storage,</em>
-<a class="jxr_linenumber" name="233" href="#233">233</a> <em class="jxr_comment">// so the number of invocations to commitTableClient.getCommitTimestamp()</em>
-<a class="jxr_linenumber" name="234" href="#234">234</a> <em class="jxr_comment">// should remain the same</em>
-<a class="jxr_linenumber" name="235" href="#235">235</a> getResult = table.get(t2, get);
-<a class="jxr_linenumber" name="236" href="#236">236</a> assertTrue(Arrays.equals(data1, getResult.getValue(family, qualifier)), <span class="jxr_string">"Values should be the same"</span>);
-<a class="jxr_linenumber" name="237" href="#237">237</a> verify(commitTableClient, times(1)).getCommitTimestamp(anyLong());
-<a class="jxr_linenumber" name="238" href="#238">238</a> }
-<a class="jxr_linenumber" name="239" href="#239">239</a>
-<a class="jxr_linenumber" name="240" href="#240">240</a> @Test(timeOut = 60_000)
-<a class="jxr_linenumber" name="241" href="#241">241</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testTransactionNeverCompletesWhenAnExceptionIsThrownUpdatingShadowCells(ITestContext context)
-<a class="jxr_linenumber" name="242" href="#242">242</a> <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="243" href="#243">243</a>
-<a class="jxr_linenumber" name="244" href="#244">244</a> CommitTable.Client commitTableClient = spy(getCommitTable(context).getClient());
-<a class="jxr_linenumber" name="245" href="#245">245</a>
-<a class="jxr_linenumber" name="246" href="#246">246</a> HBaseOmidClientConfiguration hbaseOmidClientConf = <strong class="jxr_keyword">new</strong> HBaseOmidClientConfiguration();
-<a class="jxr_linenumber" name="247" href="#247">247</a> hbaseOmidClientConf.setConnectionString(TSO_SERVER_HOST + <span class="jxr_string">":"</span> + TSO_SERVER_PORT);
-<a class="jxr_linenumber" name="248" href="#248">248</a> hbaseOmidClientConf.setHBaseConfiguration(hbaseConf);
-<a class="jxr_linenumber" name="249" href="#249">249</a> PostCommitActions syncPostCommitter = spy(
-<a class="jxr_linenumber" name="250" href="#250">250</a> <strong class="jxr_keyword">new</strong> HBaseSyncPostCommitter(<strong class="jxr_keyword">new</strong> NullMetricsProvider(), commitTableClient));
-<a class="jxr_linenumber" name="251" href="#251">251</a> AbstractTransactionManager tm = spy((AbstractTransactionManager) HBaseTransactionManager.builder(hbaseOmidClientConf)
-<a class="jxr_linenumber" name="252" href="#252">252</a> .postCommitter(syncPostCommitter)
-<a class="jxr_linenumber" name="253" href="#253">253</a> .commitTableClient(commitTableClient)
-<a class="jxr_linenumber" name="254" href="#254">254</a> .build());
-<a class="jxr_linenumber" name="255" href="#255">255</a>
-<a class="jxr_linenumber" name="256" href="#256">256</a> <strong class="jxr_keyword">final</strong> TTable table = <strong class="jxr_keyword">new</strong> TTable(hbaseConf, TEST_TABLE);
-<a class="jxr_linenumber" name="257" href="#257">257</a>
-<a class="jxr_linenumber" name="258" href="#258">258</a> HBaseTransaction tx = (HBaseTransaction) tm.begin();
+<a class="jxr_linenumber" name="199" href="#199">199</a> <em class="jxr_comment">// The following line emulates a crash after commit that is observed in (*) below</em>
+<a class="jxr_linenumber" name="200" href="#200">200</a> doThrow(<strong class="jxr_keyword">new</strong> RuntimeException()).when(syncPostCommitter).updateShadowCells(any(HBaseTransaction.<strong class="jxr_keyword">class</strong>));
+<a class="jxr_linenumber" name="201" href="#201">201</a>
+<a class="jxr_linenumber" name="202" href="#202">202</a> TTable table = <strong class="jxr_keyword">new</strong> TTable(connection, TEST_TABLE);
+<a class="jxr_linenumber" name="203" href="#203">203</a>
+<a class="jxr_linenumber" name="204" href="#204">204</a> HBaseTransaction t1 = (HBaseTransaction) tm.begin();
+<a class="jxr_linenumber" name="205" href="#205">205</a>
+<a class="jxr_linenumber" name="206" href="#206">206</a> <em class="jxr_comment">// Test shadow cell are created properly</em>
+<a class="jxr_linenumber" name="207" href="#207">207</a> Put put = <strong class="jxr_keyword">new</strong> Put(row);
+<a class="jxr_linenumber" name="208" href="#208">208</a> put.addColumn(family, qualifier, data1);
+<a class="jxr_linenumber" name="209" href="#209">209</a> table.put(t1, put);
+<a class="jxr_linenumber" name="210" href="#210">210</a> <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="211" href="#211">211</a> tm.commit(t1);
+<a class="jxr_linenumber" name="212" href="#212">212</a> } <strong class="jxr_keyword">catch</strong> (Exception e) { <em class="jxr_comment">// (*) Crash</em>
+<a class="jxr_linenumber" name="213" href="#213">213</a> <em class="jxr_comment">// Do nothing</em>
+<a class="jxr_linenumber" name="214" href="#214">214</a> }
+<a class="jxr_linenumber" name="215" href="#215">215</a>
+<a class="jxr_linenumber" name="216" href="#216">216</a> assertTrue(hasCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
+<a class="jxr_linenumber" name="217" href="#217">217</a> <span class="jxr_string">"Cell should be there"</span>);
+<a class="jxr_linenumber" name="218" href="#218">218</a> assertFalse(hasShadowCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
+<a class="jxr_linenumber" name="219" href="#219">219</a> <span class="jxr_string">"Shadow cell should not be there"</span>);
+<a class="jxr_linenumber" name="220" href="#220">220</a>
+<a class="jxr_linenumber" name="221" href="#221">221</a> Transaction t2 = tm.begin();
+<a class="jxr_linenumber" name="222" href="#222">222</a> Get get = <strong class="jxr_keyword">new</strong> Get(row);
+<a class="jxr_linenumber" name="223" href="#223">223</a> get.addColumn(family, qualifier);
+<a class="jxr_linenumber" name="224" href="#224">224</a>
+<a class="jxr_linenumber" name="225" href="#225">225</a> <em class="jxr_comment">// This get should heal the shadow cell</em>
+<a class="jxr_linenumber" name="226" href="#226">226</a> Result getResult = table.get(t2, get);
+<a class="jxr_linenumber" name="227" href="#227">227</a> assertTrue(Arrays.equals(data1, getResult.getValue(family, qualifier)), <span class="jxr_string">"Values should be the same"</span>);
+<a class="jxr_linenumber" name="228" href="#228">228</a> verify(commitTableClient, times(1)).getCommitTimestamp(anyLong());
+<a class="jxr_linenumber" name="229" href="#229">229</a>
+<a class="jxr_linenumber" name="230" href="#230">230</a> assertTrue(hasCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
+<a class="jxr_linenumber" name="231" href="#231">231</a> <span class="jxr_string">"Cell should be there"</span>);
+<a class="jxr_linenumber" name="232" href="#232">232</a> assertTrue(hasShadowCell(row, family, qualifier, t1.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
+<a class="jxr_linenumber" name="233" href="#233">233</a> <span class="jxr_string">"Shadow cell should be there after being healed"</span>);
+<a class="jxr_linenumber" name="234" href="#234">234</a>
+<a class="jxr_linenumber" name="235" href="#235">235</a> <em class="jxr_comment">// As the shadow cell is healed, this get shouldn't have to hit the storage,</em>
+<a class="jxr_linenumber" name="236" href="#236">236</a> <em class="jxr_comment">// so the number of invocations to commitTableClient.getCommitTimestamp()</em>
+<a class="jxr_linenumber" name="237" href="#237">237</a> <em class="jxr_comment">// should remain the same</em>
+<a class="jxr_linenumber" name="238" href="#238">238</a> getResult = table.get(t2, get);
+<a class="jxr_linenumber" name="239" href="#239">239</a> assertTrue(Arrays.equals(data1, getResult.getValue(family, qualifier)), <span class="jxr_string">"Values should be the same"</span>);
+<a class="jxr_linenumber" name="240" href="#240">240</a> verify(commitTableClient, times(1)).getCommitTimestamp(anyLong());
+<a class="jxr_linenumber" name="241" href="#241">241</a> }
+<a class="jxr_linenumber" name="242" href="#242">242</a>
+<a class="jxr_linenumber" name="243" href="#243">243</a> @Test(timeOut = 60_000)
+<a class="jxr_linenumber" name="244" href="#244">244</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testTransactionNeverCompletesWhenAnExceptionIsThrownUpdatingShadowCells(ITestContext context)
+<a class="jxr_linenumber" name="245" href="#245">245</a> <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="246" href="#246">246</a>
+<a class="jxr_linenumber" name="247" href="#247">247</a> CommitTable.Client commitTableClient = spy(getCommitTable(context).getClient());
+<a class="jxr_linenumber" name="248" href="#248">248</a>
+<a class="jxr_linenumber" name="249" href="#249">249</a> HBaseOmidClientConfiguration hbaseOmidClientConf = <strong class="jxr_keyword">new</strong> HBaseOmidClientConfiguration();
+<a class="jxr_linenumber" name="250" href="#250">250</a> hbaseOmidClientConf.setConnectionString(TSO_SERVER_HOST + <span class="jxr_string">":"</span> + TSO_SERVER_PORT);
+<a class="jxr_linenumber" name="251" href="#251">251</a> hbaseOmidClientConf.setHBaseConfiguration(hbaseConf);
+<a class="jxr_linenumber" name="252" href="#252">252</a> PostCommitActions syncPostCommitter = spy(
+<a class="jxr_linenumber" name="253" href="#253">253</a> <strong class="jxr_keyword">new</strong> HBaseSyncPostCommitter(<strong class="jxr_keyword">new</strong> NullMetricsProvider(), commitTableClient));
+<a class="jxr_linenumber" name="254" href="#254">254</a> AbstractTransactionManager tm = spy((AbstractTransactionManager) HBaseTransactionManager.builder(hbaseOmidClientConf)
+<a class="jxr_linenumber" name="255" href="#255">255</a> .postCommitter(syncPostCommitter)
+<a class="jxr_linenumber" name="256" href="#256">256</a> .commitTableClient(commitTableClient)
+<a class="jxr_linenumber" name="257" href="#257">257</a> .commitTableWriter(getCommitTable(context).getWriter())
+<a class="jxr_linenumber" name="258" href="#258">258</a> .build());
<a class="jxr_linenumber" name="259" href="#259">259</a>
-<a class="jxr_linenumber" name="260" href="#260">260</a> Put put = <strong class="jxr_keyword">new</strong> Put(row);
-<a class="jxr_linenumber" name="261" href="#261">261</a> put.add(family, qualifier, data1);
-<a class="jxr_linenumber" name="262" href="#262">262</a> table.put(tx, put);
+<a class="jxr_linenumber" name="260" href="#260">260</a> <strong class="jxr_keyword">final</strong> TTable table = <strong class="jxr_keyword">new</strong> TTable(connection, TEST_TABLE);
+<a class="jxr_linenumber" name="261" href="#261">261</a>
+<a class="jxr_linenumber" name="262" href="#262">262</a> HBaseTransaction tx = (HBaseTransaction) tm.begin();
<a class="jxr_linenumber" name="263" href="#263">263</a>
-<a class="jxr_linenumber" name="264" href="#264">264</a> <em class="jxr_comment">// This line emulates an error accessing the target table by disabling it</em>
-<a class="jxr_linenumber" name="265" href="#265">265</a> doAnswer(<strong class="jxr_keyword">new</strong> Answer<ListenableFuture<Void>>() {
-<a class="jxr_linenumber" name="266" href="#266">266</a> @Override
-<a class="jxr_linenumber" name="267" href="#267">267</a> <strong class="jxr_keyword">public</strong> ListenableFuture<Void> answer(InvocationOnMock invocation) <strong class="jxr_keyword">throws</strong> Throwable {
-<a class="jxr_linenumber" name="268" href="#268">268</a> table.flushCommits();
-<a class="jxr_linenumber" name="269" href="#269">269</a> HBaseAdmin admin = hBaseUtils.getHBaseAdmin();
-<a class="jxr_linenumber" name="270" href="#270">270</a> admin.disableTable(table.getTableName());
-<a class="jxr_linenumber" name="271" href="#271">271</a> <strong class="jxr_keyword">return</strong> (ListenableFuture<Void>) invocation.callRealMethod();
-<a class="jxr_linenumber" name="272" href="#272">272</a> }
-<a class="jxr_linenumber" name="273" href="#273">273</a> }).when(syncPostCommitter).updateShadowCells(any(HBaseTransaction.<strong class="jxr_keyword">class</strong>));
-<a class="jxr_linenumber" name="274" href="#274">274</a>
-<a class="jxr_linenumber" name="275" href="#275">275</a> <em class="jxr_comment">// When committing, an IOException should be thrown in syncPostCommitter.updateShadowCells() and placed in the</em>
-<a class="jxr_linenumber" name="276" href="#276">276</a> <em class="jxr_comment">// future as a TransactionManagerException. However, the exception is never retrieved in the</em>
-<a class="jxr_linenumber" name="277" href="#277">277</a> <em class="jxr_comment">// AbstractTransactionManager as the future is never checked.</em>
-<a class="jxr_linenumber" name="278" href="#278">278</a> <em class="jxr_comment">// This requires to set the HConstants.HBASE_CLIENT_RETRIES_NUMBER in the HBase config to a finite number:</em>
-<a class="jxr_linenumber" name="279" href="#279">279</a> <em class="jxr_comment">// e.g -> hbaseConf.setInt(HBASE_CLIENT_RETRIES_NUMBER, 3); Otherwise it will get stuck in tm.commit();</em>
-<a class="jxr_linenumber" name="280" href="#280">280</a>
-<a class="jxr_linenumber" name="281" href="#281">281</a> tm.commit(tx); <em class="jxr_comment">// Tx effectively commits but the post Commit Actions failed when updating the shadow cells</em>
-<a class="jxr_linenumber" name="282" href="#282">282</a>
-<a class="jxr_linenumber" name="283" href="#283">283</a> <em class="jxr_comment">// Re-enable table to allow the required checks below</em>
-<a class="jxr_linenumber" name="284" href="#284">284</a> HBaseAdmin admin = hBaseUtils.getHBaseAdmin();
-<a class="jxr_linenumber" name="285" href="#285">285</a> admin.enableTable(table.getTableName());
+<a class="jxr_linenumber" name="264" href="#264">264</a> Put put = <strong class="jxr_keyword">new</strong> Put(row);
+<a class="jxr_linenumber" name="265" href="#265">265</a> put.addColumn(family, qualifier, data1);
+<a class="jxr_linenumber" name="266" href="#266">266</a> table.put(tx, put);
+<a class="jxr_linenumber" name="267" href="#267">267</a>
+<a class="jxr_linenumber" name="268" href="#268">268</a> <em class="jxr_comment">// This line emulates an error accessing the target table by disabling it</em>
+<a class="jxr_linenumber" name="269" href="#269">269</a> doAnswer(<strong class="jxr_keyword">new</strong> Answer<ListenableFuture<Void>>() {
+<a class="jxr_linenumber" name="270" href="#270">270</a> @Override
+<a class="jxr_linenumber" name="271" href="#271">271</a> <strong class="jxr_keyword">public</strong> ListenableFuture<Void> answer(InvocationOnMock invocation) <strong class="jxr_keyword">throws</strong> Throwable {
+<a class="jxr_linenumber" name="272" href="#272">272</a> table.flushCommits();
+<a class="jxr_linenumber" name="273" href="#273">273</a> HBaseAdmin admin = hBaseUtils.getHBaseAdmin();
+<a class="jxr_linenumber" name="274" href="#274">274</a> admin.disableTable(TableName.valueOf(table.getTableName()));
+<a class="jxr_linenumber" name="275" href="#275">275</a> <strong class="jxr_keyword">return</strong> (ListenableFuture<Void>) invocation.callRealMethod();
+<a class="jxr_linenumber" name="276" href="#276">276</a> }
+<a class="jxr_linenumber" name="277" href="#277">277</a> }).when(syncPostCommitter).updateShadowCells(any(HBaseTransaction.<strong class="jxr_keyword">class</strong>));
+<a class="jxr_linenumber" name="278" href="#278">278</a>
+<a class="jxr_linenumber" name="279" href="#279">279</a> <em class="jxr_comment">// When committing, an IOException should be thrown in syncPostCommitter.updateShadowCells() and placed in the</em>
+<a class="jxr_linenumber" name="280" href="#280">280</a> <em class="jxr_comment">// future as a TransactionManagerException. However, the exception is never retrieved in the</em>
+<a class="jxr_linenumber" name="281" href="#281">281</a> <em class="jxr_comment">// AbstractTransactionManager as the future is never checked.</em>
+<a class="jxr_linenumber" name="282" href="#282">282</a> <em class="jxr_comment">// This requires to set the HConstants.HBASE_CLIENT_RETRIES_NUMBER in the HBase config to a finite number:</em>
+<a class="jxr_linenumber" name="283" href="#283">283</a> <em class="jxr_comment">// e.g -> hbaseConf.setInt(HBASE_CLIENT_RETRIES_NUMBER, 3); Otherwise it will get stuck in tm.commit();</em>
+<a class="jxr_linenumber" name="284" href="#284">284</a>
+<a class="jxr_linenumber" name="285" href="#285">285</a> tm.commit(tx); <em class="jxr_comment">// Tx effectively commits but the post Commit Actions failed when updating the shadow cells</em>
<a class="jxr_linenumber" name="286" href="#286">286</a>
-<a class="jxr_linenumber" name="287" href="#287">287</a> <em class="jxr_comment">// 1) check that shadow cell is not created...</em>
-<a class="jxr_linenumber" name="288" href="#288">288</a> assertTrue(hasCell(row, family, qualifier, tx.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
-<a class="jxr_linenumber" name="289" href="#289">289</a> <span class="jxr_string">"Cell should be there"</span>);
-<a class="jxr_linenumber" name="290" href="#290">290</a> assertFalse(hasShadowCell(row, family, qualifier, tx.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
-<a class="jxr_linenumber" name="291" href="#291">291</a> <span class="jxr_string">"Shadow cell should not be there"</span>);
-<a class="jxr_linenumber" name="292" href="#292">292</a> <em class="jxr_comment">// 2) and thus, completeTransaction() was never called on the commit table...</em>
-<a class="jxr_linenumber" name="293" href="#293">293</a> verify(commitTableClient, times(0)).completeTransaction(anyLong());
-<a class="jxr_linenumber" name="294" href="#294">294</a> <em class="jxr_comment">// 3) ...and commit value still in commit table</em>
-<a class="jxr_linenumber" name="295" href="#295">295</a> assertTrue(commitTableClient.getCommitTimestamp(tx.getStartTimestamp()).get().isPresent());
-<a class="jxr_linenumber" name="296" href="#296">296</a>
-<a class="jxr_linenumber" name="297" href="#297">297</a> }
-<a class="jxr_linenumber" name="298" href="#298">298</a>
-<a class="jxr_linenumber" name="299" href="#299">299</a> @Test(timeOut = 60_000)
-<a class="jxr_linenumber" name="300" href="#300">300</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testRaceConditionBetweenReaderAndWriterThreads(<strong class="jxr_keyword">final</strong> ITestContext context) <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="301" href="#301">301</a> <strong class="jxr_keyword">final</strong> CountDownLatch readAfterCommit = <strong class="jxr_keyword">new</strong> CountDownLatch(1);
-<a class="jxr_linenumber" name="302" href="#302">302</a> <strong class="jxr_keyword">final</strong> CountDownLatch postCommitBegin = <strong class="jxr_keyword">new</strong> CountDownLatch(1);
-<a class="jxr_linenumber" name="303" href="#303">303</a> <strong class="jxr_keyword">final</strong> CountDownLatch postCommitEnd = <strong class="jxr_keyword">new</strong> CountDownLatch(1);
-<a class="jxr_linenumber" name="304" href="#304">304</a>
-<a class="jxr_linenumber" name="305" href="#305">305</a> <strong class="jxr_keyword">final</strong> AtomicBoolean readFailed = <strong class="jxr_keyword">new</strong> AtomicBoolean(false);
-<a class="jxr_linenumber" name="306" href="#306">306</a> PostCommitActions syncPostCommitter =
-<a class="jxr_linenumber" name="307" href="#307">307</a> spy(<strong class="jxr_keyword">new</strong> HBaseSyncPostCommitter(<strong class="jxr_keyword">new</strong> NullMetricsProvider(), getCommitTable(context).getClient()));
-<a class="jxr_linenumber" name="308" href="#308">308</a> AbstractTransactionManager tm = (AbstractTransactionManager) newTransactionManager(context, syncPostCommitter);
-<a class="jxr_linenumber" name="309" href="#309">309</a>
-<a class="jxr_linenumber" name="310" href="#310">310</a> doAnswer(<strong class="jxr_keyword">new</strong> Answer<ListenableFuture<Void>>() {
-<a class="jxr_linenumber" name="311" href="#311">311</a> @Override
-<a class="jxr_linenumber" name="312" href="#312">312</a> <strong class="jxr_keyword">public</strong> ListenableFuture<Void> answer(InvocationOnMock invocation) <strong class="jxr_keyword">throws</strong> Throwable {
-<a class="jxr_linenumber" name="313" href="#313">313</a> LOG.info(<span class="jxr_string">"Releasing readAfterCommit barrier"</span>);
-<a class="jxr_linenumber" name="314" href="#314">314</a> readAfterCommit.countDown();
-<a class="jxr_linenumber" name="315" href="#315">315</a> LOG.info(<span class="jxr_string">"Waiting postCommitBegin barrier"</span>);
-<a class="jxr_linenumber" name="316" href="#316">316</a> postCommitBegin.await();
-<a class="jxr_linenumber" name="317" href="#317">317</a> ListenableFuture<Void> result = (ListenableFuture<Void>) invocation.callRealMethod();
-<a class="jxr_linenumber" name="318" href="#318">318</a> LOG.info(<span class="jxr_string">"Releasing postCommitEnd barrier"</span>);
-<a class="jxr_linenumber" name="319" href="#319">319</a> postCommitEnd.countDown();
-<a class="jxr_linenumber" name="320" href="#320">320</a> <strong class="jxr_keyword">return</strong> result;
-<a class="jxr_linenumber" name="321" href="#321">321</a> }
-<a class="jxr_linenumber" name="322" href="#322">322</a> }).when(syncPostCommitter).updateShadowCells(any(HBaseTransaction.<strong class="jxr_keyword">class</strong>));
-<a class="jxr_linenumber" name="323" href="#323">323</a>
-<a class="jxr_linenumber" name="324" href="#324">324</a> <em class="jxr_comment">// Start transaction on write thread</em>
-<a class="jxr_linenumber" name="325" href="#325">325</a> TTable table = <strong class="jxr_keyword">new</strong> TTable(hbaseConf, TEST_TABLE);
-<a class="jxr_linenumber" name="326" href="#326">326</a>
-<a class="jxr_linenumber" name="327" href="#327">327</a> <strong class="jxr_keyword">final</strong> HBaseTransaction t1 = (HBaseTransaction) tm.begin();
-<a class="jxr_linenumber" name="328" href="#328">328</a>
-<a class="jxr_linenumber" name="329" href="#329">329</a> <em class="jxr_comment">// Start read thread</em>
-<a class="jxr_linenumber" name="330" href="#330">330</a> Thread readThread = <strong class="jxr_keyword">new</strong> Thread(<span class="jxr_string">"Read Thread"</span>) {
-<a class="jxr_linenumber" name="331" href="#331">331</a> @Override
-<a class="jxr_linenumber" name="332" href="#332">332</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> run() {
-<a class="jxr_linenumber" name="333" href="#333">333</a> LOG.info(<span class="jxr_string">"Waiting readAfterCommit barrier"</span>);
-<a class="jxr_linenumber" name="334" href="#334">334</a> <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="335" href="#335">335</a> readAfterCommit.await();
-<a class="jxr_linenumber" name="336" href="#336">336</a> <strong class="jxr_keyword">final</strong> TTable table = spy(<strong class="jxr_keyword">new</strong> TTable(hbaseConf, TEST_TABLE));
-<a class="jxr_linenumber" name="337" href="#337">337</a> doAnswer(<strong class="jxr_keyword">new</strong> Answer<List<KeyValue>>() {
-<a class="jxr_linenumber" name="338" href="#338">338</a> @SuppressWarnings(<span class="jxr_string">"unchecked"</span>)
-<a class="jxr_linenumber" name="339" href="#339">339</a> @Override
-<a class="jxr_linenumber" name="340" href="#340">340</a> <strong class="jxr_keyword">public</strong> List<KeyValue> answer(InvocationOnMock invocation) <strong class="jxr_keyword">throws</strong> Throwable {
-<a class="jxr_linenumber" name="341" href="#341">341</a> LOG.info(<span class="jxr_string">"Release postCommitBegin barrier"</span>);
-<a class="jxr_linenumber" name="342" href="#342">342</a> postCommitBegin.countDown();
-<a class="jxr_linenumber" name="343" href="#343">343</a> LOG.info(<span class="jxr_string">"Waiting postCommitEnd barrier"</span>);
-<a class="jxr_linenumber" name="344" href="#344">344</a> postCommitEnd.await();
-<a class="jxr_linenumber" name="345" href="#345">345</a> <strong class="jxr_keyword">return</strong> (List<KeyValue>) invocation.callRealMethod();
-<a class="jxr_linenumber" name="346" href="#346">346</a> }
-<a class="jxr_linenumber" name="347" href="#347">347</a> }).when(table).filterCellsForSnapshot(Matchers.<List<Cell>>any(),
-<a class="jxr_linenumber" name="348" href="#348">348</a> any(HBaseTransaction.<strong class="jxr_keyword">class</strong>), anyInt());
-<a class="jxr_linenumber" name="349" href="#349">349</a>
-<a class="jxr_linenumber" name="350" href="#350">350</a> TransactionManager tm = newTransactionManager(context);
-<a class="jxr_linenumber" name="351" href="#351">351</a> <strong class="jxr_keyword">if</strong> (hasShadowCell(row,
-<a class="jxr_linenumber" name="352" href="#352">352</a> family,
-<a class="jxr_linenumber" name="353" href="#353">353</a> qualifier,
-<a class="jxr_linenumber" name="354" href="#354">354</a> t1.getStartTimestamp(),
-<a class="jxr_linenumber" name="355" href="#355">355</a> <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table))) {
-<a class="jxr_linenumber" name="356" href="#356">356</a> readFailed.set(<strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="357" href="#357">357</a> }
-<a class="jxr_linenumber" name="358" href="#358">358</a>
-<a class="jxr_linenumber" name="359" href="#359">359</a> Transaction t = tm.begin();
-<a class="jxr_linenumber" name="360" href="#360">360</a> Get get = <strong class="jxr_keyword">new</strong> Get(row);
-<a class="jxr_linenumber" name="361" href="#361">361</a> get.addColumn(family, qualifier);
-<a class="jxr_linenumber" name="362" href="#362">362</a>
-<a class="jxr_linenumber" name="363" href="#363">363</a> Result getResult = table.get(t, get);
-<a class="jxr_linenumber" name="364" href="#364">364</a> Cell cell = getResult.getColumnLatestCell(family, qualifier);
-<a class="jxr_linenumber" name="365" href="#365">365</a> <strong class="jxr_keyword">if</strong> (!Arrays.equals(data1, CellUtil.cloneValue(cell))
-<a class="jxr_linenumber" name="366" href="#366">366</a> || !hasShadowCell(row,
-<a class="jxr_linenumber" name="367" href="#367">367</a> family,
-<a class="jxr_linenumber" name="368" href="#368">368</a> qualifier,
-<a class="jxr_linenumber" name="369" href="#369">369</a> cell.getTimestamp(),
-<a class="jxr_linenumber" name="370" href="#370">370</a> <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table))) {
-<a class="jxr_linenumber" name="371" href="#371">371</a> readFailed.set(<strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="372" href="#372">372</a> } <strong class="jxr_keyword">else</strong> {
-<a class="jxr_linenumber" name="373" href="#373">373</a> LOG.info(<span class="jxr_string">"Read succeeded"</span>);
-<a class="jxr_linenumber" name="374" href="#374">374</a> }
-<a class="jxr_linenumber" name="375" href="#375">375</a> } <strong class="jxr_keyword">catch</strong> (Throwable e) {
-<a class="jxr_linenumber" name="376" href="#376">376</a> readFailed.set(<strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="377" href="#377">377</a> LOG.error(<span class="jxr_string">"Error whilst reading"</span>, e);
-<a class="jxr_linenumber" name="378" href="#378">378</a> }
-<a class="jxr_linenumber" name="379" href="#379">379</a> }
-<a class="jxr_linenumber" name="380" href="#380">380</a> };
-<a class="jxr_linenumber" name="381" href="#381">381</a> readThread.start();
-<a class="jxr_linenumber" name="382" href="#382">382</a>
-<a class="jxr_linenumber" name="383" href="#383">383</a> <em class="jxr_comment">// Write data</em>
-<a class="jxr_linenumber" name="384" href="#384">384</a> Put put = <strong class="jxr_keyword">new</strong> Put(row);
-<a class="jxr_linenumber" name="385" href="#385">385</a> put.add(family, qualifier, data1);
-<a class="jxr_linenumber" name="386" href="#386">386</a> table.put(t1, put);
-<a class="jxr_linenumber" name="387" href="#387">387</a> tm.commit(t1);
-<a class="jxr_linenumber" name="388" href="#388">388</a>
-<a class="jxr_linenumber" name="389" href="#389">389</a> readThread.join();
+<a class="jxr_linenumber" name="287" href="#287">287</a> <em class="jxr_comment">// Re-enable table to allow the required checks below</em>
+<a class="jxr_linenumber" name="288" href="#288">288</a> HBaseAdmin admin = hBaseUtils.getHBaseAdmin();
+<a class="jxr_linenumber" name="289" href="#289">289</a> admin.enableTable(TableName.valueOf(table.getTableName()));
+<a class="jxr_linenumber" name="290" href="#290">290</a>
+<a class="jxr_linenumber" name="291" href="#291">291</a> <em class="jxr_comment">// 1) check that shadow cell is not created...</em>
+<a class="jxr_linenumber" name="292" href="#292">292</a> assertTrue(hasCell(row, family, qualifier, tx.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
+<a class="jxr_linenumber" name="293" href="#293">293</a> <span class="jxr_string">"Cell should be there"</span>);
+<a class="jxr_linenumber" name="294" href="#294">294</a> assertFalse(hasShadowCell(row, family, qualifier, tx.getStartTimestamp(), <strong class="jxr_keyword">new</strong> TTableCellGetterAdapter(table)),
+<a class="jxr_linenumber" name="295" href="#295">295</a> <span class="jxr_string">"Shadow cell should not be there"</span>);
+<a class="jxr_linenumber" name="296" href="#296">296</a> <em class="jxr_comment">// 2) and thus, completeTransaction() was never called on the commit table...</em>
+<a class="jxr_linenumber" name="297" href="#297">297</a> verify(commitTableClient, times(0)).completeTransaction(anyLong());
+<a class="jxr_linenumber" name="298" href="#298">298</a> <em class="jxr_comment">// 3) ...and commit value still in commit table</em>
+<a class="jxr_linenumber" name="299" href="#299">299</a> assertTrue(commitTableClient.getCommitTimestamp(tx.getStartTimestamp()).get().isPresent());
+<a class="jxr_linenumber" name="300" href="#300">300</a>
+<a class="jxr_linenumber" name="301" href="#301">301</a> }
+<a class="jxr_linenumber" name="302" href="#302">302</a>
+<a class="jxr_linenumber" name="303" href="#303">303</a> @Test(timeOut = 60_000)
+<a class="jxr_linenumber" name="304" href="#304">304</a> <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testRaceConditionBetweenReaderAndWriterThreads(<strong class="jxr_keyword">final</strong> ITestContext context) <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="305" href="#305">305</a> <strong class="jxr_keyword">final</strong> CountDownLatch readAfterCommit = <strong class="jxr_keyword">new</strong> CountDownLatch(1);
+<a class="jxr_linenumber" name="306" href="#306">306</a> <strong class="jxr_keyword">final</strong> CountDownLatch postCommitBegin = <strong class="jxr_keyword">new</strong> CountDownLatch(1);
+<a class="jxr_linenumber" name="307" href="#307">307</a> <strong class="jxr_keyword">final</strong> CountDownLatch postCommitEnd = <strong class="jxr_keyword">new</strong> CountDownLatch(1);
+<a class="jxr_linenumber" name="308" href="#308">308</a>
+<a class="jxr_linenumber" name="309" href="#309">309</a> <strong class="jxr_keyword">final</strong> AtomicBoolean readFailed = <strong class="jxr_keyword">new</strong> AtomicBoolean(false);
+<a class="jxr_linenumber" name="310" href="#310">310</a> PostCommitActions syncPostCommitter =
+<a class="jxr_linenumber" name="311" href="#311">311</a> spy(<strong class="jxr_keyword">new</strong> HBaseSyncPostCommitter(<strong class="jxr_keyword">new</strong> NullMetricsProvider(), getCommitTable(context).getClient()));
+<a class="jxr_linenumber" name="312" href="#312">312</a> AbstractTransactionManager tm = (AbstractTransactionManager) newTransactionManager(context, syncPostCommitter);
+<a class="jxr_linenumber" name="313" href="#313">313</a>
+<a class="jxr_linenumber" name="314" href="#314">314</a> doAnswer(<strong class="jxr_keyword">new</strong> Answer<ListenableFuture<Void>>() {
+<a class="jxr_linenumber" name="315" href="#315">315</a> @Override
+<a class="jxr_linenumber" name="316" href="#316">316</a> <strong class="jxr_keyword">public</strong> ListenableFuture<Void> answer(InvocationOnMock invocation) <strong class="jxr_keyword">throws</strong> Throwable {
+<a class="jxr_linenumber" name="317" href="#317">317</a> LOG.info(<span class="jxr_string">"Releasing readAfterCommit barrier"</span>);
+<a class="jxr_linenumber" name="318" href="#318">318</a> readAfterCommit.countDown();
+<a class="jxr_linenumber" name="319" href="#319">319</a> LOG.info(<span class="jxr_string">"Waiting postCommitBegin barrier"</span>);
+<a class="jxr_linenumber" name="320" href="#320">320</a> postCommitBegin.await();
+<a class="jxr_linenumber" name="321" href="#321">321</a>
<TRUNCATED>