You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/11 22:52:05 UTC

[jira] [Commented] (ARTEMIS-1160) AMQP Test client doesn't configure its netty WS handler with the AMQP frame size

    [ https://issues.apache.org/jira/browse/ARTEMIS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007330#comment-16007330 ] 

ASF GitHub Bot commented on ARTEMIS-1160:
-----------------------------------------

GitHub user tabish121 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1267

    ARTEMIS-1160 AMQP test client should configure netty WS maxFrameSize

    Need to configure the WS Handshaker in the test client's netty transport
    with the same value given to the proton connection via setMaxFrameSize
    so that incoming frames larger than the default 65535 over WS don't
    trigger netty to fail the connection.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1160

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1267.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1267
    
----
commit 2755b5c0028aec1b9988575b1b7aa91c78e7f86b
Author: Timothy Bish <ta...@gmail.com>
Date:   2017-05-11T22:50:36Z

    ARTEMIS-1160 AMQP test client should configure netty WS maxFrameSize
    
    Need to configure the WS Handshaker in the test client's netty transport
    with the same value given to the proton connection via setMaxFrameSize
    so that incoming frames larger than the default 65535 over WS don't
    trigger netty to fail the connection.

----


> AMQP Test client doesn't configure its netty WS handler with the AMQP frame size
> --------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1160
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1160
>             Project: ActiveMQ Artemis
>          Issue Type: Test
>          Components: AMQP
>    Affects Versions: 2.1.0
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>             Fix For: 2.2.0
>
>
> The AMQP test client's WS transport should be configured with the AMQP max frame size given to it's proton connection otherwise the broker can send it a larger frame than it's Netty WS handshaker will accept leading to dropped connections due to max incoming frame size violations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)