You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/14 16:14:22 UTC

[GitHub] [dubbo] pinxiong opened a new pull request #9274: fix: Fix the bug of downloading zk binary file

pinxiong opened a new pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274


   see: https://github.com/apache/dubbo/issues/9227
   
   ## Brief changelog
   
   1. Avoid the concurrence when donwloading zookeeper binary file
   2. Destroy the process after stopped zookeeper instance in Unix OS
   3. Support to provide zookeeper binary file by use self and avoid to download zookeeper binary file
   
   ## Verifying this change
   
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
   
   ## Checklist
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [x] Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
   - [x] GitHub Actions works fine on your own branch.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de0c8c5) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.18%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.51%   -0.19%     
     Complexity      327      327              
   ============================================
     Files          1206     1206              
     Lines         51844    51850       +6     
     Branches       7716     7689      -27     
   ============================================
   - Hits          33546    33452      -94     
   - Misses        14684    14771      +87     
   - Partials       3614     3627      +13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | ... and [42 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...de0c8c5](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a58f945) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.10%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.60%   -0.11%     
   - Complexity      327      329       +2     
   ============================================
     Files          1206     1206              
     Lines         51844    51886      +42     
     Branches       7716     7720       +4     
   ============================================
   - Hits          33546    33520      -26     
   - Misses        14684    14747      +63     
   - Partials       3614     3619       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0.00%> (-15.39%)` | :arrow_down: |
   | ... and [20 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...a58f945](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] pinxiong commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r750211255



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/initializer/DownloadZookeeperInitializer.java
##########
@@ -46,46 +48,105 @@
     private static final String ZOOKEEPER_BINARY_URL_FORMAT = "https://archive.apache.org/dist/zookeeper/zookeeper-%s/" + ZOOKEEPER_FILE_NAME_FORMAT;
 
     /**
-     * The temporary directory name
+     * The temporary directory.
      */
-    private static final String TEMPORARY_DIRECTORY_NAME = "dubbo-mocked-zookeeper";
+    private static final String TEMPORARY_DIRECTORY = "zookeeper";
+
+    /**
+     * The timeout when download zookeeper binary archive file.
+     */
+    private static final int CONNECT_TIMEOUT = 30 * 1000;
+
+    /**
+     * The timeout when read the input stream to save in target path.
+     */
+    private static final int READ_TIMEOUT = 10 * 1000;
+
+    /**
+     * Returns {@code true} if the file exists with the given file path, otherwise {@code false}.
+     *
+     * @param filePath the file path to check.
+     */
+    private boolean checkFile(Path filePath) {
+        return Files.exists(filePath) && filePath.toFile().isFile();
+    }
 
     @Override
     protected void doInitialize(ZookeeperContext context) throws DubboTestException {
+        // checks the zookeeper binary file exists or not
+        if (checkFile(context.getSourceFile())) {
+            return;
+        }
         String zookeeperFileName = String.format(ZOOKEEPER_FILE_NAME_FORMAT, context.getVersion());
+        Path temporaryFilePath;
         try {
-            context.setSourceFile(Paths.get(Files.createTempDirectory("").getParent().toString(),
-                TEMPORARY_DIRECTORY_NAME,
-                zookeeperFileName));
+            temporaryFilePath = Paths.get(Files.createTempDirectory("").getParent().toString(),
+                TEMPORARY_DIRECTORY,
+                zookeeperFileName);
         } catch (IOException e) {
-            throw new RuntimeException(String.format("Cannot create the temporary directory, related directory:%s/%s",
-                TEMPORARY_DIRECTORY_NAME, zookeeperFileName), e);
-        }
-        // check if the zookeeper binary file exists
-        if (context.getSourceFile() != null && context.getSourceFile().toFile().isFile()) {
-            return;
+            throw new RuntimeException(String.format("Cannot create the temporary directory, file path: %s", TEMPORARY_DIRECTORY), e);
         }
+
         // create the temporary directory path.
+        try {
+            Files.createDirectories(temporaryFilePath.getParent());
+        } catch (IOException e) {
+            throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", temporaryFilePath.getParent()), e);
+        }
+
+        // download zookeeper binary file in temporary directory.
+        String zookeeperBinaryUrl = String.format(ZOOKEEPER_BINARY_URL_FORMAT, context.getVersion(), context.getVersion());
+        try {
+            logger.info("It is beginning to download the zookeeper binary archive, it will take several minutes..." +
+                "\nThe zookeeper binary archive file will be download from " + zookeeperBinaryUrl + "," +
+                "\nwhich will be saved in " + temporaryFilePath.toString() + "," +
+                "\nalso it will be renamed to 'apache-zookeeper-bin.tar.gz' and moved into {project.dir}.tmp/zookeeper directory.\n");
+            URL url = new URL(zookeeperBinaryUrl);
+            HttpURLConnection connection = (HttpURLConnection) url.openConnection();
+            // set timeout when download the zookeeper binary archive file.
+            connection.setConnectTimeout(CONNECT_TIMEOUT);
+            // set timeout when read downloaded input stream to save in temporary file path.
+            connection.setReadTimeout(READ_TIMEOUT);
+            connection.setRequestMethod("GET");
+            // use cache first
+            connection.setUseCaches(true);
+            // only read input stream from HttpURLConnection
+            connection.setDoInput(true);
+            connection.connect();
+            InputStream inputStream = connection.getInputStream();
+            Files.copy(inputStream, temporaryFilePath, StandardCopyOption.REPLACE_EXISTING);
+        } catch (Exception e) {
+            throw new RuntimeException(String.format("Download zookeeper binary archive failed, download url:%s, file path:%s." +
+                    "\nOr you can do something to avoid this problem as below:" +
+                    "\n1. Download zookeeper binary archive manually regardless of the version" +
+                    "\n2. Rename the downloaded file named 'apache-zookeeper-{version}-bin.tar.gz' to 'apache-zookeeper-bin.tar.gz'" +
+                    "\n3. Put the renamed file in {project.dir}.tmp/zookeeper directory, you maybe need to create the directory if necessary.\n",

Review comment:
       > {project.dir}/.tmp/zookeeper
   
   I want to see that the path .tmp/zookeeper under current project




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kylixs commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r750209866



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/initializer/DownloadZookeeperInitializer.java
##########
@@ -46,46 +48,105 @@
     private static final String ZOOKEEPER_BINARY_URL_FORMAT = "https://archive.apache.org/dist/zookeeper/zookeeper-%s/" + ZOOKEEPER_FILE_NAME_FORMAT;
 
     /**
-     * The temporary directory name
+     * The temporary directory.
      */
-    private static final String TEMPORARY_DIRECTORY_NAME = "dubbo-mocked-zookeeper";
+    private static final String TEMPORARY_DIRECTORY = "zookeeper";
+
+    /**
+     * The timeout when download zookeeper binary archive file.
+     */
+    private static final int CONNECT_TIMEOUT = 30 * 1000;
+
+    /**
+     * The timeout when read the input stream to save in target path.
+     */
+    private static final int READ_TIMEOUT = 10 * 1000;
+
+    /**
+     * Returns {@code true} if the file exists with the given file path, otherwise {@code false}.
+     *
+     * @param filePath the file path to check.
+     */
+    private boolean checkFile(Path filePath) {
+        return Files.exists(filePath) && filePath.toFile().isFile();
+    }
 
     @Override
     protected void doInitialize(ZookeeperContext context) throws DubboTestException {
+        // checks the zookeeper binary file exists or not
+        if (checkFile(context.getSourceFile())) {
+            return;
+        }
         String zookeeperFileName = String.format(ZOOKEEPER_FILE_NAME_FORMAT, context.getVersion());
+        Path temporaryFilePath;
         try {
-            context.setSourceFile(Paths.get(Files.createTempDirectory("").getParent().toString(),
-                TEMPORARY_DIRECTORY_NAME,
-                zookeeperFileName));
+            temporaryFilePath = Paths.get(Files.createTempDirectory("").getParent().toString(),
+                TEMPORARY_DIRECTORY,
+                zookeeperFileName);
         } catch (IOException e) {
-            throw new RuntimeException(String.format("Cannot create the temporary directory, related directory:%s/%s",
-                TEMPORARY_DIRECTORY_NAME, zookeeperFileName), e);
-        }
-        // check if the zookeeper binary file exists
-        if (context.getSourceFile() != null && context.getSourceFile().toFile().isFile()) {
-            return;
+            throw new RuntimeException(String.format("Cannot create the temporary directory, file path: %s", TEMPORARY_DIRECTORY), e);
         }
+
         // create the temporary directory path.
+        try {
+            Files.createDirectories(temporaryFilePath.getParent());
+        } catch (IOException e) {
+            throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", temporaryFilePath.getParent()), e);
+        }
+
+        // download zookeeper binary file in temporary directory.
+        String zookeeperBinaryUrl = String.format(ZOOKEEPER_BINARY_URL_FORMAT, context.getVersion(), context.getVersion());
+        try {
+            logger.info("It is beginning to download the zookeeper binary archive, it will take several minutes..." +
+                "\nThe zookeeper binary archive file will be download from " + zookeeperBinaryUrl + "," +
+                "\nwhich will be saved in " + temporaryFilePath.toString() + "," +
+                "\nalso it will be renamed to 'apache-zookeeper-bin.tar.gz' and moved into {project.dir}.tmp/zookeeper directory.\n");
+            URL url = new URL(zookeeperBinaryUrl);
+            HttpURLConnection connection = (HttpURLConnection) url.openConnection();
+            // set timeout when download the zookeeper binary archive file.
+            connection.setConnectTimeout(CONNECT_TIMEOUT);
+            // set timeout when read downloaded input stream to save in temporary file path.
+            connection.setReadTimeout(READ_TIMEOUT);
+            connection.setRequestMethod("GET");
+            // use cache first
+            connection.setUseCaches(true);
+            // only read input stream from HttpURLConnection
+            connection.setDoInput(true);
+            connection.connect();
+            InputStream inputStream = connection.getInputStream();
+            Files.copy(inputStream, temporaryFilePath, StandardCopyOption.REPLACE_EXISTING);
+        } catch (Exception e) {
+            throw new RuntimeException(String.format("Download zookeeper binary archive failed, download url:%s, file path:%s." +
+                    "\nOr you can do something to avoid this problem as below:" +
+                    "\n1. Download zookeeper binary archive manually regardless of the version" +
+                    "\n2. Rename the downloaded file named 'apache-zookeeper-{version}-bin.tar.gz' to 'apache-zookeeper-bin.tar.gz'" +
+                    "\n3. Put the renamed file in {project.dir}.tmp/zookeeper directory, you maybe need to create the directory if necessary.\n",

Review comment:
       {project.dir}/.tmp/zookeeper , print actual dir or file path is better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de0c8c5) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.14%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.56%   -0.15%     
     Complexity      327      327              
   ============================================
     Files          1206     1206              
     Lines         51844    51886      +42     
     Branches       7716     7720       +4     
   ============================================
   - Hits          33546    33500      -46     
   - Misses        14684    14764      +80     
   - Partials       3614     3622       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | ... and [20 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...de0c8c5](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] pinxiong commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r749892275



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/ZookeeperRegistryCenter.java
##########
@@ -87,10 +98,47 @@ public ZookeeperRegistryCenter() {
      */
     private Map<OS, Map<Command, Processor>> processors = new HashMap<>();
 
+    /**
+     * The default unpacked directory.
+     */
+    private static final String UNPACKED_DIRECTORY = "apache-zookeeper-bin";
+
+    /**
+     * The target name of zookeeper binary file.
+     */
+    private static final String TARGET_ZOOKEEPER_FILE_NAME = UNPACKED_DIRECTORY + ".tar.gz";
+
+    /**
+     * The target directory.
+     * The zookeeper binary file named {@link #TARGET_ZOOKEEPER_FILE_NAME} will be saved in
+     * {@link #TARGET_DIRECTORY} if it downloaded successfully.
+     */
+    private static final String TARGET_DIRECTORY = "test" + File.separator + "zookeeper";

Review comment:
       > It is better to change the directory name similar to `.test`, `.tmp`. The `test` directory can be used for meaningful things.
   
   OK, I have renamed the directory's name from test to .tmp




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] pinxiong commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r749892389



##########
File path: pom.xml
##########
@@ -628,6 +628,7 @@
                         <exclude>Jenkinsfile</exclude>
                         <exclude>**/codestyle/*</exclude>
                         <exclude>**/resources/META-INF/**</exclude>
+                        <exclude>**/test/**</exclude>

Review comment:
       > `test` directory is general, maybe misjudge
   
   OK, I have renamed the directory's name from test to .tmp




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] pinxiong commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r750378477



##########
File path: pom.xml
##########
@@ -628,6 +628,7 @@
                         <exclude>Jenkinsfile</exclude>
                         <exclude>**/codestyle/*</exclude>
                         <exclude>**/resources/META-INF/**</exclude>
+                        <exclude>**/.tmp/**</exclude>

Review comment:
       Have removed it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de0c8c5) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.04%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.66%   -0.05%     
   - Complexity      327      329       +2     
   ============================================
     Files          1206     1206              
     Lines         51844    51886      +42     
     Branches       7716     7720       +4     
   ============================================
   + Hits          33546    33551       +5     
   - Misses        14684    14721      +37     
     Partials       3614     3614              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/WriteQueue.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvV3JpdGVRdWV1ZS5qYXZh) | `68.75% <0.00%> (-6.25%)` | :arrow_down: |
   | ... and [10 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...de0c8c5](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de0c8c5) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.03%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.67%   -0.04%     
   - Complexity      327      329       +2     
   ============================================
     Files          1206     1206              
     Lines         51844    51886      +42     
     Branches       7716     7720       +4     
   ============================================
   + Hits          33546    33557      +11     
   - Misses        14684    14717      +33     
   + Partials       3614     3612       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/WriteQueue.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvV3JpdGVRdWV1ZS5qYXZh) | `68.75% <0.00%> (-6.25%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...de0c8c5](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kylixs commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r749883781



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/ZookeeperRegistryCenter.java
##########
@@ -87,10 +98,47 @@ public ZookeeperRegistryCenter() {
      */
     private Map<OS, Map<Command, Processor>> processors = new HashMap<>();
 
+    /**
+     * The default unpacked directory.
+     */
+    private static final String UNPACKED_DIRECTORY = "apache-zookeeper-bin";
+
+    /**
+     * The target name of zookeeper binary file.
+     */
+    private static final String TARGET_ZOOKEEPER_FILE_NAME = UNPACKED_DIRECTORY + ".tar.gz";
+
+    /**
+     * The target directory.
+     * The zookeeper binary file named {@link #TARGET_ZOOKEEPER_FILE_NAME} will be saved in
+     * {@link #TARGET_DIRECTORY} if it downloaded successfully.
+     */
+    private static final String TARGET_DIRECTORY = "test" + File.separator + "zookeeper";

Review comment:
       It is better to  change the directory name similar to `.test`, `.tmp`.  The `test` directory can be used for meaningful things.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kylixs commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r750208757



##########
File path: .gitignore
##########
@@ -45,3 +45,6 @@ compiler/.gradle/*
 # protobuf
 dubbo-serialization/dubbo-serialization-protobuf/build/*
 dubbo-demo/dubbo-demo-triple/build/*
+
+# global registry center
+.tmp/zookeeper/

Review comment:
       just ignore `.tmp`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kylixs commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r749949690



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/initializer/DownloadZookeeperInitializer.java
##########
@@ -46,46 +47,77 @@
     private static final String ZOOKEEPER_BINARY_URL_FORMAT = "https://archive.apache.org/dist/zookeeper/zookeeper-%s/" + ZOOKEEPER_FILE_NAME_FORMAT;
 
     /**
-     * The temporary directory name
+     * The temporary directory.
      */
-    private static final String TEMPORARY_DIRECTORY_NAME = "dubbo-mocked-zookeeper";
+    private static final String TEMPORARY_DIRECTORY = "zookeeper";
+
+    /**
+     * Returns {@code true} if the file exists with the given file path, otherwise {@code false}.
+     *
+     * @param filePath the file path to check.
+     */
+    private boolean checkFile(Path filePath) {
+        return Files.exists(filePath) && filePath.toFile().isFile();
+    }
 
     @Override
     protected void doInitialize(ZookeeperContext context) throws DubboTestException {
+        // checks the zookeeper binary file exists or not
+        if (checkFile(context.getSourceFile())) {
+            return;
+        }
         String zookeeperFileName = String.format(ZOOKEEPER_FILE_NAME_FORMAT, context.getVersion());
+        Path temporaryFilePath;
         try {
-            context.setSourceFile(Paths.get(Files.createTempDirectory("").getParent().toString(),
-                TEMPORARY_DIRECTORY_NAME,
-                zookeeperFileName));
+            temporaryFilePath = Paths.get(Files.createTempDirectory("").getParent().toString(),
+                TEMPORARY_DIRECTORY,
+                zookeeperFileName);
         } catch (IOException e) {
-            throw new RuntimeException(String.format("Cannot create the temporary directory, related directory:%s/%s",
-                TEMPORARY_DIRECTORY_NAME, zookeeperFileName), e);
-        }
-        // check if the zookeeper binary file exists
-        if (context.getSourceFile() != null && context.getSourceFile().toFile().isFile()) {
-            return;
+            throw new RuntimeException(String.format("Cannot create the temporary directory, file path: %s", TEMPORARY_DIRECTORY), e);
         }
+
         // create the temporary directory path.
-        if (!Files.exists(context.getSourceFile())) {
-            try {
-                Files.createDirectories(context.getSourceFile());
-            } catch (IOException e) {
-                throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", context.getSourceFile()), e);
-            }
+        try {
+            Files.createDirectories(temporaryFilePath.getParent());
+        } catch (IOException e) {
+            throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", temporaryFilePath.getParent()), e);
         }
-        // download zookeeper binary file
+
+        // download zookeeper binary file in temporary directory.
         String zookeeperBinaryUrl = String.format(ZOOKEEPER_BINARY_URL_FORMAT, context.getVersion(), context.getVersion());
         try {
             logger.info("It is beginning to download the zookeeper binary archive, it will take several minutes...");
             URL zookeeperBinaryURL = new URL(zookeeperBinaryUrl);
             InputStream inputStream = zookeeperBinaryURL.openStream();
-            Files.copy(inputStream, context.getSourceFile(), StandardCopyOption.REPLACE_EXISTING);
+            Files.copy(inputStream, temporaryFilePath, StandardCopyOption.REPLACE_EXISTING);
         } catch (Exception e) {
             throw new RuntimeException(String.format("Download zookeeper binary archive failed, download url:%s, file path:%s",

Review comment:
       Prompt the user to download manually when the download fails, and put it in the specified directory.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9db2c81) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.14%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.56%   -0.15%     
   - Complexity      327      330       +3     
   ============================================
     Files          1206     1206              
     Lines         51844    51865      +21     
     Branches       7716     7689      -27     
   ============================================
   - Hits          33546    33485      -61     
   - Misses        14684    14761      +77     
   - Partials       3614     3619       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | ... and [45 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...9db2c81](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] pinxiong commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r750207379



##########
File path: .gitignore
##########
@@ -45,3 +45,6 @@ compiler/.gradle/*
 # protobuf
 dubbo-serialization/dubbo-serialization-protobuf/build/*
 dubbo-demo/dubbo-demo-triple/build/*
+
+# global registry center
+test/zookeeper/

Review comment:
       I've fixed it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f7f158f) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.16%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.54%   -0.17%     
   + Complexity      327      326       -1     
   ============================================
     Files          1206     1206              
     Lines         51844    51850       +6     
     Branches       7716     7689      -27     
   ============================================
   - Hits          33546    33466      -80     
   - Misses        14684    14752      +68     
   - Partials       3614     3632      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75.00% <0.00%> (-12.50%)` | :arrow_down: |
   | ... and [43 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...f7f158f](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kylixs commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r749948872



##########
File path: .gitignore
##########
@@ -45,3 +45,6 @@ compiler/.gradle/*
 # protobuf
 dubbo-serialization/dubbo-serialization-protobuf/build/*
 dubbo-demo/dubbo-demo-triple/build/*
+
+# global registry center
+test/zookeeper/

Review comment:
       git ignore pattern needs to be updated to `.tmp`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5770b6b) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.09%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.61%   -0.10%     
   - Complexity      327      330       +3     
   ============================================
     Files          1206     1206              
     Lines         51844    51894      +50     
     Branches       7716     7720       +4     
   ============================================
   - Hits          33546    33529      -17     
   - Misses        14684    14751      +67     
     Partials       3614     3614              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | ... and [21 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...5770b6b](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a58f945) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.15%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.54%   -0.16%     
     Complexity      327      327              
   ============================================
     Files          1206     1206              
     Lines         51844    51850       +6     
     Branches       7716     7689      -27     
   ============================================
   - Hits          33546    33469      -77     
   - Misses        14684    14751      +67     
   - Partials       3614     3630      +16     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75.00% <0.00%> (-12.50%)` | :arrow_down: |
   | ... and [43 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...a58f945](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kylixs commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r749951176



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/initializer/DownloadZookeeperInitializer.java
##########
@@ -46,46 +47,77 @@
     private static final String ZOOKEEPER_BINARY_URL_FORMAT = "https://archive.apache.org/dist/zookeeper/zookeeper-%s/" + ZOOKEEPER_FILE_NAME_FORMAT;
 
     /**
-     * The temporary directory name
+     * The temporary directory.
      */
-    private static final String TEMPORARY_DIRECTORY_NAME = "dubbo-mocked-zookeeper";
+    private static final String TEMPORARY_DIRECTORY = "zookeeper";
+
+    /**
+     * Returns {@code true} if the file exists with the given file path, otherwise {@code false}.
+     *
+     * @param filePath the file path to check.
+     */
+    private boolean checkFile(Path filePath) {
+        return Files.exists(filePath) && filePath.toFile().isFile();
+    }
 
     @Override
     protected void doInitialize(ZookeeperContext context) throws DubboTestException {
+        // checks the zookeeper binary file exists or not
+        if (checkFile(context.getSourceFile())) {
+            return;
+        }
         String zookeeperFileName = String.format(ZOOKEEPER_FILE_NAME_FORMAT, context.getVersion());
+        Path temporaryFilePath;
         try {
-            context.setSourceFile(Paths.get(Files.createTempDirectory("").getParent().toString(),
-                TEMPORARY_DIRECTORY_NAME,
-                zookeeperFileName));
+            temporaryFilePath = Paths.get(Files.createTempDirectory("").getParent().toString(),
+                TEMPORARY_DIRECTORY,
+                zookeeperFileName);
         } catch (IOException e) {
-            throw new RuntimeException(String.format("Cannot create the temporary directory, related directory:%s/%s",
-                TEMPORARY_DIRECTORY_NAME, zookeeperFileName), e);
-        }
-        // check if the zookeeper binary file exists
-        if (context.getSourceFile() != null && context.getSourceFile().toFile().isFile()) {
-            return;
+            throw new RuntimeException(String.format("Cannot create the temporary directory, file path: %s", TEMPORARY_DIRECTORY), e);
         }
+
         // create the temporary directory path.
-        if (!Files.exists(context.getSourceFile())) {
-            try {
-                Files.createDirectories(context.getSourceFile());
-            } catch (IOException e) {
-                throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", context.getSourceFile()), e);
-            }
+        try {
+            Files.createDirectories(temporaryFilePath.getParent());
+        } catch (IOException e) {
+            throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", temporaryFilePath.getParent()), e);
         }
-        // download zookeeper binary file
+
+        // download zookeeper binary file in temporary directory.
         String zookeeperBinaryUrl = String.format(ZOOKEEPER_BINARY_URL_FORMAT, context.getVersion(), context.getVersion());
         try {
             logger.info("It is beginning to download the zookeeper binary archive, it will take several minutes...");

Review comment:
       Log download url and  target path before download.  If it was hanged on downloading,  user can break it and download manually.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] pinxiong commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r750379344



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/initializer/DownloadZookeeperInitializer.java
##########
@@ -46,46 +48,105 @@
     private static final String ZOOKEEPER_BINARY_URL_FORMAT = "https://archive.apache.org/dist/zookeeper/zookeeper-%s/" + ZOOKEEPER_FILE_NAME_FORMAT;
 
     /**
-     * The temporary directory name
+     * The temporary directory.
      */
-    private static final String TEMPORARY_DIRECTORY_NAME = "dubbo-mocked-zookeeper";
+    private static final String TEMPORARY_DIRECTORY = "zookeeper";
+
+    /**
+     * The timeout when download zookeeper binary archive file.
+     */
+    private static final int CONNECT_TIMEOUT = 30 * 1000;
+
+    /**
+     * The timeout when read the input stream to save in target path.
+     */
+    private static final int READ_TIMEOUT = 10 * 1000;
+
+    /**
+     * Returns {@code true} if the file exists with the given file path, otherwise {@code false}.
+     *
+     * @param filePath the file path to check.
+     */
+    private boolean checkFile(Path filePath) {
+        return Files.exists(filePath) && filePath.toFile().isFile();
+    }
 
     @Override
     protected void doInitialize(ZookeeperContext context) throws DubboTestException {
+        // checks the zookeeper binary file exists or not
+        if (checkFile(context.getSourceFile())) {
+            return;
+        }
         String zookeeperFileName = String.format(ZOOKEEPER_FILE_NAME_FORMAT, context.getVersion());
+        Path temporaryFilePath;
         try {
-            context.setSourceFile(Paths.get(Files.createTempDirectory("").getParent().toString(),
-                TEMPORARY_DIRECTORY_NAME,
-                zookeeperFileName));
+            temporaryFilePath = Paths.get(Files.createTempDirectory("").getParent().toString(),
+                TEMPORARY_DIRECTORY,
+                zookeeperFileName);
         } catch (IOException e) {
-            throw new RuntimeException(String.format("Cannot create the temporary directory, related directory:%s/%s",
-                TEMPORARY_DIRECTORY_NAME, zookeeperFileName), e);
-        }
-        // check if the zookeeper binary file exists
-        if (context.getSourceFile() != null && context.getSourceFile().toFile().isFile()) {
-            return;
+            throw new RuntimeException(String.format("Cannot create the temporary directory, file path: %s", TEMPORARY_DIRECTORY), e);
         }
+
         // create the temporary directory path.
+        try {
+            Files.createDirectories(temporaryFilePath.getParent());
+        } catch (IOException e) {
+            throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", temporaryFilePath.getParent()), e);
+        }
+
+        // download zookeeper binary file in temporary directory.
+        String zookeeperBinaryUrl = String.format(ZOOKEEPER_BINARY_URL_FORMAT, context.getVersion(), context.getVersion());
+        try {
+            logger.info("It is beginning to download the zookeeper binary archive, it will take several minutes..." +
+                "\nThe zookeeper binary archive file will be download from " + zookeeperBinaryUrl + "," +
+                "\nwhich will be saved in " + temporaryFilePath.toString() + "," +
+                "\nalso it will be renamed to 'apache-zookeeper-bin.tar.gz' and moved into {project.dir}.tmp/zookeeper directory.\n");
+            URL url = new URL(zookeeperBinaryUrl);
+            HttpURLConnection connection = (HttpURLConnection) url.openConnection();
+            // set timeout when download the zookeeper binary archive file.
+            connection.setConnectTimeout(CONNECT_TIMEOUT);
+            // set timeout when read downloaded input stream to save in temporary file path.
+            connection.setReadTimeout(READ_TIMEOUT);
+            connection.setRequestMethod("GET");
+            // use cache first
+            connection.setUseCaches(true);
+            // only read input stream from HttpURLConnection
+            connection.setDoInput(true);
+            connection.connect();
+            InputStream inputStream = connection.getInputStream();
+            Files.copy(inputStream, temporaryFilePath, StandardCopyOption.REPLACE_EXISTING);
+        } catch (Exception e) {
+            throw new RuntimeException(String.format("Download zookeeper binary archive failed, download url:%s, file path:%s." +
+                    "\nOr you can do something to avoid this problem as below:" +
+                    "\n1. Download zookeeper binary archive manually regardless of the version" +
+                    "\n2. Rename the downloaded file named 'apache-zookeeper-{version}-bin.tar.gz' to 'apache-zookeeper-bin.tar.gz'" +
+                    "\n3. Put the renamed file in {project.dir}.tmp/zookeeper directory, you maybe need to create the directory if necessary.\n",

Review comment:
       I have printed the absolute path




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58bf843) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.07%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.63%   -0.08%     
   - Complexity      327      328       +1     
   ============================================
     Files          1206     1206              
     Lines         51844    51886      +42     
     Branches       7716     7720       +4     
   ============================================
   - Hits          33546    33535      -11     
   - Misses        14684    14738      +54     
   + Partials       3614     3613       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | ... and [13 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...58bf843](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kylixs commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r750220455



##########
File path: pom.xml
##########
@@ -628,6 +628,7 @@
                         <exclude>Jenkinsfile</exclude>
                         <exclude>**/codestyle/*</exclude>
                         <exclude>**/resources/META-INF/**</exclude>
+                        <exclude>**/.tmp/**</exclude>

Review comment:
       no need to add `.tmp` dir, it's not included in maven project.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kylixs commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r749882800



##########
File path: pom.xml
##########
@@ -628,6 +628,7 @@
                         <exclude>Jenkinsfile</exclude>
                         <exclude>**/codestyle/*</exclude>
                         <exclude>**/resources/META-INF/**</exclude>
+                        <exclude>**/test/**</exclude>

Review comment:
       `test` directory is general,  maybe misjudge




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5770b6b) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.15%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.55%   -0.16%     
   - Complexity      327      329       +2     
   ============================================
     Files          1206     1206              
     Lines         51844    51858      +14     
     Branches       7716     7689      -27     
   ============================================
   - Hits          33546    33475      -71     
   - Misses        14684    14760      +76     
   - Partials       3614     3623       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | ... and [44 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...5770b6b](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kylixs commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r749949690



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/initializer/DownloadZookeeperInitializer.java
##########
@@ -46,46 +47,77 @@
     private static final String ZOOKEEPER_BINARY_URL_FORMAT = "https://archive.apache.org/dist/zookeeper/zookeeper-%s/" + ZOOKEEPER_FILE_NAME_FORMAT;
 
     /**
-     * The temporary directory name
+     * The temporary directory.
      */
-    private static final String TEMPORARY_DIRECTORY_NAME = "dubbo-mocked-zookeeper";
+    private static final String TEMPORARY_DIRECTORY = "zookeeper";
+
+    /**
+     * Returns {@code true} if the file exists with the given file path, otherwise {@code false}.
+     *
+     * @param filePath the file path to check.
+     */
+    private boolean checkFile(Path filePath) {
+        return Files.exists(filePath) && filePath.toFile().isFile();
+    }
 
     @Override
     protected void doInitialize(ZookeeperContext context) throws DubboTestException {
+        // checks the zookeeper binary file exists or not
+        if (checkFile(context.getSourceFile())) {
+            return;
+        }
         String zookeeperFileName = String.format(ZOOKEEPER_FILE_NAME_FORMAT, context.getVersion());
+        Path temporaryFilePath;
         try {
-            context.setSourceFile(Paths.get(Files.createTempDirectory("").getParent().toString(),
-                TEMPORARY_DIRECTORY_NAME,
-                zookeeperFileName));
+            temporaryFilePath = Paths.get(Files.createTempDirectory("").getParent().toString(),
+                TEMPORARY_DIRECTORY,
+                zookeeperFileName);
         } catch (IOException e) {
-            throw new RuntimeException(String.format("Cannot create the temporary directory, related directory:%s/%s",
-                TEMPORARY_DIRECTORY_NAME, zookeeperFileName), e);
-        }
-        // check if the zookeeper binary file exists
-        if (context.getSourceFile() != null && context.getSourceFile().toFile().isFile()) {
-            return;
+            throw new RuntimeException(String.format("Cannot create the temporary directory, file path: %s", TEMPORARY_DIRECTORY), e);
         }
+
         // create the temporary directory path.
-        if (!Files.exists(context.getSourceFile())) {
-            try {
-                Files.createDirectories(context.getSourceFile());
-            } catch (IOException e) {
-                throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", context.getSourceFile()), e);
-            }
+        try {
+            Files.createDirectories(temporaryFilePath.getParent());
+        } catch (IOException e) {
+            throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", temporaryFilePath.getParent()), e);
         }
-        // download zookeeper binary file
+
+        // download zookeeper binary file in temporary directory.
         String zookeeperBinaryUrl = String.format(ZOOKEEPER_BINARY_URL_FORMAT, context.getVersion(), context.getVersion());
         try {
             logger.info("It is beginning to download the zookeeper binary archive, it will take several minutes...");
             URL zookeeperBinaryURL = new URL(zookeeperBinaryUrl);
             InputStream inputStream = zookeeperBinaryURL.openStream();
-            Files.copy(inputStream, context.getSourceFile(), StandardCopyOption.REPLACE_EXISTING);
+            Files.copy(inputStream, temporaryFilePath, StandardCopyOption.REPLACE_EXISTING);
         } catch (Exception e) {
             throw new RuntimeException(String.format("Download zookeeper binary archive failed, download url:%s, file path:%s",

Review comment:
       Prompt the user to download manually when the download fails, and put it in the specified directory.
   You can give a download url, target path, etc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de0c8c5) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.05%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.65%   -0.06%     
   - Complexity      327      329       +2     
   ============================================
     Files          1206     1206              
     Lines         51844    51886      +42     
     Branches       7716     7720       +4     
   ============================================
   + Hits          33546    33547       +1     
   - Misses        14684    14724      +40     
   - Partials       3614     3615       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/protocol/tri/WriteQueue.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvV3JpdGVRdWV1ZS5qYXZh) | `68.75% <0.00%> (-6.25%)` | :arrow_down: |
   | ... and [10 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...de0c8c5](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kylixs commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r749951516



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/initializer/DownloadZookeeperInitializer.java
##########
@@ -46,46 +47,77 @@
     private static final String ZOOKEEPER_BINARY_URL_FORMAT = "https://archive.apache.org/dist/zookeeper/zookeeper-%s/" + ZOOKEEPER_FILE_NAME_FORMAT;
 
     /**
-     * The temporary directory name
+     * The temporary directory.
      */
-    private static final String TEMPORARY_DIRECTORY_NAME = "dubbo-mocked-zookeeper";
+    private static final String TEMPORARY_DIRECTORY = "zookeeper";
+
+    /**
+     * Returns {@code true} if the file exists with the given file path, otherwise {@code false}.
+     *
+     * @param filePath the file path to check.
+     */
+    private boolean checkFile(Path filePath) {
+        return Files.exists(filePath) && filePath.toFile().isFile();
+    }
 
     @Override
     protected void doInitialize(ZookeeperContext context) throws DubboTestException {
+        // checks the zookeeper binary file exists or not
+        if (checkFile(context.getSourceFile())) {
+            return;
+        }
         String zookeeperFileName = String.format(ZOOKEEPER_FILE_NAME_FORMAT, context.getVersion());
+        Path temporaryFilePath;
         try {
-            context.setSourceFile(Paths.get(Files.createTempDirectory("").getParent().toString(),
-                TEMPORARY_DIRECTORY_NAME,
-                zookeeperFileName));
+            temporaryFilePath = Paths.get(Files.createTempDirectory("").getParent().toString(),
+                TEMPORARY_DIRECTORY,
+                zookeeperFileName);
         } catch (IOException e) {
-            throw new RuntimeException(String.format("Cannot create the temporary directory, related directory:%s/%s",
-                TEMPORARY_DIRECTORY_NAME, zookeeperFileName), e);
-        }
-        // check if the zookeeper binary file exists
-        if (context.getSourceFile() != null && context.getSourceFile().toFile().isFile()) {
-            return;
+            throw new RuntimeException(String.format("Cannot create the temporary directory, file path: %s", TEMPORARY_DIRECTORY), e);
         }
+
         // create the temporary directory path.
-        if (!Files.exists(context.getSourceFile())) {
-            try {
-                Files.createDirectories(context.getSourceFile());
-            } catch (IOException e) {
-                throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", context.getSourceFile()), e);
-            }
+        try {
+            Files.createDirectories(temporaryFilePath.getParent());
+        } catch (IOException e) {
+            throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", temporaryFilePath.getParent()), e);
         }
-        // download zookeeper binary file
+
+        // download zookeeper binary file in temporary directory.
         String zookeeperBinaryUrl = String.format(ZOOKEEPER_BINARY_URL_FORMAT, context.getVersion(), context.getVersion());
         try {
             logger.info("It is beginning to download the zookeeper binary archive, it will take several minutes...");

Review comment:
       It's better to check  download timeout async ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] pinxiong commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r750207909



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/initializer/DownloadZookeeperInitializer.java
##########
@@ -46,46 +47,77 @@
     private static final String ZOOKEEPER_BINARY_URL_FORMAT = "https://archive.apache.org/dist/zookeeper/zookeeper-%s/" + ZOOKEEPER_FILE_NAME_FORMAT;
 
     /**
-     * The temporary directory name
+     * The temporary directory.
      */
-    private static final String TEMPORARY_DIRECTORY_NAME = "dubbo-mocked-zookeeper";
+    private static final String TEMPORARY_DIRECTORY = "zookeeper";
+
+    /**
+     * Returns {@code true} if the file exists with the given file path, otherwise {@code false}.
+     *
+     * @param filePath the file path to check.
+     */
+    private boolean checkFile(Path filePath) {
+        return Files.exists(filePath) && filePath.toFile().isFile();
+    }
 
     @Override
     protected void doInitialize(ZookeeperContext context) throws DubboTestException {
+        // checks the zookeeper binary file exists or not
+        if (checkFile(context.getSourceFile())) {
+            return;
+        }
         String zookeeperFileName = String.format(ZOOKEEPER_FILE_NAME_FORMAT, context.getVersion());
+        Path temporaryFilePath;
         try {
-            context.setSourceFile(Paths.get(Files.createTempDirectory("").getParent().toString(),
-                TEMPORARY_DIRECTORY_NAME,
-                zookeeperFileName));
+            temporaryFilePath = Paths.get(Files.createTempDirectory("").getParent().toString(),
+                TEMPORARY_DIRECTORY,
+                zookeeperFileName);
         } catch (IOException e) {
-            throw new RuntimeException(String.format("Cannot create the temporary directory, related directory:%s/%s",
-                TEMPORARY_DIRECTORY_NAME, zookeeperFileName), e);
-        }
-        // check if the zookeeper binary file exists
-        if (context.getSourceFile() != null && context.getSourceFile().toFile().isFile()) {
-            return;
+            throw new RuntimeException(String.format("Cannot create the temporary directory, file path: %s", TEMPORARY_DIRECTORY), e);
         }
+
         // create the temporary directory path.
-        if (!Files.exists(context.getSourceFile())) {
-            try {
-                Files.createDirectories(context.getSourceFile());
-            } catch (IOException e) {
-                throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", context.getSourceFile()), e);
-            }
+        try {
+            Files.createDirectories(temporaryFilePath.getParent());
+        } catch (IOException e) {
+            throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", temporaryFilePath.getParent()), e);
         }
-        // download zookeeper binary file
+
+        // download zookeeper binary file in temporary directory.
         String zookeeperBinaryUrl = String.format(ZOOKEEPER_BINARY_URL_FORMAT, context.getVersion(), context.getVersion());
         try {
             logger.info("It is beginning to download the zookeeper binary archive, it will take several minutes...");
             URL zookeeperBinaryURL = new URL(zookeeperBinaryUrl);
             InputStream inputStream = zookeeperBinaryURL.openStream();
-            Files.copy(inputStream, context.getSourceFile(), StandardCopyOption.REPLACE_EXISTING);
+            Files.copy(inputStream, temporaryFilePath, StandardCopyOption.REPLACE_EXISTING);
         } catch (Exception e) {
             throw new RuntimeException(String.format("Download zookeeper binary archive failed, download url:%s, file path:%s",

Review comment:
       Good idea! It's done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kylixs commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r750218155



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/initializer/DownloadZookeeperInitializer.java
##########
@@ -46,46 +48,105 @@
     private static final String ZOOKEEPER_BINARY_URL_FORMAT = "https://archive.apache.org/dist/zookeeper/zookeeper-%s/" + ZOOKEEPER_FILE_NAME_FORMAT;
 
     /**
-     * The temporary directory name
+     * The temporary directory.
      */
-    private static final String TEMPORARY_DIRECTORY_NAME = "dubbo-mocked-zookeeper";
+    private static final String TEMPORARY_DIRECTORY = "zookeeper";
+
+    /**
+     * The timeout when download zookeeper binary archive file.
+     */
+    private static final int CONNECT_TIMEOUT = 30 * 1000;
+
+    /**
+     * The timeout when read the input stream to save in target path.
+     */
+    private static final int READ_TIMEOUT = 10 * 1000;
+
+    /**
+     * Returns {@code true} if the file exists with the given file path, otherwise {@code false}.
+     *
+     * @param filePath the file path to check.
+     */
+    private boolean checkFile(Path filePath) {
+        return Files.exists(filePath) && filePath.toFile().isFile();
+    }
 
     @Override
     protected void doInitialize(ZookeeperContext context) throws DubboTestException {
+        // checks the zookeeper binary file exists or not
+        if (checkFile(context.getSourceFile())) {
+            return;
+        }
         String zookeeperFileName = String.format(ZOOKEEPER_FILE_NAME_FORMAT, context.getVersion());
+        Path temporaryFilePath;
         try {
-            context.setSourceFile(Paths.get(Files.createTempDirectory("").getParent().toString(),
-                TEMPORARY_DIRECTORY_NAME,
-                zookeeperFileName));
+            temporaryFilePath = Paths.get(Files.createTempDirectory("").getParent().toString(),
+                TEMPORARY_DIRECTORY,
+                zookeeperFileName);
         } catch (IOException e) {
-            throw new RuntimeException(String.format("Cannot create the temporary directory, related directory:%s/%s",
-                TEMPORARY_DIRECTORY_NAME, zookeeperFileName), e);
-        }
-        // check if the zookeeper binary file exists
-        if (context.getSourceFile() != null && context.getSourceFile().toFile().isFile()) {
-            return;
+            throw new RuntimeException(String.format("Cannot create the temporary directory, file path: %s", TEMPORARY_DIRECTORY), e);
         }
+
         // create the temporary directory path.
+        try {
+            Files.createDirectories(temporaryFilePath.getParent());
+        } catch (IOException e) {
+            throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", temporaryFilePath.getParent()), e);
+        }
+
+        // download zookeeper binary file in temporary directory.
+        String zookeeperBinaryUrl = String.format(ZOOKEEPER_BINARY_URL_FORMAT, context.getVersion(), context.getVersion());
+        try {
+            logger.info("It is beginning to download the zookeeper binary archive, it will take several minutes..." +
+                "\nThe zookeeper binary archive file will be download from " + zookeeperBinaryUrl + "," +
+                "\nwhich will be saved in " + temporaryFilePath.toString() + "," +
+                "\nalso it will be renamed to 'apache-zookeeper-bin.tar.gz' and moved into {project.dir}.tmp/zookeeper directory.\n");
+            URL url = new URL(zookeeperBinaryUrl);
+            HttpURLConnection connection = (HttpURLConnection) url.openConnection();
+            // set timeout when download the zookeeper binary archive file.
+            connection.setConnectTimeout(CONNECT_TIMEOUT);
+            // set timeout when read downloaded input stream to save in temporary file path.
+            connection.setReadTimeout(READ_TIMEOUT);

Review comment:
       > If the timeout expires before there is data available for read, a java.net.SocketTimeoutException is raised
   
   The read timeout will not interrupt the downloading if the file data is received slowly and continuously. It is more reliable to check the download timeout in a separate checking thread, or use the request timeout of the asynchronous http client :  https://stackoverflow.com/a/38273306
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f7f158f) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.11%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.58%   -0.12%     
     Complexity      327      327              
   ============================================
     Files          1206     1206              
     Lines         51844    51886      +42     
     Branches       7716     7720       +4     
   ============================================
   - Hits          33546    33513      -33     
   - Misses        14684    14753      +69     
   - Partials       3614     3620       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0.00%> (-15.39%)` | :arrow_down: |
   | ... and [19 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...f7f158f](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] pinxiong commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r750377871



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/initializer/DownloadZookeeperInitializer.java
##########
@@ -46,46 +48,105 @@
     private static final String ZOOKEEPER_BINARY_URL_FORMAT = "https://archive.apache.org/dist/zookeeper/zookeeper-%s/" + ZOOKEEPER_FILE_NAME_FORMAT;
 
     /**
-     * The temporary directory name
+     * The temporary directory.
      */
-    private static final String TEMPORARY_DIRECTORY_NAME = "dubbo-mocked-zookeeper";
+    private static final String TEMPORARY_DIRECTORY = "zookeeper";
+
+    /**
+     * The timeout when download zookeeper binary archive file.
+     */
+    private static final int CONNECT_TIMEOUT = 30 * 1000;
+
+    /**
+     * The timeout when read the input stream to save in target path.
+     */
+    private static final int READ_TIMEOUT = 10 * 1000;
+
+    /**
+     * Returns {@code true} if the file exists with the given file path, otherwise {@code false}.
+     *
+     * @param filePath the file path to check.
+     */
+    private boolean checkFile(Path filePath) {
+        return Files.exists(filePath) && filePath.toFile().isFile();
+    }
 
     @Override
     protected void doInitialize(ZookeeperContext context) throws DubboTestException {
+        // checks the zookeeper binary file exists or not
+        if (checkFile(context.getSourceFile())) {
+            return;
+        }
         String zookeeperFileName = String.format(ZOOKEEPER_FILE_NAME_FORMAT, context.getVersion());
+        Path temporaryFilePath;
         try {
-            context.setSourceFile(Paths.get(Files.createTempDirectory("").getParent().toString(),
-                TEMPORARY_DIRECTORY_NAME,
-                zookeeperFileName));
+            temporaryFilePath = Paths.get(Files.createTempDirectory("").getParent().toString(),
+                TEMPORARY_DIRECTORY,
+                zookeeperFileName);
         } catch (IOException e) {
-            throw new RuntimeException(String.format("Cannot create the temporary directory, related directory:%s/%s",
-                TEMPORARY_DIRECTORY_NAME, zookeeperFileName), e);
-        }
-        // check if the zookeeper binary file exists
-        if (context.getSourceFile() != null && context.getSourceFile().toFile().isFile()) {
-            return;
+            throw new RuntimeException(String.format("Cannot create the temporary directory, file path: %s", TEMPORARY_DIRECTORY), e);
         }
+
         // create the temporary directory path.
+        try {
+            Files.createDirectories(temporaryFilePath.getParent());
+        } catch (IOException e) {
+            throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", temporaryFilePath.getParent()), e);
+        }
+
+        // download zookeeper binary file in temporary directory.
+        String zookeeperBinaryUrl = String.format(ZOOKEEPER_BINARY_URL_FORMAT, context.getVersion(), context.getVersion());
+        try {
+            logger.info("It is beginning to download the zookeeper binary archive, it will take several minutes..." +
+                "\nThe zookeeper binary archive file will be download from " + zookeeperBinaryUrl + "," +
+                "\nwhich will be saved in " + temporaryFilePath.toString() + "," +
+                "\nalso it will be renamed to 'apache-zookeeper-bin.tar.gz' and moved into {project.dir}.tmp/zookeeper directory.\n");
+            URL url = new URL(zookeeperBinaryUrl);
+            HttpURLConnection connection = (HttpURLConnection) url.openConnection();
+            // set timeout when download the zookeeper binary archive file.
+            connection.setConnectTimeout(CONNECT_TIMEOUT);
+            // set timeout when read downloaded input stream to save in temporary file path.
+            connection.setReadTimeout(READ_TIMEOUT);

Review comment:
       I have used `AsyncHttpClient` to download zookeeper binary archive file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ merged pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] pinxiong commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
pinxiong commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r750210324



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/initializer/DownloadZookeeperInitializer.java
##########
@@ -46,46 +47,77 @@
     private static final String ZOOKEEPER_BINARY_URL_FORMAT = "https://archive.apache.org/dist/zookeeper/zookeeper-%s/" + ZOOKEEPER_FILE_NAME_FORMAT;
 
     /**
-     * The temporary directory name
+     * The temporary directory.
      */
-    private static final String TEMPORARY_DIRECTORY_NAME = "dubbo-mocked-zookeeper";
+    private static final String TEMPORARY_DIRECTORY = "zookeeper";
+
+    /**
+     * Returns {@code true} if the file exists with the given file path, otherwise {@code false}.
+     *
+     * @param filePath the file path to check.
+     */
+    private boolean checkFile(Path filePath) {
+        return Files.exists(filePath) && filePath.toFile().isFile();
+    }
 
     @Override
     protected void doInitialize(ZookeeperContext context) throws DubboTestException {
+        // checks the zookeeper binary file exists or not
+        if (checkFile(context.getSourceFile())) {
+            return;
+        }
         String zookeeperFileName = String.format(ZOOKEEPER_FILE_NAME_FORMAT, context.getVersion());
+        Path temporaryFilePath;
         try {
-            context.setSourceFile(Paths.get(Files.createTempDirectory("").getParent().toString(),
-                TEMPORARY_DIRECTORY_NAME,
-                zookeeperFileName));
+            temporaryFilePath = Paths.get(Files.createTempDirectory("").getParent().toString(),
+                TEMPORARY_DIRECTORY,
+                zookeeperFileName);
         } catch (IOException e) {
-            throw new RuntimeException(String.format("Cannot create the temporary directory, related directory:%s/%s",
-                TEMPORARY_DIRECTORY_NAME, zookeeperFileName), e);
-        }
-        // check if the zookeeper binary file exists
-        if (context.getSourceFile() != null && context.getSourceFile().toFile().isFile()) {
-            return;
+            throw new RuntimeException(String.format("Cannot create the temporary directory, file path: %s", TEMPORARY_DIRECTORY), e);
         }
+
         // create the temporary directory path.
-        if (!Files.exists(context.getSourceFile())) {
-            try {
-                Files.createDirectories(context.getSourceFile());
-            } catch (IOException e) {
-                throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", context.getSourceFile()), e);
-            }
+        try {
+            Files.createDirectories(temporaryFilePath.getParent());
+        } catch (IOException e) {
+            throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", temporaryFilePath.getParent()), e);
         }
-        // download zookeeper binary file
+
+        // download zookeeper binary file in temporary directory.
         String zookeeperBinaryUrl = String.format(ZOOKEEPER_BINARY_URL_FORMAT, context.getVersion(), context.getVersion());
         try {
             logger.info("It is beginning to download the zookeeper binary archive, it will take several minutes...");

Review comment:
       I have logged all important info and set timeout when downloading.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58bf843) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.12%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.58%   -0.13%     
   - Complexity      327      328       +1     
   ============================================
     Files          1206     1206              
     Lines         51844    51886      +42     
     Branches       7716     7720       +4     
   ============================================
   - Hits          33546    33508      -38     
   - Misses        14684    14760      +76     
   - Partials       3614     3618       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | ... and [19 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...58bf843](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58bf843) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.15%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.54%   -0.16%     
     Complexity      327      327              
   ============================================
     Files          1206     1206              
     Lines         51844    51850       +6     
     Branches       7716     7689      -27     
   ============================================
   - Hits          33546    33467      -79     
   - Misses        14684    14759      +75     
   - Partials       3614     3624      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | ... and [42 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...58bf843](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] kylixs commented on a change in pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#discussion_r750209866



##########
File path: dubbo-test/dubbo-test-check/src/main/java/org/apache/dubbo/test/check/registrycenter/initializer/DownloadZookeeperInitializer.java
##########
@@ -46,46 +48,105 @@
     private static final String ZOOKEEPER_BINARY_URL_FORMAT = "https://archive.apache.org/dist/zookeeper/zookeeper-%s/" + ZOOKEEPER_FILE_NAME_FORMAT;
 
     /**
-     * The temporary directory name
+     * The temporary directory.
      */
-    private static final String TEMPORARY_DIRECTORY_NAME = "dubbo-mocked-zookeeper";
+    private static final String TEMPORARY_DIRECTORY = "zookeeper";
+
+    /**
+     * The timeout when download zookeeper binary archive file.
+     */
+    private static final int CONNECT_TIMEOUT = 30 * 1000;
+
+    /**
+     * The timeout when read the input stream to save in target path.
+     */
+    private static final int READ_TIMEOUT = 10 * 1000;
+
+    /**
+     * Returns {@code true} if the file exists with the given file path, otherwise {@code false}.
+     *
+     * @param filePath the file path to check.
+     */
+    private boolean checkFile(Path filePath) {
+        return Files.exists(filePath) && filePath.toFile().isFile();
+    }
 
     @Override
     protected void doInitialize(ZookeeperContext context) throws DubboTestException {
+        // checks the zookeeper binary file exists or not
+        if (checkFile(context.getSourceFile())) {
+            return;
+        }
         String zookeeperFileName = String.format(ZOOKEEPER_FILE_NAME_FORMAT, context.getVersion());
+        Path temporaryFilePath;
         try {
-            context.setSourceFile(Paths.get(Files.createTempDirectory("").getParent().toString(),
-                TEMPORARY_DIRECTORY_NAME,
-                zookeeperFileName));
+            temporaryFilePath = Paths.get(Files.createTempDirectory("").getParent().toString(),
+                TEMPORARY_DIRECTORY,
+                zookeeperFileName);
         } catch (IOException e) {
-            throw new RuntimeException(String.format("Cannot create the temporary directory, related directory:%s/%s",
-                TEMPORARY_DIRECTORY_NAME, zookeeperFileName), e);
-        }
-        // check if the zookeeper binary file exists
-        if (context.getSourceFile() != null && context.getSourceFile().toFile().isFile()) {
-            return;
+            throw new RuntimeException(String.format("Cannot create the temporary directory, file path: %s", TEMPORARY_DIRECTORY), e);
         }
+
         // create the temporary directory path.
+        try {
+            Files.createDirectories(temporaryFilePath.getParent());
+        } catch (IOException e) {
+            throw new RuntimeException(String.format("Failed to create the temporary directory to save zookeeper binary file, file path:%s", temporaryFilePath.getParent()), e);
+        }
+
+        // download zookeeper binary file in temporary directory.
+        String zookeeperBinaryUrl = String.format(ZOOKEEPER_BINARY_URL_FORMAT, context.getVersion(), context.getVersion());
+        try {
+            logger.info("It is beginning to download the zookeeper binary archive, it will take several minutes..." +
+                "\nThe zookeeper binary archive file will be download from " + zookeeperBinaryUrl + "," +
+                "\nwhich will be saved in " + temporaryFilePath.toString() + "," +
+                "\nalso it will be renamed to 'apache-zookeeper-bin.tar.gz' and moved into {project.dir}.tmp/zookeeper directory.\n");
+            URL url = new URL(zookeeperBinaryUrl);
+            HttpURLConnection connection = (HttpURLConnection) url.openConnection();
+            // set timeout when download the zookeeper binary archive file.
+            connection.setConnectTimeout(CONNECT_TIMEOUT);
+            // set timeout when read downloaded input stream to save in temporary file path.
+            connection.setReadTimeout(READ_TIMEOUT);
+            connection.setRequestMethod("GET");
+            // use cache first
+            connection.setUseCaches(true);
+            // only read input stream from HttpURLConnection
+            connection.setDoInput(true);
+            connection.connect();
+            InputStream inputStream = connection.getInputStream();
+            Files.copy(inputStream, temporaryFilePath, StandardCopyOption.REPLACE_EXISTING);
+        } catch (Exception e) {
+            throw new RuntimeException(String.format("Download zookeeper binary archive failed, download url:%s, file path:%s." +
+                    "\nOr you can do something to avoid this problem as below:" +
+                    "\n1. Download zookeeper binary archive manually regardless of the version" +
+                    "\n2. Rename the downloaded file named 'apache-zookeeper-{version}-bin.tar.gz' to 'apache-zookeeper-bin.tar.gz'" +
+                    "\n3. Put the renamed file in {project.dir}.tmp/zookeeper directory, you maybe need to create the directory if necessary.\n",

Review comment:
       {project.dir}/.tmp/zookeeper




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5770b6b) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.06%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.64%   -0.07%     
   - Complexity      327      330       +3     
   ============================================
     Files          1206     1206              
     Lines         51844    51894      +50     
     Branches       7716     7720       +4     
   ============================================
   + Hits          33546    33547       +1     
   - Misses        14684    14734      +50     
   + Partials       3614     3613       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | ... and [16 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...5770b6b](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58bf843) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.04%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.65%   -0.05%     
   - Complexity      327      328       +1     
   ============================================
     Files          1206     1206              
     Lines         51844    51886      +42     
     Branches       7716     7720       +4     
   ============================================
   + Hits          33546    33548       +2     
   - Misses        14684    14724      +40     
     Partials       3614     3614              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | ... and [12 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...58bf843](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5770b6b) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.04%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.66%   -0.05%     
   - Complexity      327      330       +3     
   ============================================
     Files          1206     1206              
     Lines         51844    51894      +50     
     Branches       7716     7720       +4     
   ============================================
   + Hits          33546    33556      +10     
   - Misses        14684    14729      +45     
   + Partials       3614     3609       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | ... and [16 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...5770b6b](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9274: fix: Fix the bug of downloading zk binary file

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9274:
URL: https://github.com/apache/dubbo/pull/9274#issuecomment-968510128


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9274](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9db2c81) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a5f77c3566c59883c94ba2df55d949d435d111d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a5f77c3) will **decrease** coverage by `0.08%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9274/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9274      +/-   ##
   ============================================
   - Coverage     64.70%   64.61%   -0.09%     
   - Complexity      327      330       +3     
   ============================================
     Files          1206     1206              
     Lines         51844    51865      +21     
     Branches       7716     7689      -27     
   ============================================
   - Hits          33546    33515      -31     
   - Misses        14684    14734      +50     
   - Partials       3614     3616       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../check/registrycenter/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...check/registrycenter/context/ZookeeperContext.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2NvbnRleHQvWm9va2VlcGVyQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/ConfigZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0NvbmZpZ1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...nter/initializer/DownloadZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL0Rvd25sb2FkWm9va2VlcGVySW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...center/initializer/UnpackZookeeperInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL2luaXRpYWxpemVyL1VucGFja1pvb2tlZXBlckluaXRpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ycenter/processor/StartZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlclVuaXhQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nter/processor/StartZookeeperWindowsProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdGFydFpvb2tlZXBlcldpbmRvd3NQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rycenter/processor/StopZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9TdG9wWm9va2VlcGVyVW5peFByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gistrycenter/processor/ZookeeperUnixProcessor.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWNoZWNrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby90ZXN0L2NoZWNrL3JlZ2lzdHJ5Y2VudGVyL3Byb2Nlc3Nvci9ab29rZWVwZXJVbml4UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../remoting/api/SingleProtocolConnectionManager.java](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvU2luZ2xlUHJvdG9jb2xDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `61.53% <0.00%> (-23.08%)` | :arrow_down: |
   | ... and [40 more](https://codecov.io/gh/apache/dubbo/pull/9274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a5f77c3...9db2c81](https://codecov.io/gh/apache/dubbo/pull/9274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org