You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by sm...@apache.org on 2007/05/07 05:45:24 UTC
svn commit: r535728 - /harmony/enhanced/trunk/build.xml
Author: smishura
Date: Sun May 6 20:45:23 2007
New Revision: 535728
URL: http://svn.apache.org/viewvc?view=rev&rev=535728
Log:
Add 'fetch-depends' for build_jdktools target
Modified:
harmony/enhanced/trunk/build.xml
Modified: harmony/enhanced/trunk/build.xml
URL: http://svn.apache.org/viewvc/harmony/enhanced/trunk/build.xml?view=diff&rev=535728&r1=535727&r2=535728
==============================================================================
--- harmony/enhanced/trunk/build.xml (original)
+++ harmony/enhanced/trunk/build.xml Sun May 6 20:45:23 2007
@@ -393,6 +393,9 @@
<!-- build the common resources - ensure depends are up to date an then rebuild -->
<!-- ================================================================================ -->
<target name="build_jdktools">
+ <ant antfile="working_jdktools/build.xml" target="fetch-depends" inheritall="false" >
+ <property name="hy.cfg" value="${hy.cfg}"/>
+ </ant>
<ant antfile="working_jdktools/build.xml" target="rebuild" inheritall="false" >
<property name="hy.cfg" value="${hy.cfg}"/>
</ant>
Re: svn commit: r535728 - /harmony/enhanced/trunk/build.xml
Posted by Stepan Mishura <st...@gmail.com>.
On 5/10/07, Stepan Mishura wrote:
> On 5/8/07, Tim Ellison wrote:
> > Stepan,
> >
> > The 'fetch-depends' has to stay as a separate target invoked explicitly
> > by the user. It can't be part of the default action. That is where we
> > may download code whose licenses falls under the binary-only category
> > (like ECJ) as described here [1]. Of course, we can continue to check
> > for the existence of the dependencies by default.
> >
>
> Tim, thanks for the note. Actually, I fixed it by analogy with
> classlibrary and drlvm (for example, see build_classlib target) - the
> federated build fetches theirs dependencies automatically. Yes,
> according to [1] we have to fix the federated build ... and CC scripts
> too (currently CC fetches dependencies automatically by defualt.)
>
> I think we should add to builds new option, say 'fetch-automatically'
> (it is set to 'false' by default.). And the option should be added to
> classlib, drlvm and jdktools builds.
I've removed external code downloading as default action. And
'auto.fetch' option was added to federated build to make it possible
to automate downloading.
Thanks
Stepan.
Re: svn commit: r535728 - /harmony/enhanced/trunk/build.xml
Posted by Stepan Mishura <st...@gmail.com>.
On 5/8/07, Tim Ellison wrote:
> Stepan,
>
> The 'fetch-depends' has to stay as a separate target invoked explicitly
> by the user. It can't be part of the default action. That is where we
> may download code whose licenses falls under the binary-only category
> (like ECJ) as described here [1]. Of course, we can continue to check
> for the existence of the dependencies by default.
>
Tim, thanks for the note. Actually, I fixed it by analogy with
classlibrary and drlvm (for example, see build_classlib target) - the
federated build fetches theirs dependencies automatically. Yes,
according to [1] we have to fix the federated build ... and CC scripts
too (currently CC fetches dependencies automatically by defualt.)
I think we should add to builds new option, say 'fetch-automatically'
(it is set to 'false' by default.). And the option should be added to
classlib, drlvm and jdktools builds.
Thanks,
Stepan.
[1] http://people.apache.org/~cliffs/3party.html
>
> Regards,
> Tim
>
>
> smishura@apache.org wrote:
> > Author: smishura
> > Date: Sun May 6 20:45:23 2007
> > New Revision: 535728
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=535728
> > Log:
> > Add 'fetch-depends' for build_jdktools target
> >
> > Modified:
> > harmony/enhanced/trunk/build.xml
> >
> > Modified: harmony/enhanced/trunk/build.xml
> > URL: http://svn.apache.org/viewvc/harmony/enhanced/trunk/build.xml?view=diff&rev=535728&r1=535727&r2=535728
> > ==============================================================================
> > --- harmony/enhanced/trunk/build.xml (original)
> > +++ harmony/enhanced/trunk/build.xml Sun May 6 20:45:23 2007
> > @@ -393,6 +393,9 @@
> > <!-- build the common resources - ensure depends are up to date an then rebuild -->
> > <!-- ================================================================================ -->
> > <target name="build_jdktools">
> > + <ant antfile="working_jdktools/build.xml" target="fetch-depends" inheritall="false" >
> > + <property name="hy.cfg" value="${hy.cfg}"/>
> > + </ant>
> > <ant antfile="working_jdktools/build.xml" target="rebuild" inheritall="false" >
> > <property name="hy.cfg" value="${hy.cfg}"/>
> > </ant>
> >
> >
> >
>
Re: svn commit: r535728 - /harmony/enhanced/trunk/build.xml
Posted by Tim Ellison <t....@gmail.com>.
Stepan,
The 'fetch-depends' has to stay as a separate target invoked explicitly
by the user. It can't be part of the default action. That is where we
may download code whose licenses falls under the binary-only category
(like ECJ) as described here [1]. Of course, we can continue to check
for the existence of the dependencies by default.
[1] http://people.apache.org/~cliffs/3party.html
Regards,
Tim
smishura@apache.org wrote:
> Author: smishura
> Date: Sun May 6 20:45:23 2007
> New Revision: 535728
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=535728
> Log:
> Add 'fetch-depends' for build_jdktools target
>
> Modified:
> harmony/enhanced/trunk/build.xml
>
> Modified: harmony/enhanced/trunk/build.xml
> URL: http://svn.apache.org/viewvc/harmony/enhanced/trunk/build.xml?view=diff&rev=535728&r1=535727&r2=535728
> ==============================================================================
> --- harmony/enhanced/trunk/build.xml (original)
> +++ harmony/enhanced/trunk/build.xml Sun May 6 20:45:23 2007
> @@ -393,6 +393,9 @@
> <!-- build the common resources - ensure depends are up to date an then rebuild -->
> <!-- ================================================================================ -->
> <target name="build_jdktools">
> + <ant antfile="working_jdktools/build.xml" target="fetch-depends" inheritall="false" >
> + <property name="hy.cfg" value="${hy.cfg}"/>
> + </ant>
> <ant antfile="working_jdktools/build.xml" target="rebuild" inheritall="false" >
> <property name="hy.cfg" value="${hy.cfg}"/>
> </ant>
>
>
>