You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/03 13:20:21 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #10078: MINOR: Some tests in clients module does not cover all available versions

chia7712 commented on a change in pull request #10078:
URL: https://github.com/apache/kafka/pull/10078#discussion_r586408680



##########
File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
##########
@@ -201,7 +201,7 @@ public short oldestVersion() {
 
     public List<Short> allVersions() {
         List<Short> versions = new ArrayList<>(latestVersion() - oldestVersion() + 1);
-        for (short version = oldestVersion(); version < latestVersion(); version++) {
+        for (short version = oldestVersion(); version <= latestVersion(); version++) {

Review comment:
       This is not a critical bug as the method `allVersions` is used by testing only.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org