You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/03/08 15:56:31 UTC
Review Request 57422: Removed misleading comment from protobuf file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57422/
-----------------------------------------------------------
Review request for mesos, Joseph Wu and Zameer Manji.
Repository: mesos
Description
-------
Removed misleading comment from protobuf file.
Diffs
-----
include/mesos/mesos.proto 030e79c003f6560e9c0627db12fb1baba411151d
include/mesos/v1/mesos.proto 7f6f858a7d9387d202510730d400e490298e6574
Diff: https://reviews.apache.org/r/57422/diff/1/
Testing
-------
No functional change.
Thanks,
Neil Conway
Re: Review Request 57422: Removed misleading comment from protobuf
file.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57422/#review168319
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On March 8, 2017, 7:56 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57422/
> -----------------------------------------------------------
>
> (Updated March 8, 2017, 7:56 a.m.)
>
>
> Review request for mesos, Joseph Wu and Zameer Manji.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed misleading comment from protobuf file.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 030e79c003f6560e9c0627db12fb1baba411151d
> include/mesos/v1/mesos.proto 7f6f858a7d9387d202510730d400e490298e6574
>
>
> Diff: https://reviews.apache.org/r/57422/diff/1/
>
>
> Testing
> -------
>
> No functional change.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 57422: Removed misleading comment from protobuf
file.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57422/#review168349
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On March 8, 2017, 7:56 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57422/
> -----------------------------------------------------------
>
> (Updated March 8, 2017, 7:56 a.m.)
>
>
> Review request for mesos, Joseph Wu and Zameer Manji.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed misleading comment from protobuf file.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 030e79c003f6560e9c0627db12fb1baba411151d
> include/mesos/v1/mesos.proto 7f6f858a7d9387d202510730d400e490298e6574
>
>
> Diff: https://reviews.apache.org/r/57422/diff/1/
>
>
> Testing
> -------
>
> No functional change.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 57422: Removed misleading comment from protobuf
file.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57422/#review168306
-----------------------------------------------------------
Ship it!
Ship It!
- Gast�n Kleiman
On March 8, 2017, 3:56 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57422/
> -----------------------------------------------------------
>
> (Updated March 8, 2017, 3:56 p.m.)
>
>
> Review request for mesos, Joseph Wu and Zameer Manji.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed misleading comment from protobuf file.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 030e79c003f6560e9c0627db12fb1baba411151d
> include/mesos/v1/mesos.proto 7f6f858a7d9387d202510730d400e490298e6574
>
>
> Diff: https://reviews.apache.org/r/57422/diff/1/
>
>
> Testing
> -------
>
> No functional change.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 57422: Removed misleading comment from protobuf
file.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57422/#review168303
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On March 8, 2017, 3:56 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57422/
> -----------------------------------------------------------
>
> (Updated March 8, 2017, 3:56 p.m.)
>
>
> Review request for mesos, Joseph Wu and Zameer Manji.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed misleading comment from protobuf file.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 030e79c003f6560e9c0627db12fb1baba411151d
> include/mesos/v1/mesos.proto 7f6f858a7d9387d202510730d400e490298e6574
>
>
> Diff: https://reviews.apache.org/r/57422/diff/1/
>
>
> Testing
> -------
>
> No functional change.
>
>
> Thanks,
>
> Neil Conway
>
>