You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/15 10:42:05 UTC
[GitHub] [shardingsphere] TeslaCN opened a new pull request, #21005: Avoid overhead of creating an unused exception
TeslaCN opened a new pull request, #21005:
URL: https://github.com/apache/shardingsphere/pull/21005
Related to #20036.
![](https://user-images.githubusercontent.com/20503072/190370254-f7613870-fb4b-4401-a69e-ec863142f7fb.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21005: Refactor ShardingSpherePreconditions.checkState
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21005:
URL: https://github.com/apache/shardingsphere/pull/21005#issuecomment-1248048096
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21005?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21005](https://codecov.io/gh/apache/shardingsphere/pull/21005?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5f4bc1) into [master](https://codecov.io/gh/apache/shardingsphere/commit/84245e84b38146e20e49e474069cf4da27401f9b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84245e8) will **decrease** coverage by `0.03%`.
> The diff coverage is `19.04%`.
```diff
@@ Coverage Diff @@
## master #21005 +/- ##
============================================
- Coverage 61.75% 61.71% -0.04%
- Complexity 2467 2468 +1
============================================
Files 4050 4050
Lines 55560 55567 +7
Branches 9413 9411 -2
============================================
- Hits 34309 34294 -15
- Misses 18376 18398 +22
Partials 2875 2875
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21005?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...bind/protocol/PostgreSQLArrayParameterDecoder.java](https://codecov.io/gh/apache/shardingsphere/pull/21005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS9leHRlbmRlZC9iaW5kL3Byb3RvY29sL1Bvc3RncmVTUUxBcnJheVBhcmFtZXRlckRlY29kZXIuamF2YQ==) | `84.21% <0.00%> (ø)` | |
| [...pe/MGRMySQLDatabaseDiscoveryProviderAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/21005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1wcm92aWRlci9zaGFyZGluZ3NwaGVyZS1kYi1kaXNjb3ZlcnktbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L215c3FsL3R5cGUvTUdSTXlTUUxEYXRhYmFzZURpc2NvdmVyeVByb3ZpZGVyQWxnb3JpdGhtLmphdmE=) | `67.64% <0.00%> (-1.48%)` | :arrow_down: |
| [...arding/complex/ComplexInlineShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/21005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvYWxnb3JpdGhtL3NoYXJkaW5nL2NvbXBsZXgvQ29tcGxleElubGluZVNoYXJkaW5nQWxnb3JpdGhtLmphdmE=) | `92.00% <0.00%> (-2.00%)` | :arrow_down: |
| [...rithm/sharding/inline/InlineShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/21005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvYWxnb3JpdGhtL3NoYXJkaW5nL2lubGluZS9JbmxpbmVTaGFyZGluZ0FsZ29yaXRobS5qYXZh) | `88.00% <0.00%> (-4.00%)` | :arrow_down: |
| [...dler/update/AddMigrationSourceResourceUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/21005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21pZ3JhdGlvbi9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0FkZE1pZ3JhdGlvblNvdXJjZVJlc291cmNlVXBkYXRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...a/database/type/dialect/OpenGaussDatabaseType.java](https://codecov.io/gh/apache/shardingsphere/pull/21005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhYmFzZS90eXBlL2RpYWxlY3QvT3BlbkdhdXNzRGF0YWJhc2VUeXBlLmphdmE=) | `50.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...atasource/props/DataSourcePropertiesValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/21005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Byb3BzL0RhdGFTb3VyY2VQcm9wZXJ0aWVzVmFsaWRhdG9yLmphdmE=) | `87.50% <ø> (ø)` | |
| [...here/driver/jdbc/core/ShardingSphereSavepoint.java](https://codecov.io/gh/apache/shardingsphere/pull/21005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvU2hhcmRpbmdTcGhlcmVTYXZlcG9pbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...jdbc/core/connection/ShardingSphereConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/21005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvY29ubmVjdGlvbi9TaGFyZGluZ1NwaGVyZUNvbm5lY3Rpb24uamF2YQ==) | `75.00% <0.00%> (ø)` | |
| [...r/jdbc/core/resultset/ShardingSphereResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/21005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvcmVzdWx0c2V0L1NoYXJkaW5nU3BoZXJlUmVzdWx0U2V0LmphdmE=) | `96.20% <0.00%> (ø)` | |
| ... and [35 more](https://codecov.io/gh/apache/shardingsphere/pull/21005/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #21005: Refactor ShardingSpherePreconditions.checkState
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #21005:
URL: https://github.com/apache/shardingsphere/pull/21005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org