You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2016/05/03 06:52:28 UTC

Review Request 46926: GEODE-1260: Cache SCM metadata for source distributions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46926/
-----------------------------------------------------------

Review request for geode, Dick Cavender, Mark Bretl, and Dan Smith.


Repository: geode


Description
-------

The GemFireVersion.properties file is generated by the build and
contains the git branch, commit, and source date. This change
caches the SCM info in the build root (.buildinfo) for use by the
source distribution.


Diffs
-----

  geode-assembly/build.gradle e786b24b978c507905b36032f994158addde73e8 
  geode-core/build.gradle 45051dc771452bf06ba6708efd8e1361791e13e8 
  gradle/rat.gradle f35b157d510fd4ee6b3124de8ae94e30d3cd86c7 

Diff: https://reviews.apache.org/r/46926/diff/


Testing
-------


Thanks,

Anthony Baker

Re: Review Request 46926: GEODE-1260: Cache SCM metadata for source distributions

Posted by Anthony Baker <ab...@apache.org>.


> On May 4, 2016, 12:42 a.m., Dick Cavender wrote:
> > I assume we can still dump the GemFireVersion.properties by running gfsh version --full?

Sure.  In fact, with this change someone who build geode from the source distribution will get the actual version instead of UNKNOWN.  Shouldn't affect the binary distribution at all.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46926/#review131599
-----------------------------------------------------------


On May 3, 2016, 4:52 a.m., Anthony Baker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46926/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 4:52 a.m.)
> 
> 
> Review request for geode, Dick Cavender, Mark Bretl, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The GemFireVersion.properties file is generated by the build and
> contains the git branch, commit, and source date. This change
> caches the SCM info in the build root (.buildinfo) for use by the
> source distribution.
> 
> 
> Diffs
> -----
> 
>   geode-assembly/build.gradle e786b24b978c507905b36032f994158addde73e8 
>   geode-core/build.gradle 45051dc771452bf06ba6708efd8e1361791e13e8 
>   gradle/rat.gradle f35b157d510fd4ee6b3124de8ae94e30d3cd86c7 
> 
> Diff: https://reviews.apache.org/r/46926/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Baker
> 
>

Re: Review Request 46926: GEODE-1260: Cache SCM metadata for source distributions

Posted by Dick Cavender <dc...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46926/#review131599
-----------------------------------------------------------


Ship it!




I assume we can still dump the GemFireVersion.properties by running gfsh version --full?

- Dick Cavender


On May 3, 2016, 4:52 a.m., Anthony Baker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46926/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 4:52 a.m.)
> 
> 
> Review request for geode, Dick Cavender, Mark Bretl, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The GemFireVersion.properties file is generated by the build and
> contains the git branch, commit, and source date. This change
> caches the SCM info in the build root (.buildinfo) for use by the
> source distribution.
> 
> 
> Diffs
> -----
> 
>   geode-assembly/build.gradle e786b24b978c507905b36032f994158addde73e8 
>   geode-core/build.gradle 45051dc771452bf06ba6708efd8e1361791e13e8 
>   gradle/rat.gradle f35b157d510fd4ee6b3124de8ae94e30d3cd86c7 
> 
> Diff: https://reviews.apache.org/r/46926/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Baker
> 
>

Re: Review Request 46926: GEODE-1260: Cache SCM metadata for source distributions

Posted by Anthony Baker <ab...@apache.org>.


> On May 4, 2016, 12:30 a.m., Dan Smith wrote:
> > geode-core/build.gradle, line 155
> > <https://reviews.apache.org/r/46926/diff/1/?file=1369606#file1369606line155>
> >
> >     Should we catch a more specific exception here? Otherwise if this readSCMInfo code breaks we might never know.

The exception thrown is `java.lang.IllegalArgumentException: One of setGitDir or setWorkTree must be called.`

I'll narrow the catch.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46926/#review131595
-----------------------------------------------------------


On May 3, 2016, 4:52 a.m., Anthony Baker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46926/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 4:52 a.m.)
> 
> 
> Review request for geode, Dick Cavender, Mark Bretl, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The GemFireVersion.properties file is generated by the build and
> contains the git branch, commit, and source date. This change
> caches the SCM info in the build root (.buildinfo) for use by the
> source distribution.
> 
> 
> Diffs
> -----
> 
>   geode-assembly/build.gradle e786b24b978c507905b36032f994158addde73e8 
>   geode-core/build.gradle 45051dc771452bf06ba6708efd8e1361791e13e8 
>   gradle/rat.gradle f35b157d510fd4ee6b3124de8ae94e30d3cd86c7 
> 
> Diff: https://reviews.apache.org/r/46926/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Baker
> 
>

Re: Review Request 46926: GEODE-1260: Cache SCM metadata for source distributions

Posted by Dan Smith <ds...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46926/#review131595
-----------------------------------------------------------


Fix it, then Ship it!





geode-core/build.gradle (line 147)
<https://reviews.apache.org/r/46926/#comment195609>

    Should we catch a more specific exception here? Otherwise if this readSCMInfo code breaks we might never know.


- Dan Smith


On May 3, 2016, 4:52 a.m., Anthony Baker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46926/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 4:52 a.m.)
> 
> 
> Review request for geode, Dick Cavender, Mark Bretl, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The GemFireVersion.properties file is generated by the build and
> contains the git branch, commit, and source date. This change
> caches the SCM info in the build root (.buildinfo) for use by the
> source distribution.
> 
> 
> Diffs
> -----
> 
>   geode-assembly/build.gradle e786b24b978c507905b36032f994158addde73e8 
>   geode-core/build.gradle 45051dc771452bf06ba6708efd8e1361791e13e8 
>   gradle/rat.gradle f35b157d510fd4ee6b3124de8ae94e30d3cd86c7 
> 
> Diff: https://reviews.apache.org/r/46926/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Baker
> 
>