You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Daniel Sun (Jira)" <ji...@apache.org> on 2019/09/11 05:08:00 UTC
[jira] [Resolved] (GROOVY-9236) Avoid unnecessary resolving
[ https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Sun resolved GROOVY-9236.
--------------------------------
Resolution: Fixed
Fixed by https://github.com/apache/groovy/commit/fbc442da25335ebcb8f61623cd4a89f551c86331
> Avoid unnecessary resolving
> ---------------------------
>
> Key: GROOVY-9236
> URL: https://issues.apache.org/jira/browse/GROOVY-9236
> Project: Groovy
> Issue Type: Improvement
> Reporter: Daniel Sun
> Assignee: Daniel Sun
> Priority: Major
> Fix For: 3.0.0-beta-4
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> {{ResolveVisitor}}'s {{resolveFromStaticInnerClasses}}, {{resolveFromDefaultImports}} and {{resolveNestedClass}} will try to guess class qualified name and load. In the process of resolving, lots of time wasted on finding non-existing classes. So we should try to resolve classes in a determined manner.
> For example,
> For {{java.util.stream.Collectors}}, ① {{resolveFromStaticInnerClasses}} will try to guess {{java.util.stream$Collectors}}, {{java.util$stream$Collectors}}, {{java$util$stream$Collectors}}.
> And ② {{resolveFromDefaultImports}} will guess {{java.lang.java$util$stream$Collectors}}, {{java.util.java$util$stream$Collectors}}, ..., {{groovy.lang.java$util$stream$Collectors}}.
> After the precedence of resolving adjusted, the above unnecessary resolving can be avoided.
> See the discussion in the dev mailing list: http://groovy.329449.n5.nabble.com/Performance-of-the-compiler-tt5750989.html
> and its attachment: http://groovy.329449.n5.nabble.com/attachment/5750989/0/CPU-hot-spots.txt
--
This message was sent by Atlassian Jira
(v8.3.2#803003)