You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "gunli (via GitHub)" <gi...@apache.org> on 2023/11/01 02:25:20 UTC

Re: [PR] [INLONG-9172][SDK] Delete useless debug logs in Golang SDK [inlong]

gunli commented on code in PR #9173:
URL: https://github.com/apache/inlong/pull/9173#discussion_r1378330842


##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/dataproxy/worker.go:
##########
@@ -500,9 +500,9 @@ func (w *worker) handleRetry(batch *batchReq, retryOnFail bool) {
 }
 
 func (w *worker) handleBatchTimeout() {
-	for streamID, batch := range w.pendingBatches {
+	for _, batch := range w.pendingBatches {
 		if time.Since(batch.batchTime) > w.options.BatchingMaxPublishDelay {
-			w.log.Debug("worker[", w.index, "] batch timeout, send it now:", batch.batchID, ", streamID:", streamID)
+			//w.log.Debug("worker[", w.index, "] batch timeout, send it now:", batch.batchID, ", streamID:", streamID)

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org