You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/09/08 15:44:50 UTC
Review Request 25438: Add rca properties to log4j.properties from
Download Configs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25438/
-----------------------------------------------------------
Review request for Ambari and Dmytro Sen.
Bugs: AMBARI-7197
https://issues.apache.org/jira/browse/AMBARI-7197
Repository: ambari
Description
-------
After commiting We have to add the change on client download configurations as
well.
1\. We have to override generate_configs method in HDFS and MAPREDUCE scripts,
to handle the situation correctly
2\. Refactor Script #generate_configs to support usecases with editing
contents like this, without code duplicating the parent class.
3\. Move rca_content to hadoop-env to avoid duplication
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py 80bfeab
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py e68f7c4
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_client.py 8e3fc5d
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py e1a8b8f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-env.xml 95d853f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/client.py 8b98fe2
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py ddcb48b
ambari-server/src/test/python/stacks/1.3.2/HDFS/test_hdfs_client.py PRE-CREATION
ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_client.py cb88efa
ambari-server/src/test/python/stacks/1.3.2/configs/default.json 4a42faa
Diff: https://reviews.apache.org/r/25438/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 25438: Add rca properties to log4j.properties from
Download Configs.
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25438/#review52593
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Сен. 8, 2014, 1:44 п.п., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25438/
> -----------------------------------------------------------
>
> (Updated Сен. 8, 2014, 1:44 п.п.)
>
>
> Review request for Ambari and Dmytro Sen.
>
>
> Bugs: AMBARI-7197
> https://issues.apache.org/jira/browse/AMBARI-7197
>
>
> Repository: ambari
>
>
> Description
> -------
>
> After commiting We have to add the change on client download configurations as
> well.
>
> 1\. We have to override generate_configs method in HDFS and MAPREDUCE scripts,
> to handle the situation correctly
> 2\. Refactor Script #generate_configs to support usecases with editing
> contents like this, without code duplicating the parent class.
> 3\. Move rca_content to hadoop-env to avoid duplication
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/script/script.py 80bfeab
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py e68f7c4
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_client.py 8e3fc5d
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py e1a8b8f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-env.xml 95d853f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/client.py 8b98fe2
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py ddcb48b
> ambari-server/src/test/python/stacks/1.3.2/HDFS/test_hdfs_client.py PRE-CREATION
> ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_client.py cb88efa
> ambari-server/src/test/python/stacks/1.3.2/configs/default.json 4a42faa
>
> Diff: https://reviews.apache.org/r/25438/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>