[GitHub] zhengruifeng commented on a change in pull request #23818: [SPARK-19591][ML][PYSPARK][FOLLOWUP] Add sample weights to decision trees

[GitBox <gi...@apache.org>]

zhengruifeng commented on a change in pull request #23818: [SPARK-19591][ML][PYSPARK][FOLLOWUP] Add sample weights to decision trees
URL: https://github.com/apache/spark/pull/23818#discussion_r260669765
 
 

 ##########
 File path: python/pyspark/ml/regression.py
 ##########
 @@ -791,19 +792,34 @@ class DecisionTreeRegressor(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredi
     >>> model.transform(test1).head().variance
     0.0
 
+    >>> df3 = spark.createDataFrame([
 
 Review comment:
   There already exists an example without weights. In the PR, I added examples with weights.
   I think it is fine to keep those both. And I am OK to remove some info printed in the added ones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org