[GitHub] Wei-1 commented on a change in pull request #13619: [MXNET-1231] Allow not using Some in the Scala operators

[GitBox <gi...@apache.org>]

Wei-1 commented on a change in pull request #13619: [MXNET-1231] Allow not using Some in the Scala operators
URL: https://github.com/apache/incubator-mxnet/pull/13619#discussion_r240935999
 
 

 ##########
 File path: scala-package/macros/src/main/scala/org/apache/mxnet/utils/CToScalaUtils.scala
 ##########
 @@ -18,23 +18,26 @@ package org.apache.mxnet.utils
 
 private[mxnet] object CToScalaUtils {
 
-
+  private val javaType = Array("java.lang.Float", "java.lang.Integer",
 
 Review comment:
   I wonder if it will be clearer if we use a map instead of an array?
   so we can have:
   ```scala
   types("int")
   ```
   instead of
   ```scala
   types(1)
   ```
   Just an idea anyway

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services