You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/26 22:17:00 UTC

[jira] [Commented] (SAMZA-2002) Instrument Rest of Operators (except Join) and Query

    [ https://issues.apache.org/jira/browse/SAMZA-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699636#comment-16699636 ] 

ASF GitHub Bot commented on SAMZA-2002:
---------------------------------------

GitHub user shenodaguirguis opened a pull request:

    https://github.com/apache/samza/pull/814

    SAMZA-2002 SamzaSQL Diagnostics: instrument rest of operators (except join) and at Query level

    After instrumenting Project operator in Samza-1997, this PR instruments the rest of operators, except for Join. It also instrument the Query Level to add its metrics. Latency measured at query level is actually the time span of the message/event since when it is arrived to end of processing. This skips the pre-arrival network latency, which we are considering adding later, whenever feasible. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shenodaguirguis/samza addmetrics

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/814.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #814
    
----
commit 6d6bd0579a6f9beb4f22afb171d85c199fa10e61
Author: Shenoda Guirguis <sg...@...>
Date:   2018-11-15T19:59:32Z

    SAMZA-1997 - Samza-sql Diagnostics - Instrument Project operator

commit 18fd27d61e412377b7227c30460730489d84a416
Author: Shenoda Guirguis <sg...@...>
Date:   2018-11-15T19:59:32Z

    SAMZA-1997 - Samza-sql Diagnostics - Instrument Project operator

commit de49279e1cd6b1055dcb39d97b1e1d6d63999b1f
Author: Shenoda Guirguis <sg...@...>
Date:   2018-11-15T19:59:32Z

    SAMZA-1997 - Samza-sql Diagnostics - Instrument Project operator

commit 5a3feb658e0556c383275f9fb6c975af04d4a892
Author: Shenoda Guirguis <sg...@...>
Date:   2018-11-15T19:59:32Z

    SAMZA-1997 - Samza-sql Diagnostics - Instrument Project operator

commit 95eee741df307016488d4a8cb0c8de47149daedd
Author: Shenoda Guirguis <sg...@...>
Date:   2018-11-19T17:20:15Z

    SAMZA-2002 Add metrics to all operators (except Join) and at Query Level

----


> Instrument Rest of Operators (except Join) and Query 
> -----------------------------------------------------
>
>                 Key: SAMZA-2002
>                 URL: https://issues.apache.org/jira/browse/SAMZA-2002
>             Project: Samza
>          Issue Type: Sub-task
>            Reporter: Shenoda Guirguis
>            Priority: Major
>
> Continue adding metrics to rest of Operators, except Join, and also add the Query level metrics



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)