[GitHub] [skywalking] dmsolr commented on a change in pull request #4677: [test/plugin] Enhance PluginTest

[GitBox <gi...@apache.org>]

dmsolr commented on a change in pull request #4677:
URL: https://github.com/apache/skywalking/pull/4677#discussion_r412948965



##########
File path: .github/workflows/plugins-test.0.yaml
##########
@@ -48,9 +48,9 @@ jobs:
           - { name: 'elasticsearch-6.x-scenario', title: 'ElasticSearch 6.7.1-6.8.4 (7)' }
           - { name: 'elasticsearch-7.x-scenario', title: 'ElasticSearch 7.0.0-7.5.2 (14)' }
           - { name: 'feign-scenario', title: 'Feign 9.0.0-9.5.1 (8)' }
-          - { name: 'finagle-17.10.x-scenario', title: 'Finagle 17.10.0-20.1.0' }
-          - { name: 'finagle-6.25.x-scenario', title: 'Finagle 6.25.0-6.43.0' }
-          - { name: 'finagle-6.44.x-scenario', title: 'Finagle 6.44.0-7.1.0' }
+          - { name: 'finagle-17.10.x-scenario', title: 'Finagle 17.10.0-20.1.0(19)' }
+          - { name: 'finagle-6.25.x-scenario', title: 'Finagle 6.25.0-6.43.0 (18)' }
+          - { name: 'finagle-6.44.x-scenario', title: 'Finagle 6.44.0-7.1.0 (4)' }

Review comment:
       1. I agree with it is hard to maintain the number of versions. And now, I still cannot sure they are correct in all.
   2. Make every group have the same number of versions as far as possible. It is necessary. If not, we don't need to split them into multi groups. At least, the adjustment is harmless.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org