[GitHub] [airflow] rolanddb commented on a change in pull request #5915: [AIRFLOW-5312] Fix timeout issue in pod launcher / KubernetesPodOperator

[GitBox <gi...@apache.org>]

rolanddb commented on a change in pull request #5915: [AIRFLOW-5312] Fix timeout issue in pod launcher / KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/5915#discussion_r319213205
 
 

 ##########
 File path: airflow/contrib/kubernetes/pod_launcher.py
 ##########
 @@ -96,9 +98,14 @@ def run_pod(self, pod, startup_timeout=120, get_logs=True):
 
         return self._monitor_pod(pod, get_logs)
 
+    @tenacity.retry(
 
 Review comment:
   The other methods have retries with `stop_after_attempt(3)`. This is not sufficient for long running tasks, because during periods of unstable network conditions they have a high probability of encountering more than 3 timeouts.
   
   Would it be better to remove this retry and remove the stop condition on the other methods?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services