You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Martin Hesse (Jira)" <ji...@apache.org> on 2021/04/20 04:46:00 UTC

[jira] [Updated] (ISIS-2619) TenantedAuthorizationFacetFactory should not use Mixin Class to filter evaluators

     [ https://issues.apache.org/jira/browse/ISIS-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Hesse updated ISIS-2619:
-------------------------------
    Description: 
{{InteractionUtils.isUsableResult(FacetHolder, UsabilityContext)}} is being called for facetHolders of type {{ObjectActionMixedIn}}, but these are missing a facet of type {{TenantedAuthorizationFacetDefault}}

{{In the }}{{TenantedAuthorizationFacetFactory t}}{{he }}{{applicationTenancyEvaluator.handles}}{{ method is being called with the Mixin Class and returns false. Instead it should be called with the type towards which the Mixin is contributing}}

{{[https://github.com/apache/isis/blob/53e535fd08e9dae4580fb8de7179b10620c14a69/extensions/security/secman/model/src/main/java/org/apache/isis/extensions/secman/model/facets/TenantedAuthorizationFacetFactory.java#L96]}}

{{}}

  was:
{{InteractionUtils.isUsableResult(FacetHolder, UsabilityContext)}} is being called for facetHolders of type {{ObjectActionMixedIn}}, but these are missing a facet of type {{TenantedAuthorizationFacetDefault}}

{{the bug is in the }}{{TenantedAuthorizationFacetFactory}}{{, essentially the }}{{applicationTenancyEvaluator.handles}}{{  method is being called with the Mixin Class and returns false. Instead I think it should be called with the type of the FacetHolder}}

{{https://github.com/apache/isis/blob/53e535fd08e9dae4580fb8de7179b10620c14a69/extensions/security/secman/model/src/main/java/org/apache/isis/extensions/secman/model/facets/TenantedAuthorizationFacetFactory.java#L96}}

{{}}


> TenantedAuthorizationFacetFactory should not use Mixin Class to filter evaluators
> ---------------------------------------------------------------------------------
>
>                 Key: ISIS-2619
>                 URL: https://issues.apache.org/jira/browse/ISIS-2619
>             Project: Isis
>          Issue Type: Bug
>          Components: Isis Extensions SecMan
>    Affects Versions: 2.0.0-M5
>            Reporter: Martin Hesse
>            Priority: Major
>
> {{InteractionUtils.isUsableResult(FacetHolder, UsabilityContext)}} is being called for facetHolders of type {{ObjectActionMixedIn}}, but these are missing a facet of type {{TenantedAuthorizationFacetDefault}}
> {{In the }}{{TenantedAuthorizationFacetFactory t}}{{he }}{{applicationTenancyEvaluator.handles}}{{ method is being called with the Mixin Class and returns false. Instead it should be called with the type towards which the Mixin is contributing}}
> {{[https://github.com/apache/isis/blob/53e535fd08e9dae4580fb8de7179b10620c14a69/extensions/security/secman/model/src/main/java/org/apache/isis/extensions/secman/model/facets/TenantedAuthorizationFacetFactory.java#L96]}}
> {{}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)