[jira] [Comment Edited] (FLINK-11066) Migrate main Table API classes to flink-table-api-base

["Hequn Cheng (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718741#comment-16718741 ] 

Hequn Cheng edited comment on FLINK-11066 at 12/12/18 10:22 AM:
----------------------------------------------------------------

Hi [~twalthr] , as for {{AppendStreamTableSink}} and {{BatchTableSink}}, should I port them into `flink-table-api-base` or `flink-table-spi`? The classes introduce dependencies on `DataStream`(module flink-streaming-java) and `DataSet`(module flink-java). 


was (Author: hequn8128):
Hi [~twalthr] , as for {{AppendStreamTableSink}} and {{BatchTableSink}}, should I port it into `flink-table-api-base` or `flink-table-spi`? The class introduces dependencies on `DataStream`(module flink-streaming-java) and `DataSet`(module flink-java). 

> Migrate main Table API classes to flink-table-api-base
> ------------------------------------------------------
>
>                 Key: FLINK-11066
>                 URL: https://issues.apache.org/jira/browse/FLINK-11066
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Priority: Major
>
> This issue covers the forth step of the migration plan mentioned in [FLIP-28|https://cwiki.apache.org/confluence/display/FLINK/FLIP-28%3A+Long-term+goal+of+making+flink-table+Scala-free].
> The most important API classes such as TableEnvironments and Table are exposing a lot of protected methods in Java. Migrating those classes makes the API clean and the implementation ready for a major refactoring for the new catalog support. We can also think about a separation of interface and implementation; e.g. {{Table}} & {{TableImpl}}. However, the current API design makes this difficult as we are using constructors of interfaces {{new Table(...)}}.
> This issue tracks efforts of porting API classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)