You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/03 06:31:36 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #8404: KAFKA-10787: Introduce an import order in Java sources

chia7712 commented on a change in pull request #8404:
URL: https://github.com/apache/kafka/pull/8404#discussion_r534731833



##########
File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##########
@@ -16,21 +16,21 @@
  */
 package org.apache.kafka.clients;
 
-import java.util.HashSet;
-import java.util.Set;
-
-import java.util.stream.Collectors;
 import org.apache.kafka.common.errors.AuthenticationException;
 import org.apache.kafka.common.utils.ExponentialBackoff;
 import org.apache.kafka.common.utils.LogContext;
+
 import org.slf4j.Logger;

Review comment:
       According to description, the import order is 
   
   1. org.apach.kafka.*
   1. javax.*
   1. java.*
   1. *
   
   Is ```org.slf4j.Logger``` in wrong order?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org