You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/06/01 05:37:12 UTC

[GitHub] [trafficserver] maskit opened a new pull request #6837: Generalize KA check logic

maskit opened a new pull request #6837:
URL: https://github.com/apache/trafficserver/pull/6837


   Since the logic is for chunked encoding, we should be able to check the availability instead of protocol names. This enables us to not maintain the protocol list here that don't use chunked encoding.
   
   Without this change, we'd need to check every protocol names that don't support chunked encoding such as http/2, h3, h3-27, h3-28, etc. by costly string comparison.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] maskit commented on pull request #6837: Generalize KA check logic

Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #6837:
URL: https://github.com/apache/trafficserver/pull/6837#issuecomment-638521252


   This is nice to have for 9.0.0, but not necessary at the moment (we can wait for 9.0.1 or 9.1.0). We'll need this if we support multiple versions of QUIC.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] randall commented on pull request #6837: Generalize KA check logic

Posted by GitBox <gi...@apache.org>.
randall commented on pull request #6837:
URL: https://github.com/apache/trafficserver/pull/6837#issuecomment-637072805


   [approve ci autest]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] maskit merged pull request #6837: Generalize KA check logic

Posted by GitBox <gi...@apache.org>.
maskit merged pull request #6837:
URL: https://github.com/apache/trafficserver/pull/6837


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] zwoop commented on pull request #6837: Generalize KA check logic

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #6837:
URL: https://github.com/apache/trafficserver/pull/6837#issuecomment-641534496


   Cherry-picked to v9.0.x branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] maskit commented on pull request #6837: Generalize KA check logic

Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #6837:
URL: https://github.com/apache/trafficserver/pull/6837#issuecomment-637200363


   [approve ci autest]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] maskit commented on pull request #6837: Generalize KA check logic

Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #6837:
URL: https://github.com/apache/trafficserver/pull/6837#issuecomment-636686244


   [approve ci autest]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] randall commented on pull request #6837: Generalize KA check logic

Posted by GitBox <gi...@apache.org>.
randall commented on pull request #6837:
URL: https://github.com/apache/trafficserver/pull/6837#issuecomment-636901965


   [approve ci autest]
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org