[jira] [Commented] (HADOOP-15113) NPE in S3A getFileStatus: null instrumentation on using closed instance

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288155#comment-16288155 ] 

Steve Loughran commented on HADOOP-15113:
-----------------------------------------

This NPE is how operations on a closed FS surface, which is not useful in terms of debugging

Proposed:
a volatile boolean isClosed; alongside the atomicBoolean
a which checkOpen() call which throws an IOE if closed

Using the volatile makes the check low cost 


> NPE in S3A getFileStatus: null instrumentation on using closed instance
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-15113
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15113
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.1.0
>            Reporter: Steve Loughran
>
> NPE in getFileStatus in a downstream test of mine; s3a ireland
> {{PathMetadata pm = metadataStore.get(path, needEmptyDirectoryFlag);. }}
> Something up with the bucket config?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org