You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/10/09 20:04:32 UTC

[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #7228: Let Dedicated EThreads use `EThread::schedule`

SolidWallOfCode commented on a change in pull request #7228:
URL: https://github.com/apache/trafficserver/pull/7228#discussion_r502646734



##########
File path: iocore/eventsystem/P_UnixEThread.h
##########
@@ -79,7 +79,10 @@ TS_INLINE Event *
 EThread::schedule(Event *e)
 {
   e->ethread = this;
-  ink_assert(tt == REGULAR);

Review comment:
       Yes. If the thread isn't `REGULAR` then it's a dedicated thread that only calls a single continuation - there is no event loop on which to schedule. See [here](https://github.com/apache/trafficserver/blob/master/iocore/eventsystem/UnixEThread.cc#L318).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org