[GitHub] [cloudstack] rhtyd commented on a change in pull request #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) 
URL: https://github.com/apache/cloudstack/pull/3248#discussion_r288925678
 
 

 ##########
 File path: server/src/main/java/com/cloud/acl/DomainChecker.java
 ##########
 @@ -167,81 +182,155 @@ public boolean checkAccess(User user, ControlledEntity entity) throws Permission
     }
 
     @Override
-    public boolean checkAccess(Account account, DiskOffering dof) throws PermissionDeniedException {
-        if (account == null || dof == null || dof.getDomainId() == null) {//public offering
-            return true;
+    public boolean checkAccess(Account account, DiskOffering dof, DataCenter zone) throws PermissionDeniedException {
+        boolean isAccess = false;
 
 Review comment:
   minor nit: `hasAccess` is perhaps a better variable name :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services