You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2020/09/29 23:07:10 UTC
Review Request 72915: ATLAS-3934: Dockerfile: moved environment
variables to .env file - #3
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72915/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Sarath Subramanian, and Sidharth Mishra.
Bugs: ATLAS-3934
https://issues.apache.org/jira/browse/ATLAS-3934
Repository: atlas
Description
-------
Moved environment variable from Dockerfiles to .env file, which helps avoid changing Dockerfiles to build with different profiles/branches.
Diffs
-----
dev-support/atlas-docker/.env PRE-CREATION
dev-support/atlas-docker/Dockerfile.atlas b90a1ca03
dev-support/atlas-docker/Dockerfile.atlas-base b7c86abbb
dev-support/atlas-docker/Dockerfile.atlas-build bc27e9fd2
dev-support/atlas-docker/README.md 9e56fa1b6
dev-support/atlas-docker/docker-compose.atlas-base.yml 81c421ae6
dev-support/atlas-docker/docker-compose.atlas-build.yml c72b7d1a5
dev-support/atlas-docker/docker-compose.atlas.yml ccb1b7297
dev-support/atlas-docker/scripts/atlas-build.sh eafe4bdad
Diff: https://reviews.apache.org/r/72915/diff/1/
Testing
-------
- built and run Atlas in Docker containers built with docker and docker-compose commands
Thanks,
Madhan Neethiraj
Re: Review Request 72915: ATLAS-3934: Dockerfile: moved environment
variables to .env file - #3
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72915/#review221985
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Sept. 29, 2020, 4:07 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72915/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2020, 4:07 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Sarath Subramanian, and Sidharth Mishra.
>
>
> Bugs: ATLAS-3934
> https://issues.apache.org/jira/browse/ATLAS-3934
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Moved environment variable from Dockerfiles to .env file, which helps avoid changing Dockerfiles to build with different profiles/branches.
>
>
> Diffs
> -----
>
> dev-support/atlas-docker/.env PRE-CREATION
> dev-support/atlas-docker/Dockerfile.atlas b90a1ca03
> dev-support/atlas-docker/Dockerfile.atlas-base b7c86abbb
> dev-support/atlas-docker/Dockerfile.atlas-build bc27e9fd2
> dev-support/atlas-docker/README.md 9e56fa1b6
> dev-support/atlas-docker/docker-compose.atlas-base.yml 81c421ae6
> dev-support/atlas-docker/docker-compose.atlas-build.yml c72b7d1a5
> dev-support/atlas-docker/docker-compose.atlas.yml ccb1b7297
> dev-support/atlas-docker/scripts/atlas-build.sh eafe4bdad
>
>
> Diff: https://reviews.apache.org/r/72915/diff/1/
>
>
> Testing
> -------
>
> - built and run Atlas in Docker containers built with docker and docker-compose commands
>
>
> Thanks,
>
> Madhan Neethiraj
>
>