[GitHub] [superset] villebro commented on a diff in pull request #23012: fix: cache warmup solution non legacy charts.

["villebro (via GitHub)" <gi...@apache.org>]

villebro commented on code in PR #23012:
URL: https://github.com/apache/superset/pull/23012#discussion_r1102518700


##########
superset/constants.py:
##########
@@ -189,3 +189,32 @@ class CacheRegion(str, Enum):
     DEFAULT = "default"
     DATA = "data"
     THUMBNAIL = "thumbnail"
+
+
+legacy_charts = [
+    "line",
+    "dist_bar",
+    "area",
+    "time_table",
+    "histogram",
+    "time_pivot",
+    "heatmap",
+    "dual_line",
+    "line_multi",
+    "treemap",
+    "sunburst",
+    "sankey",
+    "mapbox",
+    "rose",
+    "bubble",
+    "horizon",
+    "compare",
+    "partition",
+    "event_flow",
+    "world_map",
+    "paired_ttest",
+    "para",
+    "bullet",
+    "chord",
+    "pivot_table",
+]

Review Comment:
   I think a more dynamic approach would be to check if there's a query context for a given slice. If there is, assume it's the new type, and if there isn't, assume it's legacy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org