You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2026/08/20 09:10:44 UTC

[GH] (pekko-grpc/fix-847-codec-negotiate-whitespace): Workflow run "Validate and test" is working again!

The GitHub Actions job "Validate and test" on pekko-grpc.git/fix-847-codec-negotiate-whitespace has succeeded.
Run started by GitHub user haroldb1 (triggered by pjfanning).

Head commit for run:
7620f98115a57a4a1708f15603c745307e36f40d / Harold Bergson <ha...@pirum.com>
Fix Codecs.negotiate() dropping supported encodings with whitespace

Motivation:
grpc-accept-encoding headers formatted with a space after the comma
(e.g. "deflate, gzip", as sent by grpc-go/grpc-python/grpcurl) were
never matched against supported codec names, silently downgrading
negotiation to Identity even when the client offered gzip.

Modification:
Trim each split token in `Message-Accept-Encoding`.findIn before
codec-name lookup.

Result:
Codecs.negotiate now correctly picks a supported codec regardless of
whitespace around commas in grpc-accept-encoding.

Tests:
- sbt "runtime / testOnly org.apache.pekko.grpc.CodecsSpec" - pass

References:
Fixes #847

Report URL: https://github.com/apache/pekko-grpc/actions/runs/32351598110

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org