You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/23 21:25:52 UTC
[GitHub] [hbase] bitoffdev opened a new pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
bitoffdev opened a new pull request #1959:
URL: https://github.com/apache/hbase/pull/1959
Resolves https://issues.apache.org/jira/browse/HBASE-20819
- Based on an old patch from Ha, Xiaolin (patch is still attached to Jira), updated for the current master branch
- In the hbase-shell module, replace all usages of HTableDescriptor with TableDescriptorBuilder
- Add unit tests for removing nonexistent attributes and configurations in the shell (This was previously untested and touches some of the code changes in this PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-648452910
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 44s | master passed |
| +1 :green_heart: | javadoc | 0m 16s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 24s | the patch passed |
| +1 :green_heart: | javadoc | 0m 13s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 6m 58s | hbase-shell in the patch passed. |
| | | 16m 12s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | javac javadoc unit |
| uname | Linux a5eda94ce719 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b556343292 |
| Default Java | 1.8.0_232 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/2/testReport/ |
| Max. process+thread count | 2295 (vs. ulimit of 12500) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-648445610
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 18s | master passed |
| +1 :green_heart: | javadoc | 0m 17s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 0s | the patch passed |
| +1 :green_heart: | javadoc | 0m 14s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 6m 50s | hbase-shell in the patch passed. |
| | | 17m 15s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | javac javadoc unit |
| uname | Linux ecc9dd091431 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b556343292 |
| Default Java | 2020-01-14 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/1/testReport/ |
| Max. process+thread count | 2246 (vs. ulimit of 12500) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r444616508
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -701,40 +703,40 @@ def alter(table_name_str, wait = true, *args)
# Delete column family
if method == 'delete'
raise(ArgumentError, 'NAME parameter missing for delete method') unless name
- htd.removeFamily(name.to_java_bytes)
+ tdb.removeColumnFamily(name.to_java_bytes)
hasTableUpdate = true
# Unset table attributes
elsif method == 'table_att_unset'
raise(ArgumentError, 'NAME parameter missing for table_att_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find attribute: #{key}"
end
- htd.remove(key)
+ tdb.setValue(key, nil)
end
else
- if htd.getValue(name).nil?
+ if tdb.build.getValue(name).nil?
raise ArgumentError, "Could not find attribute: #{name}"
end
- htd.remove(name)
+ tdb.setValue(name, nil)
Review comment:
Ditto.
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -701,40 +703,40 @@ def alter(table_name_str, wait = true, *args)
# Delete column family
if method == 'delete'
raise(ArgumentError, 'NAME parameter missing for delete method') unless name
- htd.removeFamily(name.to_java_bytes)
+ tdb.removeColumnFamily(name.to_java_bytes)
hasTableUpdate = true
# Unset table attributes
elsif method == 'table_att_unset'
raise(ArgumentError, 'NAME parameter missing for table_att_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find attribute: #{key}"
end
- htd.remove(key)
+ tdb.setValue(key, nil)
Review comment:
We have a removeValue method so we'd better make use of it. Anyway the implementation is to just call setValue(key, null).
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -701,40 +703,40 @@ def alter(table_name_str, wait = true, *args)
# Delete column family
if method == 'delete'
raise(ArgumentError, 'NAME parameter missing for delete method') unless name
- htd.removeFamily(name.to_java_bytes)
+ tdb.removeColumnFamily(name.to_java_bytes)
hasTableUpdate = true
# Unset table attributes
elsif method == 'table_att_unset'
raise(ArgumentError, 'NAME parameter missing for table_att_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find attribute: #{key}"
end
- htd.remove(key)
+ tdb.setValue(key, nil)
end
else
- if htd.getValue(name).nil?
+ if tdb.build.getValue(name).nil?
raise ArgumentError, "Could not find attribute: #{name}"
end
- htd.remove(name)
+ tdb.setValue(name, nil)
end
hasTableUpdate = true
# Unset table configuration
elsif method == 'table_conf_unset'
raise(ArgumentError, 'NAME parameter missing for table_conf_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getConfigurationValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find configuration: #{key}"
end
- htd.removeConfiguration(key)
+ tdb.setValue(key, nil)
Review comment:
Ditto.
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -701,40 +703,40 @@ def alter(table_name_str, wait = true, *args)
# Delete column family
if method == 'delete'
raise(ArgumentError, 'NAME parameter missing for delete method') unless name
- htd.removeFamily(name.to_java_bytes)
+ tdb.removeColumnFamily(name.to_java_bytes)
hasTableUpdate = true
# Unset table attributes
elsif method == 'table_att_unset'
raise(ArgumentError, 'NAME parameter missing for table_att_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find attribute: #{key}"
end
- htd.remove(key)
+ tdb.setValue(key, nil)
end
else
- if htd.getValue(name).nil?
+ if tdb.build.getValue(name).nil?
raise ArgumentError, "Could not find attribute: #{name}"
end
- htd.remove(name)
+ tdb.setValue(name, nil)
end
hasTableUpdate = true
# Unset table configuration
elsif method == 'table_conf_unset'
raise(ArgumentError, 'NAME parameter missing for table_conf_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getConfigurationValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find configuration: #{key}"
end
- htd.removeConfiguration(key)
+ tdb.setValue(key, nil)
end
else
- if htd.getConfigurationValue(name).nil?
+ if tdb.build.getValue(name).nil?
raise ArgumentError, "Could not find configuration: #{name}"
end
- htd.removeConfiguration(name)
+ tdb.setValue(name, nil)
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-648447433
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| -0 :warning: | rubocop | 0m 15s | The patch generated 110 new + 434 unchanged - 89 fixed = 544 total (was 523) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. |
| | | 2m 5s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | dupname asflicense rubocop |
| uname | Linux 418188617a4f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b556343292 |
| rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
| Max. process+thread count | 47 (vs. ulimit of 12500) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
bitoffdev commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r445790978
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -971,101 +976,103 @@ def enabled?(table_name)
end
#----------------------------------------------------------------------------------------------
- # Return a new HColumnDescriptor made of passed args
- def hcd(arg, htd)
+ # Return a new ColumnFamilyDescriptor made of passed args
+ def hcd(arg, tdb)
# String arg, single parameter constructor
- return org.apache.hadoop.hbase.HColumnDescriptor.new(arg) if arg.is_a?(String)
+
+ return ColumnFamilyDescriptorBuilder.of(arg) if arg.is_a?(String)
raise(ArgumentError, "Column family #{arg} must have a name") unless name = arg.delete(NAME)
- family = htd.getFamily(name.to_java_bytes)
+ cfd = tdb.build.getColumnFamily(name.to_java_bytes)
Review comment:
I think this is the best way to do it at the moment. Currently, it seems that TableDescriptorBuilder is intended to be used for writing only, in which case we would not want the builder itself to have methods like getColumnFamily or hasColumnFamily. This is consistent with the lack of getValue and hasValue methods on the builder.
Other than adding methods to builder, the only other way to shortcut the handful of calls this patch makes to `tdb.build` would be to cache the TableDescriptor at the start of each method that uses a T.D.. I have to recommend against this approach since it would technically change the behavior. Ex: If you were to execute something in the shell like `alter 't1', {NAME => 'fam1', METHOD => 'delete'}, {NAME => 'fam1', VERSIONS => 5}` where a C.F. is changed multiple times. In this example, a cached T.D. would not reflect the deletion of the C.F..
**With these thoughts, I am inclined to leave the patch as-is.**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
bitoffdev commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r445012104
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -25,6 +25,8 @@
java_import org.apache.hadoop.hbase.util.Bytes
java_import org.apache.hadoop.hbase.ServerName
java_import org.apache.hadoop.hbase.TableName
+java_import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder
Review comment:
As of my most recent commit, the symbols HTableDescriptor and HColumnDescriptor are not present in the hbase-shell module, which I verified via `grep -r 'HColumnDescriptor\|HTableDescriptor' hbase-shell`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-650322428
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 21s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 14s | master passed |
| +1 :green_heart: | checkstyle | 0m 42s | master passed |
| +1 :green_heart: | spotbugs | 1m 17s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 30s | the patch passed |
| -0 :warning: | checkstyle | 0m 31s | hbase-client: The patch generated 1 new + 27 unchanged - 0 fixed = 28 total (was 27) |
| -0 :warning: | rubocop | 0m 22s | The patch generated 117 new + 478 unchanged - 95 fixed = 595 total (was 573) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 14m 5s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | spotbugs | 1m 33s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. |
| | | 38m 55s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop |
| uname | Linux 25e181d9d92e 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 71af97cd05 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt |
| rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
| Max. process+thread count | 84 (vs. ulimit of 12500) |
| modules | C: hbase-client hbase-shell U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r445302449
##########
File path: hbase-shell/src/main/ruby/hbase_constants.rb
##########
@@ -109,8 +109,8 @@ def self.promote_constants(constants)
end
end
- promote_constants(org.apache.hadoop.hbase.HColumnDescriptor.constants)
- promote_constants(org.apache.hadoop.hbase.HTableDescriptor.constants)
+ promote_constants(org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.constants)
Review comment:
we'll need to release note the changed set of constants, if any.
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -971,101 +976,103 @@ def enabled?(table_name)
end
#----------------------------------------------------------------------------------------------
- # Return a new HColumnDescriptor made of passed args
- def hcd(arg, htd)
+ # Return a new ColumnFamilyDescriptor made of passed args
+ def hcd(arg, tdb)
# String arg, single parameter constructor
- return org.apache.hadoop.hbase.HColumnDescriptor.new(arg) if arg.is_a?(String)
+
+ return ColumnFamilyDescriptorBuilder.of(arg) if arg.is_a?(String)
raise(ArgumentError, "Column family #{arg} must have a name") unless name = arg.delete(NAME)
- family = htd.getFamily(name.to_java_bytes)
+ cfd = tdb.build.getColumnFamily(name.to_java_bytes)
Review comment:
do we need to build the whole table descriptor in order to check for the column family? I see we do this several times in the change set.
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -971,101 +976,103 @@ def enabled?(table_name)
end
#----------------------------------------------------------------------------------------------
- # Return a new HColumnDescriptor made of passed args
- def hcd(arg, htd)
+ # Return a new ColumnFamilyDescriptor made of passed args
+ def hcd(arg, tdb)
Review comment:
Since this no longer returns `HColumnDescriptor` maybe `cfd` would be a better name?
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -971,101 +976,103 @@ def enabled?(table_name)
end
#----------------------------------------------------------------------------------------------
- # Return a new HColumnDescriptor made of passed args
- def hcd(arg, htd)
+ # Return a new ColumnFamilyDescriptor made of passed args
+ def hcd(arg, tdb)
Review comment:
even if we do not change this name we will need to release note this change because it is visible to shell users but the return type changed.
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -1359,26 +1366,26 @@ def list_locks
@admin.getLocks
end
- # Parse arguments and update HTableDescriptor accordingly
- def update_htd_from_arg(htd, arg)
Review comment:
this method was accessible to shell users, so we will need to release note the removal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-648453133
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 50s | master passed |
| +1 :green_heart: | javadoc | 0m 14s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 2s | the patch passed |
| +1 :green_heart: | javadoc | 0m 14s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 6m 52s | hbase-shell in the patch passed. |
| | | 16m 45s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | javac javadoc unit |
| uname | Linux 085b638e45a1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b556343292 |
| Default Java | 2020-01-14 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/2/testReport/ |
| Max. process+thread count | 2249 (vs. ulimit of 12500) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r446299722
##########
File path: hbase-shell/src/main/ruby/hbase_constants.rb
##########
@@ -109,8 +109,8 @@ def self.promote_constants(constants)
end
end
- promote_constants(org.apache.hadoop.hbase.HColumnDescriptor.constants)
- promote_constants(org.apache.hadoop.hbase.HTableDescriptor.constants)
+ promote_constants(org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.constants)
Review comment:
That's great work, thanks! Analysis looks reasonable to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
bitoffdev commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r445721365
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -971,101 +976,103 @@ def enabled?(table_name)
end
#----------------------------------------------------------------------------------------------
- # Return a new HColumnDescriptor made of passed args
- def hcd(arg, htd)
+ # Return a new ColumnFamilyDescriptor made of passed args
+ def hcd(arg, tdb)
Review comment:
I agree. I went ahead and renamed `hcd` to `cfd` and added the removal of `hcd` to the custom "Release Note" field in Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-650297656
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 15s | master passed |
| +1 :green_heart: | compile | 0m 50s | master passed |
| +1 :green_heart: | shadedjars | 5m 45s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 28s | hbase-client in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 4s | the patch passed |
| +1 :green_heart: | compile | 0m 50s | the patch passed |
| +1 :green_heart: | javac | 0m 50s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 46s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 26s | hbase-client in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 9s | hbase-client in the patch passed. |
| -1 :x: | unit | 1m 41s | hbase-shell in the patch failed. |
| | | 28m 21s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 14d0db47cea6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 71af97cd05 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/testReport/ |
| Max. process+thread count | 2129 (vs. ulimit of 12500) |
| modules | C: hbase-client hbase-shell U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r445878539
##########
File path: hbase-shell/src/main/ruby/hbase_constants.rb
##########
@@ -109,8 +109,8 @@ def self.promote_constants(constants)
end
end
- promote_constants(org.apache.hadoop.hbase.HColumnDescriptor.constants)
- promote_constants(org.apache.hadoop.hbase.HTableDescriptor.constants)
+ promote_constants(org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.constants)
Review comment:
Hurm. Some of those still look likely to be useful (e.g. MOB_THRESHOLD_BYTES). Can we add them in without bringing back references to the classes we're removing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-648932462
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 14s | master passed |
| +1 :green_heart: | compile | 1m 1s | master passed |
| +1 :green_heart: | shadedjars | 6m 43s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 31s | hbase-client in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 55s | the patch passed |
| +1 :green_heart: | compile | 0m 58s | the patch passed |
| +1 :green_heart: | javac | 0m 58s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 42s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 27s | hbase-client in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 30s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 6m 54s | hbase-shell in the patch passed. |
| | | 38m 55s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 2bf4d49ca86e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 22103067b6 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/testReport/ |
| Max. process+thread count | 1535 (vs. ulimit of 12500) |
| modules | C: hbase-client hbase-shell U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
bitoffdev commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r445722179
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -1359,26 +1366,26 @@ def list_locks
@admin.getLocks
end
- # Parse arguments and update HTableDescriptor accordingly
- def update_htd_from_arg(htd, arg)
Review comment:
Thanks for the heads up! I just updated the "Release Note" field in Jira to state that this method was removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-650304489
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 47s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 3s | master passed |
| +1 :green_heart: | checkstyle | 0m 44s | master passed |
| +1 :green_heart: | spotbugs | 1m 16s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 38s | the patch passed |
| -0 :warning: | checkstyle | 0m 35s | hbase-client: The patch generated 1 new + 27 unchanged - 0 fixed = 28 total (was 27) |
| -0 :warning: | rubocop | 0m 23s | The patch generated 116 new + 478 unchanged - 95 fixed = 594 total (was 573) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 14m 44s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | spotbugs | 1m 30s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. |
| | | 41m 23s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop |
| uname | Linux 691d482fbab7 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 71af97cd05 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt |
| rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
| Max. process+thread count | 84 (vs. ulimit of 12500) |
| modules | C: hbase-client hbase-shell U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-650319359
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 29s | master passed |
| +1 :green_heart: | compile | 0m 45s | master passed |
| +1 :green_heart: | shadedjars | 5m 32s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 35s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 35s | the patch passed |
| +1 :green_heart: | compile | 0m 45s | the patch passed |
| +1 :green_heart: | javac | 0m 45s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 30s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 35s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 3s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 7m 11s | hbase-shell in the patch passed. |
| | | 31m 38s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux dd6dee58bc37 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 71af97cd05 |
| Default Java | 1.8.0_232 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/testReport/ |
| Max. process+thread count | 2246 (vs. ulimit of 12500) |
| modules | C: hbase-client hbase-shell U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
bitoffdev commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r446296466
##########
File path: hbase-shell/src/main/ruby/hbase_constants.rb
##########
@@ -109,8 +109,8 @@ def self.promote_constants(constants)
end
end
- promote_constants(org.apache.hadoop.hbase.HColumnDescriptor.constants)
- promote_constants(org.apache.hadoop.hbase.HTableDescriptor.constants)
+ promote_constants(org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.constants)
Review comment:
I just pushed a commit that adds back three constants, but leaves the rest out. I left a [comment on Jira](https://issues.apache.org/jira/browse/HBASE-20819?focusedCommentId=17146470#comment-17146470) with my rationale for each of the constants. **Let me know if you disagree with any of my conclusions, and I can easily add more constants back** 😄.
Specifically for the [MOB constants](https://github.com/apache/hbase/blob/025ddce868eb06b4072b5152c5ffae5a01e7ae30/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java#L163), we added setters for all the MOB key-value pairs to our builder. I think including these _private_ constants will encourage users to go against our defined interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
bitoffdev commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r445722179
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -1359,26 +1366,26 @@ def list_locks
@admin.getLocks
end
- # Parse arguments and update HTableDescriptor accordingly
- def update_htd_from_arg(htd, arg)
Review comment:
Thanks for the heads up! I just update the "Release Note" field in Jira to state that this method was removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r444538705
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -25,6 +25,8 @@
java_import org.apache.hadoop.hbase.util.Bytes
java_import org.apache.hadoop.hbase.ServerName
java_import org.apache.hadoop.hbase.TableName
+java_import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder
Review comment:
Are there imports you can drop now after doing this work? e.g. the HTableDescriptor import?
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -701,40 +703,40 @@ def alter(table_name_str, wait = true, *args)
# Delete column family
if method == 'delete'
raise(ArgumentError, 'NAME parameter missing for delete method') unless name
- htd.removeFamily(name.to_java_bytes)
+ tdb.removeColumnFamily(name.to_java_bytes)
hasTableUpdate = true
# Unset table attributes
elsif method == 'table_att_unset'
raise(ArgumentError, 'NAME parameter missing for table_att_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find attribute: #{key}"
end
- htd.remove(key)
+ tdb.setValue(key, nil)
Review comment:
No 'remove' for CF?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-649741835
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 59s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 3s | master passed |
| +1 :green_heart: | compile | 0m 54s | master passed |
| +1 :green_heart: | shadedjars | 6m 34s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 30s | hbase-client in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 13s | the patch passed |
| +1 :green_heart: | compile | 1m 2s | the patch passed |
| +1 :green_heart: | javac | 1m 2s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 19s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 26s | hbase-client in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 31s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 8m 20s | hbase-shell in the patch passed. |
| | | 41m 33s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 9001b6da4c04 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1378776a91 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/testReport/ |
| Max. process+thread count | 1537 (vs. ulimit of 12500) |
| modules | C: hbase-client hbase-shell U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r444949026
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -701,40 +703,40 @@ def alter(table_name_str, wait = true, *args)
# Delete column family
if method == 'delete'
raise(ArgumentError, 'NAME parameter missing for delete method') unless name
- htd.removeFamily(name.to_java_bytes)
+ tdb.removeColumnFamily(name.to_java_bytes)
hasTableUpdate = true
# Unset table attributes
elsif method == 'table_att_unset'
raise(ArgumentError, 'NAME parameter missing for table_att_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find attribute: #{key}"
end
- htd.remove(key)
+ tdb.setValue(key, nil)
Review comment:
Agree with adding a removeValue(String). Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-648928574
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 39s | master passed |
| +1 :green_heart: | compile | 0m 47s | master passed |
| +1 :green_heart: | shadedjars | 5m 34s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 38s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 25s | the patch passed |
| +1 :green_heart: | compile | 0m 45s | the patch passed |
| +1 :green_heart: | javac | 0m 45s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 33s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 5s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 6m 59s | hbase-shell in the patch passed. |
| | | 31m 36s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 6d6ebef0eff8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 22103067b6 |
| Default Java | 1.8.0_232 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/testReport/ |
| Max. process+thread count | 2392 (vs. ulimit of 12500) |
| modules | C: hbase-client hbase-shell U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
bitoffdev commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r445790978
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -971,101 +976,103 @@ def enabled?(table_name)
end
#----------------------------------------------------------------------------------------------
- # Return a new HColumnDescriptor made of passed args
- def hcd(arg, htd)
+ # Return a new ColumnFamilyDescriptor made of passed args
+ def hcd(arg, tdb)
# String arg, single parameter constructor
- return org.apache.hadoop.hbase.HColumnDescriptor.new(arg) if arg.is_a?(String)
+
+ return ColumnFamilyDescriptorBuilder.of(arg) if arg.is_a?(String)
raise(ArgumentError, "Column family #{arg} must have a name") unless name = arg.delete(NAME)
- family = htd.getFamily(name.to_java_bytes)
+ cfd = tdb.build.getColumnFamily(name.to_java_bytes)
Review comment:
I think this is the best way to do it at the moment. Currently, it seems that TableDescriptorBuilder is intended to be used for writing only, in which case we would not want the builder itself to have methods like getColumnFamily or hasColumnFamily. This is consistent with the lack of getValue and setValue methods on the builder.
Other than adding methods to builder, the only other way to shortcut the handful of calls this patch makes to `tdb.build` would be to cache the TableDescriptor at the start of each method that uses a T.D.. I have to recommend against this approach since it would technically change the behavior. Ex: If you were to execute something in the shell like `alter 't1', {NAME => 'fam1', METHOD => 'delete'}, {NAME => 'fam1', VERSIONS => 5}` where a C.F. is changed multiple times. In this example, a cached T.D. would not reflect the deletion of the C.F..
**With these thoughts, I am inclined to leave the patch as-is.**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-648445180
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 45s | master passed |
| +1 :green_heart: | javadoc | 0m 16s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 23s | the patch passed |
| +1 :green_heart: | javadoc | 0m 13s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 6m 59s | hbase-shell in the patch passed. |
| | | 16m 13s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | javac javadoc unit |
| uname | Linux 41ea3dc7500f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b556343292 |
| Default Java | 1.8.0_232 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/1/testReport/ |
| Max. process+thread count | 2364 (vs. ulimit of 12500) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-650296731
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 26s | master passed |
| +1 :green_heart: | compile | 0m 48s | master passed |
| +1 :green_heart: | shadedjars | 5m 35s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 27s | the patch passed |
| +1 :green_heart: | compile | 0m 46s | the patch passed |
| +1 :green_heart: | javac | 0m 46s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 34s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 2s | hbase-client in the patch passed. |
| -1 :x: | unit | 2m 11s | hbase-shell in the patch failed. |
| | | 26m 48s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux dc1f385806fd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 71af97cd05 |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/testReport/ |
| Max. process+thread count | 2106 (vs. ulimit of 12500) |
| modules | C: hbase-client hbase-shell U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/5/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
bitoffdev commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r445746679
##########
File path: hbase-shell/src/main/ruby/hbase_constants.rb
##########
@@ -109,8 +109,8 @@ def self.promote_constants(constants)
end
end
- promote_constants(org.apache.hadoop.hbase.HColumnDescriptor.constants)
- promote_constants(org.apache.hadoop.hbase.HTableDescriptor.constants)
+ promote_constants(org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder.constants)
Review comment:
This patch removes 11 constants. I added these to the release notes and left a long-form explanation in Jira:
https://issues.apache.org/jira/browse/HBASE-20819?focusedCommentId=17145696
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
bitoffdev commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r444922986
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -701,40 +703,40 @@ def alter(table_name_str, wait = true, *args)
# Delete column family
if method == 'delete'
raise(ArgumentError, 'NAME parameter missing for delete method') unless name
- htd.removeFamily(name.to_java_bytes)
+ tdb.removeColumnFamily(name.to_java_bytes)
hasTableUpdate = true
# Unset table attributes
elsif method == 'table_att_unset'
raise(ArgumentError, 'NAME parameter missing for table_att_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find attribute: #{key}"
end
- htd.remove(key)
+ tdb.setValue(key, nil)
Review comment:
Unfortunately, the current overloads for `TableDescriptorBuilder.removeValue` take either `Bytes`, or `byte[]`, whereas `setValue` has an overload for a String argument. **Unless there is an objection, I will go ahead and add the `removeValue(final String key)` overload**, which would be consistent with the `setValue` overloads, and may be helpful for other developers in the future as well.
The other alternative (converting the key to bytes) seems like it would be more effort than just using `setValue` as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack merged pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
saintstack merged pull request #1959:
URL: https://github.com/apache/hbase/pull/1959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-649738353
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 52s | master passed |
| +1 :green_heart: | checkstyle | 0m 49s | master passed |
| +1 :green_heart: | spotbugs | 1m 18s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 29s | the patch passed |
| -0 :warning: | checkstyle | 0m 39s | hbase-client: The patch generated 1 new + 27 unchanged - 0 fixed = 28 total (was 27) |
| -0 :warning: | rubocop | 0m 25s | The patch generated 116 new + 478 unchanged - 95 fixed = 594 total (was 573) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 15m 39s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | spotbugs | 1m 25s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 27s | The patch does not generate ASF License warnings. |
| | | 41m 5s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop |
| uname | Linux d73445740988 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1378776a91 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt |
| rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-client hbase-shell U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-648439581
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| -0 :warning: | rubocop | 0m 16s | The patch generated 114 new + 434 unchanged - 89 fixed = 548 total (was 523) |
| -0 :warning: | whitespace | 0m 0s | The patch 2 line(s) with tabs. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. |
| | | 2m 17s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | dupname asflicense rubocop |
| uname | Linux 37e21e48b3f8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b556343292 |
| rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
| whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/1/artifact/yetus-general-check/output/whitespace-tabs.txt |
| Max. process+thread count | 52 (vs. ulimit of 12500) |
| modules | C: hbase-shell U: hbase-shell |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
bitoffdev commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r445838230
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -971,101 +976,103 @@ def enabled?(table_name)
end
#----------------------------------------------------------------------------------------------
- # Return a new HColumnDescriptor made of passed args
- def hcd(arg, htd)
+ # Return a new ColumnFamilyDescriptor made of passed args
+ def hcd(arg, tdb)
# String arg, single parameter constructor
- return org.apache.hadoop.hbase.HColumnDescriptor.new(arg) if arg.is_a?(String)
+
+ return ColumnFamilyDescriptorBuilder.of(arg) if arg.is_a?(String)
raise(ArgumentError, "Column family #{arg} must have a name") unless name = arg.delete(NAME)
- family = htd.getFamily(name.to_java_bytes)
+ cfd = tdb.build.getColumnFamily(name.to_java_bytes)
Review comment:
I think that if we do choose to add any sort of introspection (like hasColumnFamily, getColumnFamily) to the TableDescriptorBuilder itself, that would belong in a separate ticket/issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
bitoffdev commented on a change in pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#discussion_r445013274
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -701,40 +703,40 @@ def alter(table_name_str, wait = true, *args)
# Delete column family
if method == 'delete'
raise(ArgumentError, 'NAME parameter missing for delete method') unless name
- htd.removeFamily(name.to_java_bytes)
+ tdb.removeColumnFamily(name.to_java_bytes)
hasTableUpdate = true
# Unset table attributes
elsif method == 'table_att_unset'
raise(ArgumentError, 'NAME parameter missing for table_att_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find attribute: #{key}"
end
- htd.remove(key)
+ tdb.setValue(key, nil)
end
else
- if htd.getValue(name).nil?
+ if tdb.build.getValue(name).nil?
raise ArgumentError, "Could not find attribute: #{name}"
end
- htd.remove(name)
+ tdb.setValue(name, nil)
Review comment:
Done
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -701,40 +703,40 @@ def alter(table_name_str, wait = true, *args)
# Delete column family
if method == 'delete'
raise(ArgumentError, 'NAME parameter missing for delete method') unless name
- htd.removeFamily(name.to_java_bytes)
+ tdb.removeColumnFamily(name.to_java_bytes)
hasTableUpdate = true
# Unset table attributes
elsif method == 'table_att_unset'
raise(ArgumentError, 'NAME parameter missing for table_att_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find attribute: #{key}"
end
- htd.remove(key)
+ tdb.setValue(key, nil)
end
else
- if htd.getValue(name).nil?
+ if tdb.build.getValue(name).nil?
raise ArgumentError, "Could not find attribute: #{name}"
end
- htd.remove(name)
+ tdb.setValue(name, nil)
end
hasTableUpdate = true
# Unset table configuration
elsif method == 'table_conf_unset'
raise(ArgumentError, 'NAME parameter missing for table_conf_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getConfigurationValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find configuration: #{key}"
end
- htd.removeConfiguration(key)
+ tdb.setValue(key, nil)
Review comment:
Done
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -701,40 +703,40 @@ def alter(table_name_str, wait = true, *args)
# Delete column family
if method == 'delete'
raise(ArgumentError, 'NAME parameter missing for delete method') unless name
- htd.removeFamily(name.to_java_bytes)
+ tdb.removeColumnFamily(name.to_java_bytes)
hasTableUpdate = true
# Unset table attributes
elsif method == 'table_att_unset'
raise(ArgumentError, 'NAME parameter missing for table_att_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find attribute: #{key}"
end
- htd.remove(key)
+ tdb.setValue(key, nil)
end
else
- if htd.getValue(name).nil?
+ if tdb.build.getValue(name).nil?
raise ArgumentError, "Could not find attribute: #{name}"
end
- htd.remove(name)
+ tdb.setValue(name, nil)
end
hasTableUpdate = true
# Unset table configuration
elsif method == 'table_conf_unset'
raise(ArgumentError, 'NAME parameter missing for table_conf_unset method') unless name
if name.is_a?(Array)
name.each do |key|
- if htd.getConfigurationValue(key).nil?
+ if tdb.build.getValue(key).nil?
raise ArgumentError, "Could not find configuration: #{key}"
end
- htd.removeConfiguration(key)
+ tdb.setValue(key, nil)
end
else
- if htd.getConfigurationValue(name).nil?
+ if tdb.build.getValue(name).nil?
raise ArgumentError, "Could not find configuration: #{name}"
end
- htd.removeConfiguration(name)
+ tdb.setValue(name, nil)
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-649737703
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 39s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 23s | master passed |
| +1 :green_heart: | compile | 0m 52s | master passed |
| +1 :green_heart: | shadedjars | 7m 27s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 41s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 49s | the patch passed |
| +1 :green_heart: | compile | 0m 52s | the patch passed |
| +1 :green_heart: | javac | 0m 52s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 19s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 45s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 20s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 8m 22s | hbase-shell in the patch passed. |
| | | 39m 45s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux b76dedf7d3f6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1378776a91 |
| Default Java | 1.8.0_232 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/testReport/ |
| Max. process+thread count | 2371 (vs. ulimit of 12500) |
| modules | C: hbase-client hbase-shell U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/4/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-650320797
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 23s | master passed |
| +1 :green_heart: | compile | 0m 54s | master passed |
| +1 :green_heart: | shadedjars | 5m 51s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 29s | hbase-client in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 13s | the patch passed |
| +1 :green_heart: | compile | 0m 51s | the patch passed |
| +1 :green_heart: | javac | 0m 51s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 25s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 29s | hbase-client in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 15s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 7m 4s | hbase-shell in the patch passed. |
| | | 35m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux c8ad984b907c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 71af97cd05 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/testReport/ |
| Max. process+thread count | 2263 (vs. ulimit of 12500) |
| modules | C: hbase-client hbase-shell U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/6/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1959:
URL: https://github.com/apache/hbase/pull/1959#issuecomment-648928156
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 41s | master passed |
| +1 :green_heart: | checkstyle | 0m 41s | master passed |
| +1 :green_heart: | spotbugs | 1m 0s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 26s | the patch passed |
| -0 :warning: | checkstyle | 0m 26s | hbase-client: The patch generated 1 new + 27 unchanged - 0 fixed = 28 total (was 27) |
| -0 :warning: | rubocop | 0m 18s | The patch generated 116 new + 478 unchanged - 95 fixed = 594 total (was 573) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 11m 13s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| +1 :green_heart: | spotbugs | 1m 7s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. |
| | | 30m 53s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1959 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop |
| uname | Linux cabafe19a5f3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 22103067b6 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt |
| rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt |
| Max. process+thread count | 94 (vs. ulimit of 12500) |
| modules | C: hbase-client hbase-shell U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1959/3/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org