[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #40361: [SPARK_42742]access apiserver by pod env

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #40361:
URL: https://github.com/apache/spark/pull/40361#discussion_r1139667140


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -55,6 +55,14 @@ private[spark] object Config extends Logging {
       .stringConf
       .createWithDefault(KUBERNETES_MASTER_INTERNAL_URL)
 
+  val KUBERNETES_DRIVER_MASTER_URL_FROM_POD_ENV =
+    ConfigBuilder("spark.kubernetes.driver.master.from.pod.env")
+      .doc("If true, driver will get master url from pod env " +
+        "= https://{KUBERNETES_SERVICE_HOST}:{KUBERNETES_SERVICE_PORT_HTTPS}.")
+      .version("3.1.2")

Review Comment:
   This is wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org