You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "abeizn (via GitHub)" <gi...@apache.org> on 2023/09/04 08:27:25 UTC
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #5977: feat: allow users to configure the sync modes for plugins that suppor…
abeizn commented on code in PR #5977:
URL: https://github.com/apache/incubator-devlake/pull/5977#discussion_r1314603104
##########
backend/helpers/pluginhelper/api/api_collector_with_state.go:
##########
@@ -153,10 +156,12 @@ func NewStatefulApiCollectorForFinalizableEntity(args FinalizableApiCollectorArg
if err != nil {
return nil, err
}
-
// // prepare the basic variables
- var isIncremental = manager.IsIncremental()
var createdAfter *time.Time
+ var isIncremental = manager.IsIncremental()
+ if manager.Ctx.TaskContext().FullSync() {
+ isIncremental = false
+ }
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org