[jira] Reopened: (PIG-37) FindBugs: Possible null pointer dereference of esp in PigCombine.reduce

["Alan Gates (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PIG-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan Gates reopened PIG-37:
---------------------------


PigCombine is being used now that I'm in the process of adding the use of the combiner into pig.  And the issue pointed out by Patrick hasn't been fixed.

> FindBugs: Possible null pointer dereference of esp in PigCombine.reduce
> -----------------------------------------------------------------------
>
>                 Key: PIG-37
>                 URL: https://issues.apache.org/jira/browse/PIG-37
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Patrick Hunt
>
> deserialize can return null if evalSpec is empty, need to extend the check on the previous line to include setting evalPipe
>                 String evalSpec = job.get("pig.combineFunc", "");
>                 EvalSpec esp = (EvalSpec)ObjectSerializer.deserialize(evalSpec);
>                 if(esp != null) esp.instantiateFunc(pigContext);
>                 evalPipe = esp.setupPipe(finalout);
> Severity and Description	Path	Resource	Location	Creation Time	Id
> M C NP: Possible null pointer dereference of esp in org.apache.pig.impl.mapreduceExec.PigCombine.reduce(WritableComparable, Iterator, OutputCollector, Reporter)	pig-apache/src/org/apache/pig/impl/mapreduceExec	PigCombine.java	line 69	1196272508421	23812

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.