You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by GitBox <gi...@apache.org> on 2019/02/14 14:04:58 UTC
[GitHub] lburgazzoli commented on a change in pull request #438: Ability to
customise the generated camel-k image
lburgazzoli commented on a change in pull request #438: Ability to customise the generated camel-k image
URL: https://github.com/apache/camel-k/pull/438#discussion_r256845306
##########
File path: contributing.adoc
##########
@@ -90,6 +90,12 @@ After a successful build, if you're connected to a Docker daemon, you can build
make images
```
+The above command produces a `camel-k` image with name `docker.io/apache/camel-k`. Sometimes you might need to produce camel-k images that need to be pushed to the custom repository e.g. `docker.io/myrepo/camel-k`, to do that you can pass a parameter `imgDestination` to the make as shown below:
+
+```
+make imgDestination='docker.io/myrepo' images
Review comment:
would prefer to have the variable name uppercase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services