You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/05 10:57:02 UTC

[GitHub] [rocketmq] ferrirW opened a new issue #3579: Spelling mistake in getter/setter method of mQClientFactory

ferrirW opened a new issue #3579:
URL: https://github.com/apache/rocketmq/issues/3579


   1. Please describe the issue you observed:
   
   There should be spelling getMqClientFactory or getMQClientFactory
   
   ![image](https://user-images.githubusercontent.com/42178996/144743509-c18312e6-5b73-43a4-bb07-e6ca9565981b.png)
   
   2. Please tell us about your environment:
   4.9.2
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] ShannonDing commented on issue #3579: Spelling mistake in getter/setter method of mQClientFactory

Posted by GitBox <gi...@apache.org>.
ShannonDing commented on issue #3579:
URL: https://github.com/apache/rocketmq/issues/3579#issuecomment-1015147171


   it's better to add a new method like ”getClientFactory“  and make the current "getmQClientFactory" deprecated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on issue #3579: Spelling mistake in getter/setter method of mQClientFactory

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3579:
URL: https://github.com/apache/rocketmq/issues/3579#issuecomment-990968266


   
   
   
   > 
   
   It seems that no relevant interface is exposed to the user


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on issue #3579: Spelling mistake in getter/setter method of mQClientFactory

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3579:
URL: https://github.com/apache/rocketmq/issues/3579#issuecomment-987530368


   Merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin edited a comment on issue #3579: Spelling mistake in getter/setter method of mQClientFactory

Posted by GitBox <gi...@apache.org>.
RongtongJin edited a comment on issue #3579:
URL: https://github.com/apache/rocketmq/issues/3579#issuecomment-990968266






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin closed issue #3579: Spelling mistake in getter/setter method of mQClientFactory

Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #3579:
URL: https://github.com/apache/rocketmq/issues/3579


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] areyouok commented on issue #3579: Spelling mistake in getter/setter method of mQClientFactory

Posted by GitBox <gi...@apache.org>.
areyouok commented on issue #3579:
URL: https://github.com/apache/rocketmq/issues/3579#issuecomment-990960220


   This method is public and now break compatibility. 
   
   Can we rollback it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] areyouok commented on issue #3579: Spelling mistake in getter/setter method of mQClientFactory

Posted by GitBox <gi...@apache.org>.
areyouok commented on issue #3579:
URL: https://github.com/apache/rocketmq/issues/3579#issuecomment-990960968


   @duhenglucky @RongtongJin 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky closed issue #3579: Spelling mistake in getter/setter method of mQClientFactory

Posted by GitBox <gi...@apache.org>.
duhenglucky closed issue #3579:
URL: https://github.com/apache/rocketmq/issues/3579


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] ferrirW commented on issue #3579: Spelling mistake in getter/setter method of mQClientFactory

Posted by GitBox <gi...@apache.org>.
ferrirW commented on issue #3579:
URL: https://github.com/apache/rocketmq/issues/3579#issuecomment-986213926


   fix by pr #3581


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] shuangchengsun commented on issue #3579: Spelling mistake in getter/setter method of mQClientFactory

Posted by GitBox <gi...@apache.org>.
shuangchengsun commented on issue #3579:
URL: https://github.com/apache/rocketmq/issues/3579#issuecomment-990982402


   ![image](https://user-images.githubusercontent.com/33629004/145582633-165b2149-e96f-440b-8091-ad0a07637fcb.png)
   no, we use it in our project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org