You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/08/09 20:15:12 UTC
Review Request 37272: Remove thread_tests.cpp in stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37272/
-----------------------------------------------------------
Review request for mesos and Alex Clemmer.
Bugs: MESOS-3139
https://issues.apache.org/jira/browse/MESOS-3139
Repository: mesos
Description
-------
Remove thread_tests.cpp in stout.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt b1a519007e5bed196541f294c4676277f9708714
Diff: https://reviews.apache.org/r/37272/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 37272: [1/3]Remove thread_tests.cpp in stout.
Posted by haosdent huang <ha...@gmail.com>.
> On Aug. 10, 2015, 6:29 p.m., Alex Clemmer wrote:
> > See my review in #37291.
> >
> > There are a few changes we've made locally to the Stout tests CMakeLists, and I think it makes sense to wrap them up into one diff, and push them into master.
Thank you! I discarded this.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37272/#review94775
-----------------------------------------------------------
On Aug. 9, 2015, 6:21 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37272/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2015, 6:21 p.m.)
>
>
> Review request for mesos and Alex Clemmer.
>
>
> Bugs: MESOS-3139
> https://issues.apache.org/jira/browse/MESOS-3139
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove thread_tests.cpp in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt b1a519007e5bed196541f294c4676277f9708714
>
> Diff: https://reviews.apache.org/r/37272/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37272: [1/3]Remove thread_tests.cpp in stout.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37272/#review94775
-----------------------------------------------------------
See my review in #37291.
There are a few changes we've made locally to the Stout tests CMakeLists, and I think it makes sense to wrap them up into one diff, and push them into master.
- Alex Clemmer
On Aug. 9, 2015, 6:21 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37272/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2015, 6:21 p.m.)
>
>
> Review request for mesos and Alex Clemmer.
>
>
> Bugs: MESOS-3139
> https://issues.apache.org/jira/browse/MESOS-3139
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove thread_tests.cpp in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt b1a519007e5bed196541f294c4676277f9708714
>
> Diff: https://reviews.apache.org/r/37272/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37272: [1/3]Remove thread_tests.cpp in stout.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37272/
-----------------------------------------------------------
(Updated Aug. 9, 2015, 6:21 p.m.)
Review request for mesos and Alex Clemmer.
Summary (updated)
-----------------
[1/3]Remove thread_tests.cpp in stout.
Bugs: MESOS-3139
https://issues.apache.org/jira/browse/MESOS-3139
Repository: mesos
Description
-------
Remove thread_tests.cpp in stout.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt b1a519007e5bed196541f294c4676277f9708714
Diff: https://reviews.apache.org/r/37272/diff/
Testing
-------
Thanks,
haosdent huang