[GitHub] [superset] willbarrett commented on a change in pull request #13436: fix(alerts&reports): add celery soft timeout support

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #13436:
URL: https://github.com/apache/superset/pull/13436#discussion_r586814825



##########
File path: superset/reports/commands/exceptions.py
##########
@@ -155,6 +155,10 @@ class AlertQueryError(CommandException):
     message = _("Alert found an error while executing a query.")
 
 
+class AlertQueryTimeout(CommandException):
+    message = _("A timeout occurred while executing the query.")

Review comment:
       As this can happen during either the query or the thumbnail computation, perhaps we should reword this as "A timeout occurred while executing the background job." - is this the same message that would trigger when a Report times out?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org