You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/06/21 10:39:01 UTC
[GitHub] [iceberg] kbendick opened a new pull request #2719: [BUILD] Remove the `/site` folder from the Intellij project to declutter search and reduce indexing time
kbendick opened a new pull request #2719:
URL: https://github.com/apache/iceberg/pull/2719
* Add intellij gradle plugin
* Add /site docs to the excluded directories to declutter search and reduce indexing time
This closes: https://github.com/apache/iceberg/issues/2718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #2719: [BUILD] Remove the `/site` folder from the Intellij project to declutter search and reduce indexing time
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #2719:
URL: https://github.com/apache/iceberg/pull/2719#discussion_r655266951
##########
File path: idea.gradle
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: 'org.jetbrains.gradle.plugin.idea-ext'
Review comment:
I think this can just be moved up to `plugins` and dropped from the `classpath` shenanigans.
There might not even be value in doing this in its own file, but that seems to be the style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #2719: [BUILD] Remove the `/site` folder from the Intellij project to declutter search and reduce indexing time
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #2719:
URL: https://github.com/apache/iceberg/pull/2719#discussion_r655266951
##########
File path: idea.gradle
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: 'org.jetbrains.gradle.plugin.idea-ext'
Review comment:
I think this can just be moved up to `plugins` and dropped from the `classpath` shenanigans.
There might not even be value in doing this in its own file, but that seems to be the style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #2719: [WIP][BUILD] Remove the `/site` folder from the Intellij project to declutter search and reduce indexing time
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #2719:
URL: https://github.com/apache/iceberg/pull/2719#issuecomment-865289346
This was working last Friday, but now when I try it in my repo, it seems to be updating the ignored folder but not removing it from search
I'll keep looking but when it did work it greatly decreased indexing time when switching branches. One can manually comment out the folder but having it automatic would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #2719: [WIP][BUILD] Remove the `/site` folder from the Intellij project to declutter search and reduce indexing time
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #2719:
URL: https://github.com/apache/iceberg/pull/2719#issuecomment-984186013
Closing this since we are moving to versioned docs, possibly in a separate repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #2719: [WIP][BUILD] Remove the `/site` folder from the Intellij project to declutter search and reduce indexing time
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #2719:
URL: https://github.com/apache/iceberg/pull/2719#issuecomment-867153475
This might be too much to ask in this PR, so I am fine if we merge this approach first. But I think the correct approach to take is to add a new gradle task that builds the javadoc of each released version and move it to the javadoc folder, and let the website release task call this new task, so that the javadoc only exists in the website release branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a change in pull request #2719: [WIP][BUILD] Remove the `/site` folder from the Intellij project to declutter search and reduce indexing time
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #2719:
URL: https://github.com/apache/iceberg/pull/2719#discussion_r657455972
##########
File path: idea.gradle
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: 'org.jetbrains.gradle.plugin.idea-ext'
+
+idea {
+ module {
+ // Explicitly exclude site from users intellij project, as they
+ // pollute search and greatly increase indexing times.
+ excludeDirs += project.projectDir.listFiles().findAll {
+ it.path.contains("/site/")
Review comment:
I think we should not exclude everything in `/site`, but only things in `/site/docs/javadoc`, or maybe also the css and image folder. It is beneficial to make the markdown files searchable. (in fact I use that quite often)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick closed pull request #2719: [WIP][BUILD] Remove the `/site` folder from the Intellij project to declutter search and reduce indexing time
Posted by GitBox <gi...@apache.org>.
kbendick closed pull request #2719:
URL: https://github.com/apache/iceberg/pull/2719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #2719: [WIP][BUILD] Remove the `/site` folder from the Intellij project to declutter search and reduce indexing time
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #2719:
URL: https://github.com/apache/iceberg/pull/2719#issuecomment-865289346
This was working last Friday, but now when I try it in my repo, it seems to be updating the ignored folder but not removing it from search
I'll keep looking but when it did work it greatly decreased indexing time when switching branches. One can manually comment out the folder but having it automatic would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org