You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/09/29 04:25:03 UTC

[GitHub] [incubator-dolphinscheduler] zhuangchong commented on pull request #3825: [Improvement-3767][api] Task instance supports query by process instance name

zhuangchong commented on pull request #3825:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3825#issuecomment-700417976


   @break60  sonar check 8.7% Duplication，It’s because of the front-end common.js. Common.js just moved from instanceConditions to the conditions/instance directory. According to what you said, creating a new pr and submitting common.js related code did not solve this problem. Please preview
   
   ---
   sonar 检查 8.7% 代码重复，是因为前端common.js 的原因，common.js 只是从instanceConditions 移动到conditions/instance目录下，按照您说的，新建pr提交common.js相关代码，并没有解决这个问题，帮preview一下


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org