You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/03/07 06:31:58 UTC
[GitHub] incubator-zeppelin pull request: Zeppelin 688
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/764
Zeppelin 688
### What is this PR for?
When a user use Spark interpreter, the result comes out with result number message like :
```
res0: Int = 250
```
Someone might want to print this REPL output with their result, but others may want to see the result only since sometimes this output is too verbose. So, I just want to give an option to hide this REPL output to those users.
The default value of `zeppelin.spark.printREPLOutput` is `true`. This status is as-is. Users can hide REPL output only when they changes this property `true` to `false`. In this case, they can check the result by specifying such as `print(some_variable)`.
### What type of PR is it?
Improvement
### Todos
* [x] - Add a property `zeppelin.spark.printREPLOutput`
* [x] - Add Spark interpreter property table to `docs/spark.md`
### What is the Jira issue?
[ZEPPELIN-688](https://issues.apache.org/jira/browse/ZEPPELIN-688#)
### How should this be tested?
After applying this PR,
1. Create spark interpreter for this test and change `zeppelin.spark.printREPLOutput` property value `true` -> `false`
2. Create a notebook and bind interpreter what you made.
3. Write `val a = 250` down and run this paragraph. Then you can check the any output is not shown although paragraph status is **FINISHED** (This is the result of this PR).
4. Run `print(a)` in the next paragraph. Then finally you can get a result `250`.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? I added Spark interpreter property table to `docs/spark.md`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-688
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/764.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #764
----
commit 85418e2626e821cb98c47415c6be119ae3517b9a
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-03-07T04:15:15Z
ZEPPELIN-688: Giving an option to hide REPL output in spark interpreter
commit 36a6b8d4491ce5efcfff41b57a155afc0bd34639
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-03-07T05:22:09Z
Add Spark interpreter property table to docs/spark.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-688] Giving an option t...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/764#issuecomment-194073329
@Leemoonsoo Thanks for your suggestion. I've just added a sentence as you said : )
Plus, I rebased since #760 and this PR both changed `sparkInterpreter.java`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-688] Giving an option t...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/764#issuecomment-194620954
Merge if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-688] Giving an option t...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/764#issuecomment-194105419
Thanks. it looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-688] Giving an option t...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/764#issuecomment-194686251
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-688] Giving an option t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/764
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---