You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/20 20:36:44 UTC
[GitHub] [maven-compiler-plugin] elharo commented on a change in pull request #34: [MCOMPILER-428] improve incremental compilation documentation
elharo commented on a change in pull request #34:
URL: https://github.com/apache/maven-compiler-plugin/pull/34#discussion_r508822671
##########
File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
##########
@@ -483,7 +483,18 @@
private List<String> fileExtensions;
/**
- * to enable/disable incrementation compilation feature
+ * to enable/disable incrementation compilation feature.<br>
+ * This leads to two different modes
+ * <ul>
+ * <li>true <strong>(default)</strong> in this mode the compiler plugin will determine whether any JAR files the
+ * current module depends on have been changed in the current build run, or any source file was added, removed or
+ * changed since the last compilation. If this is the case, the compiler plugin recompiles all sources</li>
+ * <li>false <strong>(not recommended)</strong> this will only compile source files which are newer than their
+ * corresponding class files, i.e. which have been changed since the last compilation process. This will not
Review comment:
", i.e." --> . That is,
delete "process"
will not --> does not
##########
File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
##########
@@ -483,7 +483,18 @@
private List<String> fileExtensions;
/**
- * to enable/disable incrementation compilation feature
+ * to enable/disable incrementation compilation feature.<br>
+ * This leads to two different modes
+ * <ul>
+ * <li>true <strong>(default)</strong> in this mode the compiler plugin will determine whether any JAR files the
Review comment:
will determine --> determines (tech writing lives in the eternal present)
##########
File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
##########
@@ -483,7 +483,18 @@
private List<String> fileExtensions;
/**
- * to enable/disable incrementation compilation feature
+ * to enable/disable incrementation compilation feature.<br>
+ * This leads to two different modes
+ * <ul>
+ * <li>true <strong>(default)</strong> in this mode the compiler plugin will determine whether any JAR files the
+ * current module depends on have been changed in the current build run, or any source file was added, removed or
+ * changed since the last compilation. If this is the case, the compiler plugin recompiles all sources</li>
+ * <li>false <strong>(not recommended)</strong> this will only compile source files which are newer than their
Review comment:
will only compile --> only compiles
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org